Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 18 Jul 2022 14:29:18 -0400
From:   Rodrigo Vivi <rodrigo.vivi@intel.com>
To:     Jason Wang <wangborong@cdjrlc.com>
CC:     <daniel@ffwll.ch>, <airlied@linux.ie>,
        <jani.nikula@linux.intel.com>, <joonas.lahtinen@linux.intel.com>,
        <tvrtko.ursulin@linux.intel.com>, <ramalingam.c@intel.com>,
        <thomas.hellstrom@linux.intel.com>, <matthew.auld@intel.com>,
        <dan.carpenter@oracle.com>, <intel-gfx@lists.freedesktop.org>,
        <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/i915/gt: Remove unneeded semicolon
Message-ID: <YtWmfuJ9EvnFDh2t@intel.com>
References: <20220716184439.72056-1-wangborong@cdjrlc.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220716184439.72056-1-wangborong@cdjrlc.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aYqzH2Zm1O9JAD/Dvl3PRMF8cOP5iXApXfI6bG6ZaTBmNaOv3wq5G3XNQihi?=
 =?us-ascii?Q?2PlXjVGyb+FbClSLo02/PYV6BOrn0LcFiXKlaThWv/2f1q0uaJAfqT+UzLJd?=
 =?us-ascii?Q?zmJ+JxDtjjw4KRdJlfB+S65bO8VzlOlv1vceX9wMgWu1JrqLne4s6E/h47Wz?=
 =?us-ascii?Q?KzPursK3Ajcedp/0rKHcSa8NCkmjYLbp+z2H0iQXJfqKuKm+SDSY8inoVc1e?=
 =?us-ascii?Q?4ZamkomGblfbGG9W7VtUlGanXHZoYj0j5ZwssOp1w7eqYYbg6bnVx8kJBiKc?=
 =?us-ascii?Q?ylXK/YR9hmYRHJY/vXBi9p9kIU/f1V0QBiSSG5wFs3Gt3PiB4FXXnmXpA3QI?=
 =?us-ascii?Q?0tzMHTYVzLb+vGACLrDu51y+OKq1eBh0ItsuqqmpPIk18uyEFuEJrFHd30S2?=
 =?us-ascii?Q?BrFSpX/YQVPYhTELTFuTw8UbdRJd6aCNFVhxoj/7YuoAz45VB9HIL/7uZxwC?=
 =?us-ascii?Q?puvXAj2BP6MbnfU/jOxN6B2nYg05mY66f5INLRDSKYS1kRcwvVTg2pJmDUsa?=
 =?us-ascii?Q?hB3+zRG3MnlGGdAUfvgmyi2LD/Ajw4OZbhs7q1C0KDuHe/qwGTyDQcfTgtcO?=
 =?us-ascii?Q?PrOt6ELzf5uR2irULOmAlG28sSnzEP8bd9AnxLrxijj6qg46wuHeh7Utjtda?=
 =?us-ascii?Q?0kzfaGhSkwgbZAAa+lKJOXIYv2ZNJgMgwMHmeFqrik/vL5MZZ9D1qneF6s4L?=
 =?us-ascii?Q?VOYF99J/CLcggUlKtpE3+RaGhbOIuUSTjIelrWwQ3eIU3IXfqnpG1itoEGNQ?=
 =?us-ascii?Q?IbFir9FczPfvBR/8++7qnctpBRpcmxx6BKixKs7LKx1WDE0D2yOusFKjC4ER?=
 =?us-ascii?Q?8r7s/8IjVbnw1Cle64wdrtPEhubR3ZPMlBwg3dX6sgjixXzf1QgPd/du51x1?=
 =?us-ascii?Q?nxbDsN1rYmkpfJY3/xK+qUhANy+T+nT0Cp3MUI6HrwZcr26EWQt9hyfT9qeb?=
 =?us-ascii?Q?QLkg19gcwGnJ5DuzjDh3YbkNljAro+paH+aJGbUfTXGIISjWbV+CErAXqlrq?=
 =?us-ascii?Q?6plVR05zDlRHiUm06tjqA9zO3ILVm3HKMSaLuP4g7lyE9pLnMsyKOathYIy+?=
 =?us-ascii?Q?1pUUM7yo/wFmtrWFd325cQN3UH6Br3PDJKGZKCcEd1lcQU9YQTZ3UxTXHM5v?=
 =?us-ascii?Q?6JWULGy3QujH3S4qvQN0HpUBOAlgntmDihTJxpuAwI8Cg1TSUpVpy3nYT+SC?=
 =?us-ascii?Q?jb/tKKXL/xARM08iLKSuMSMF1STd1ZYAMxL3MLMpfE0g1f1QzZDX78Cm/hK4?=
 =?us-ascii?Q?kmAE2ZJHOk/6S1T0E3O+l/Bxeg/yTWVuRb3SPQYiXHH3vT7dMDT4OG3kHxQb?=
 =?us-ascii?Q?SQebGn4r6prQ/aJ37ogfqJNuFzO8x+8/zqccF4i3QHmYcd1X0oYZt2JcLk4k?=
 =?us-ascii?Q?RquaVZxkXp95Oy4/jITaknAeDXpeTWO+6A3eZ3jTvrRiSS1jYdbwPVLOfez2?=
 =?us-ascii?Q?aj1DuYSUJP3syzr+lJ31O3ufXsVf+q2KYu/I4ZJBLRqDcTp6Wf8rPIO3VmYD?=
 =?us-ascii?Q?9hR7x/irZ7dUkaFmNc1h+Bc0g8GCFK9B7P8ryXPWev47tj4eSBZV72OsMqLM?=
 =?us-ascii?Q?GgcSoxJH4lcxYzOGI39wEuklRBGE/AFCimwEDRUDQ4YS47Y4WgodQVT9cZe8?=
 =?us-ascii?Q?cw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e315cb18-784b-419b-a59f-08da68eb7025
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6059.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 18:29:23.6183
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TGv2puNxOcLj82LCdEhK1eW7Adsb3fDxwzNEj54w5lG7G9wfJXozm9x5r0XQlOoJKsUSXr7PW1HGZwgr2UFO+w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5793
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Jul 17, 2022 at 02:44:39AM +0800, Jason Wang wrote:
> The semicolon after the `}' in line 648 is unneeded.

same here

The line number changes... if you remove the "in line #"
the msg gets better.
With that changed:

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

>
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
>  drivers/gpu/drm/i915/gt/intel_migrate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c
> index 2c35324b5f68..a69b244f14d0 100644
> --- a/drivers/gpu/drm/i915/gt/intel_migrate.c
> +++ b/drivers/gpu/drm/i915/gt/intel_migrate.c
> @@ -645,7 +645,7 @@ static int scatter_list_length(struct scatterlist *sg)
>  	while (sg && sg_dma_len(sg)) {
>  		len += sg_dma_len(sg);
>  		sg = sg_next(sg);
> -	};
> +	}
>
>  	return len;
>  }
> --
> 2.35.1
>