Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220714164507.561751-1-mairacanal@riseup.net> <20220714164507.561751-8-mairacanal@riseup.net>
In-Reply-To: <20220714164507.561751-8-mairacanal@riseup.net>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 18 Jul 2022 14:59:05 -0400
Message-ID: <CADnq5_NwQWjGvMVxqPG1LcJkCV1MMJt9d25sXFkFQ8zUDw0sng@mail.gmail.com>
Subject: Re: [PATCH 08/12] drm/amd/display: Remove unused variables from dcn10_stream_encoder
To:     =?UTF-8?B?TWHDrXJhIENhbmFs?= <mairacanal@riseup.net>
Cc:     Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        Christian Koenig <christian.koenig@amd.com>,
        xinhui pan <Xinhui.Pan@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>,
        Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com>,
        Aurabindo Pillai <aurabindo.pillai@amd.com>,
        Magali Lemes <magalilemes00@gmail.com>,
        Tales Lelo da Aparecida <tales.aparecida@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        Melissa Wen <mwen@igalia.com>,
        Isabella Basso <isabbasso@riseup.net>, andrealmeid@riseup.net
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

Alex

On Thu, Jul 14, 2022 at 12:46 PM Ma=C3=ADra Canal <mairacanal@riseup.net> w=
rote:
>
> The variable regval from the function enc1_update_generic_info_packet
> and the variables dynamic_range_rgb and dynamic_range_ycbcr from the
> function enc1_stream_encoder_dp_set_stream_attribute are not currently
> used.
>
> This was pointed by clang with the following warnings:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_stream_encoder.c:62:=
11:
> warning: variable 'regval' set but not used [-Wunused-but-set-variable]
>         uint32_t regval;
>                  ^
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_stream_encoder.c:262=
:10:
> warning: variable 'dynamic_range_rgb' set but not used [-Wunused-but-set-=
variable]
>         uint8_t dynamic_range_rgb =3D 0; /*full range*/
>                 ^
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_stream_encoder.c:263=
:10:
> warning: variable 'dynamic_range_ycbcr' set but not used [-Wunused-but-se=
t-variable]
>         uint8_t dynamic_range_ycbcr =3D 1; /*bt709*/
>                 ^
> 3 warnings generated.
>
> Signed-off-by: Ma=C3=ADra Canal <mairacanal@riseup.net>
> ---
>  .../drm/amd/display/dc/dcn10/dcn10_stream_encoder.c    | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_stream_encoder.c =
b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_stream_encoder.c
> index c99c6fababa9..484e7cdf00b8 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_stream_encoder.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_stream_encoder.c
> @@ -59,7 +59,6 @@ void enc1_update_generic_info_packet(
>         uint32_t packet_index,
>         const struct dc_info_packet *info_packet)
>  {
> -       uint32_t regval;
>         /* TODOFPGA Figure out a proper number for max_retries polling fo=
r lock
>          * use 50 for now.
>          */
> @@ -88,7 +87,6 @@ void enc1_update_generic_info_packet(
>         REG_UPDATE(AFMT_VBI_PACKET_CONTROL, AFMT_GENERIC_CONFLICT_CLR, 1)=
;
>
>         /* choose which generic packet to use */
> -       regval =3D REG_READ(AFMT_VBI_PACKET_CONTROL);
>         REG_UPDATE(AFMT_VBI_PACKET_CONTROL,
>                         AFMT_GENERIC_INDEX, packet_index);
>
> @@ -259,8 +257,6 @@ void enc1_stream_encoder_dp_set_stream_attribute(
>         uint32_t h_back_porch;
>         uint8_t synchronous_clock =3D 0; /* asynchronous mode */
>         uint8_t colorimetry_bpc;
> -       uint8_t dynamic_range_rgb =3D 0; /*full range*/
> -       uint8_t dynamic_range_ycbcr =3D 1; /*bt709*/
>         uint8_t dp_pixel_encoding =3D 0;
>         uint8_t dp_component_depth =3D 0;
>
> @@ -372,18 +368,15 @@ void enc1_stream_encoder_dp_set_stream_attribute(
>         switch (output_color_space) {
>         case COLOR_SPACE_SRGB:
>                 misc1 =3D misc1 & ~0x80; /* bit7 =3D 0*/
> -               dynamic_range_rgb =3D 0; /*full range*/
>                 break;
>         case COLOR_SPACE_SRGB_LIMITED:
>                 misc0 =3D misc0 | 0x8; /* bit3=3D1 */
>                 misc1 =3D misc1 & ~0x80; /* bit7 =3D 0*/
> -               dynamic_range_rgb =3D 1; /*limited range*/
>                 break;
>         case COLOR_SPACE_YCBCR601:
>         case COLOR_SPACE_YCBCR601_LIMITED:
>                 misc0 =3D misc0 | 0x8; /* bit3=3D1, bit4=3D0 */
>                 misc1 =3D misc1 & ~0x80; /* bit7 =3D 0*/
> -               dynamic_range_ycbcr =3D 0; /*bt601*/
>                 if (hw_crtc_timing.pixel_encoding =3D=3D PIXEL_ENCODING_Y=
CBCR422)
>                         misc0 =3D misc0 | 0x2; /* bit2=3D0, bit1=3D1 */
>                 else if (hw_crtc_timing.pixel_encoding =3D=3D PIXEL_ENCOD=
ING_YCBCR444)
> @@ -393,15 +386,12 @@ void enc1_stream_encoder_dp_set_stream_attribute(
>         case COLOR_SPACE_YCBCR709_LIMITED:
>                 misc0 =3D misc0 | 0x18; /* bit3=3D1, bit4=3D1 */
>                 misc1 =3D misc1 & ~0x80; /* bit7 =3D 0*/
> -               dynamic_range_ycbcr =3D 1; /*bt709*/
>                 if (hw_crtc_timing.pixel_encoding =3D=3D PIXEL_ENCODING_Y=
CBCR422)
>                         misc0 =3D misc0 | 0x2; /* bit2=3D0, bit1=3D1 */
>                 else if (hw_crtc_timing.pixel_encoding =3D=3D PIXEL_ENCOD=
ING_YCBCR444)
>                         misc0 =3D misc0 | 0x4; /* bit2=3D1, bit1=3D0 */
>                 break;
>         case COLOR_SPACE_2020_RGB_LIMITEDRANGE:
> -               dynamic_range_rgb =3D 1; /*limited range*/
> -               break;
>         case COLOR_SPACE_2020_RGB_FULLRANGE:
>         case COLOR_SPACE_2020_YCBCR:
>         case COLOR_SPACE_XR_RGB:
> --
> 2.36.1
>