Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 18 Jul 2022 12:15:07 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     "Luck, Tony" <tony.luck@intel.com>,
        "chu, jane" <jane.chu@oracle.com>, "bp@alien8.de" <bp@alien8.de>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "x86@kernel.org" <x86@kernel.org>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        "Williams, Dan J" <dan.j.williams@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "hch@lst.de" <hch@lst.de>,
        "nvdimm@lists.linux.dev" <nvdimm@lists.linux.dev>
Subject: RE: [PATCH v3] x86/mce: retrieve poison range from hardware
Message-ID: <62d5b13b2cf1a_9291929433@dwillia2-xfh.jf.intel.com.notmuch>
References: <20220717234805.1084386-1-jane.chu@oracle.com>
 <41db4a4b17a848798e487a058a2bc237@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <41db4a4b17a848798e487a058a2bc237@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?otMCiK2WQSQLrxA53S7Z4/hiwrw3JNwcPM5V3D9mvkB28xx0acMbCrIJOi7k?=
 =?us-ascii?Q?1iKSLuVrjieRKT2JfEIaOi1rcvHakuMypnBXtlgAlH4eBxr2CfA0SOvZdwyL?=
 =?us-ascii?Q?3q72JVPam0mkiy9rVPq4W3jmIT0jO5w7gp/ZeSpGmgLoC9MQgWNLtNMaMfQY?=
 =?us-ascii?Q?Z0CkLD862ZHWhiJZWwjARW4xWeKPTfeXybg9ZCTvdqYt6FV++5hFEKQ+GFsc?=
 =?us-ascii?Q?kZxT1h1NjDkj2U+U25Rda6dRv5xLdRfXuSVpnTdjo8rmi/5QDHmqwrb7wWw0?=
 =?us-ascii?Q?SDmjvKZAGjinTkD3S/xwbtq5Tyc1p1S4OPMGE8s0/RA94ynBCJuy/dW6VxhS?=
 =?us-ascii?Q?5wrAeR3SLgZ7TBJZ0uddhKgsWWnNwwD7rfLkCy7LzhgoEAy5biQQ2SGffPMl?=
 =?us-ascii?Q?c7NnLroGwX/iaHHbR0MFWRGaq5iijgf59oxE9wJJyqyZajKVMTHtcsumFL+j?=
 =?us-ascii?Q?GMFjs3dX38ec0pwij4YxpxCq0wuiWnpgnR3Jhf6PtkQokmhVy7aXvaeveOkl?=
 =?us-ascii?Q?9xW17DRGEh6LM27i7rUcZpXv9cZPc6Zo6PaFbmi78eaQ3yFpXf6cPyWJ4DWK?=
 =?us-ascii?Q?+8J4xwKFUnPTNgAprgbB6Y7CVJyOSh3+s/+5LXOEJflA8XvdyGSZ1EZNgbGd?=
 =?us-ascii?Q?YwNPtfK1W9VlafBu6giG9+3ZC27J5ClS0g7j7XSq+8O+pX9A80IMhkdDVNhK?=
 =?us-ascii?Q?6Kxs0FgPjuuAAT7R9qMnKw7ZoR8ZYXUfqOZbCb2sgYd+5JFVCXhMItYHXRLt?=
 =?us-ascii?Q?Lu1ZsDnpkGUje+0WRkBsikouS7uttcPZqcFh+sX1/lrCrsHa4vLg+EA+V154?=
 =?us-ascii?Q?5KtHOMiv3PwHfp8Bj3V4GIjFYZYrz9CO4HfRpBWCpaaPnM/EGVF3XPag8nCR?=
 =?us-ascii?Q?rFmvSHW+T78FQiRXFfz14+9KSoHakCa5e0NPVaNmJSs1luwT80gSANYEjg9z?=
 =?us-ascii?Q?VigShVuSSo8LFaSFUdZxsVmry1WgqY9FfQtXQnUCh7R4xmL2cN+3Vn2xxIVe?=
 =?us-ascii?Q?/Y5SQRubSYFSNFYWwdVmiknCVT+/OeUS1M1gGH8JV7+yvokSprq0wj2B5btx?=
 =?us-ascii?Q?5JUgKFRxrHIbZXsaUc4pwDY6BOcmLaUh3+SFjDtiUlxR29HecGRJStY/1onC?=
 =?us-ascii?Q?l3qufTonIau/BhkSOrkMOVCeEcwbMCOXimmsZKFM/znku/XUYD34jII+ZriQ?=
 =?us-ascii?Q?YvBp7WTCgOJQPSnq3djT95sEr5bYLlK6D/t3bM/ACdxtBuhpyi71x2+3ct3m?=
 =?us-ascii?Q?MbIamJ1DsFnxrygN0cPXAndylaMieJrADKnWzQLjb+HXAj5uar2aB8Ph2Bg+?=
 =?us-ascii?Q?n6nwjGs/Q4SnsCHOoNU49WkdGn0GxrFCaiDO3uWUsE5ojY1Qpq5keZM9Foxk?=
 =?us-ascii?Q?Pf2vr+bEm44Rw2Lpm5DCECIxUiyh1NobD+ZhBplKoSx1lrB98+Hcbtin47qz?=
 =?us-ascii?Q?W0z+9BKee3zVlYqWi9qO7yrIN2XC85ycphI1nydb+CpZzkrKyaI+J+Da9yEx?=
 =?us-ascii?Q?hs8FCxEpQQd0UbTRW0oBEGdQyQ5M9nqnVs5YP1NvX2WykMP38alOwyzvi4ix?=
 =?us-ascii?Q?4nA0I9rCiB2IjahQP1QtdfFgNteIoRWOp0MTc2lKf29xRVQy5Zbg3eTIi7fN?=
 =?us-ascii?Q?3g=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: eea127f6-6b5e-4d7e-92ba-08da68f1d4ef
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 19:15:09.7255
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fFUywQJBE0QX1Zd5zNrMI3mxXsoqD2IvWzJ31NLK7SguLGCyEl04zaWfgWkdEnOlsQ4lxvgLnL5DzTpkurqpxhBzlrROXBz+YCg4hbu++c0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3613
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Luck, Tony wrote:
> +m.misc = (MCI_MISC_ADDR_PHYS << 6) | __ffs64(mem_err->physical_addr_mask);
> 
> Do we want to unconditionally trust the sanity of the BIOS provided physical_address_mask?
> 
> There's a warning comment on the kernel __ffs64() function:
> 
>  * The result is not defined if no bits are set, so check that @word
>  * is non-zero before calling this.
> 
> Otherwise, this looks like a good idea.

It appears the kernel is trusting that ->physical_addr_mask is non-zero
in other paths. So this is at least equally broken in the presence of a
broken BIOS. The impact is potentially larger though with this change,
so it might be a good follow-on patch to make sure that
->physical_addr_mask gets fixed up to a minimum mask value.