Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220714164507.561751-1-mairacanal@riseup.net> <20220714164507.561751-6-mairacanal@riseup.net>
In-Reply-To: <20220714164507.561751-6-mairacanal@riseup.net>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 18 Jul 2022 14:56:53 -0400
Message-ID: <CADnq5_N8DLrfcp6xsrXT6Ch8MSfeHcPb+pgKEYYBeaXdvVTctQ@mail.gmail.com>
Subject: Re: [PATCH 06/12] drm/amd/display: Remove unused variables from dml_rq_dlg_get_dlg_params
To:     =?UTF-8?B?TWHDrXJhIENhbmFs?= <mairacanal@riseup.net>
Cc:     Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        Christian Koenig <christian.koenig@amd.com>,
        xinhui pan <Xinhui.Pan@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>,
        Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com>,
        Aurabindo Pillai <aurabindo.pillai@amd.com>,
        Magali Lemes <magalilemes00@gmail.com>,
        Tales Lelo da Aparecida <tales.aparecida@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        Melissa Wen <mwen@igalia.com>,
        Isabella Basso <isabbasso@riseup.net>, andrealmeid@riseup.net
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

Alex

On Thu, Jul 14, 2022 at 12:46 PM Ma=C3=ADra Canal <mairacanal@riseup.net> w=
rote:
>
> Remove the variables dispclk_delay_subtotal and dppclk_delay_subtotal fro=
m
> the function dml_rq_dlg_get_dlg_params.
>
> This was pointed by clang with the following warning:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn31/display_rq_dlg_calc_31=
.c:920:15:
> warning: variable 'dispclk_delay_subtotal' set but not used [-Wunused-but=
-set-variable]
>         unsigned int dispclk_delay_subtotal;
>                      ^
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn31/display_rq_dlg_calc_31=
.c:919:15:
> warning: variable 'dppclk_delay_subtotal' set but not used [-Wunused-but-=
set-variable]
>         unsigned int dppclk_delay_subtotal;
>                      ^
> 2 warnings generated.
>
> Signed-off-by: Ma=C3=ADra Canal <mairacanal@riseup.net>
> ---
>  .../dc/dml/dcn31/display_rq_dlg_calc_31.c     | 19 -------------------
>  1 file changed, 19 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc=
_31.c b/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c
> index c94cf6e01e25..66b82e4f05c6 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c
> @@ -866,7 +866,6 @@ static void dml_rq_dlg_get_dlg_params(
>  {
>         const display_pipe_source_params_st *src =3D &e2e_pipe_param[pipe=
_idx].pipe.src;
>         const display_pipe_dest_params_st *dst =3D &e2e_pipe_param[pipe_i=
dx].pipe.dest;
> -       const display_output_params_st *dout =3D &e2e_pipe_param[pipe_idx=
].dout;
>         const display_clocks_and_cfg_st *clks =3D &e2e_pipe_param[pipe_id=
x].clks_cfg;
>         const scaler_ratio_depth_st *scl =3D &e2e_pipe_param[pipe_idx].pi=
pe.scale_ratio_depth;
>         const scaler_taps_st *taps =3D &e2e_pipe_param[pipe_idx].pipe.sca=
le_taps;
> @@ -916,9 +915,6 @@ static void dml_rq_dlg_get_dlg_params(
>         unsigned int vupdate_width;
>         unsigned int vready_offset;
>
> -       unsigned int dppclk_delay_subtotal;
> -       unsigned int dispclk_delay_subtotal;
> -
>         unsigned int vstartup_start;
>         unsigned int dst_x_after_scaler;
>         unsigned int dst_y_after_scaler;
> @@ -1037,21 +1033,6 @@ static void dml_rq_dlg_get_dlg_params(
>         vupdate_width =3D dst->vupdate_width;
>         vready_offset =3D dst->vready_offset;
>
> -       dppclk_delay_subtotal =3D mode_lib->ip.dppclk_delay_subtotal;
> -       dispclk_delay_subtotal =3D mode_lib->ip.dispclk_delay_subtotal;
> -
> -       if (scl_enable)
> -               dppclk_delay_subtotal +=3D mode_lib->ip.dppclk_delay_scl;
> -       else
> -               dppclk_delay_subtotal +=3D mode_lib->ip.dppclk_delay_scl_=
lb_only;
> -
> -       dppclk_delay_subtotal +=3D mode_lib->ip.dppclk_delay_cnvc_formatt=
er + src->num_cursors * mode_lib->ip.dppclk_delay_cnvc_cursor;
> -
> -       if (dout->dsc_enable) {
> -               double dsc_delay =3D get_dsc_delay(mode_lib, e2e_pipe_par=
am, num_pipes, pipe_idx); // FROM VBA
> -               dispclk_delay_subtotal +=3D dsc_delay;
> -       }
> -
>         vstartup_start =3D dst->vstartup_start;
>         if (interlaced) {
>                 if (vstartup_start / 2.0 - (double) (vready_offset + vupd=
ate_width + vupdate_offset) / htotal <=3D vblank_end / 2.0)
> --
> 2.36.1
>