Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp3677908imw; Mon, 18 Jul 2022 12:29:44 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sgC0mSYnpcN73Nhsu4Uq+R4rUWVgZibxNgyeZhSvP7J5Nhy938B227eQccXQHpe9EaTnPb X-Received: by 2002:a65:5b44:0:b0:412:b6dc:7076 with SMTP id y4-20020a655b44000000b00412b6dc7076mr25247704pgr.601.1658172584656; Mon, 18 Jul 2022 12:29:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658172584; cv=none; d=google.com; s=arc-20160816; b=jJxY0zKYqfGNM5INF23RZQMAE0Iexb6/TDKne5AdpL4b4rJDli2hErcaYFWzE/WFnd jPrwBg1BtWAs+KnPpP6W/pIJA9y0LcG3QtlhqhHq3ocaLPi3pFGV6naHGkbxDjKByu1r 76jZ1erjIIMTJiTmmYQdUgAHK68hL5h54gMMhebTzt74fzw8OsQn5aF2yX70EBl9ijhF zRCiNmFxtJKSELBQjurG8tTDo9YT7sbgVl2Hz1KQS6EWvooIfe+ysvhjT4ANM3CNS46Q NGd9AXx8FE8Ma/C6GmyJJu9qFywYj5gO1RINJIr0VpOBLXvP5J6RBbt8ThlPdWb7F1xE NlVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:to:from:dkim-signature; bh=ZJEuLsMRKUxpd8gJCMilrz767jCkM6zmrnjpbeCFU9M=; b=yVNVXsyPVv9k5QhMLed3BfB3W5Gz7JE7xH0m7897vozqaGB9FG2aV82TMHJM5sCNJ8 DiPuWO2t01nlBGKPKBYENEpX6QPnx25LWX/mFg5hpUPN+u7LXF8/X0ZUK+7/gHgS9qfM lm4BlxqeKU3jA8KOeY669YA+wFP557vpgeVDsbBziQkgThex42SNX5lO09oJN2+zPRXi E5dobFsthisHZshq98apvZWiRR8mlOgXfReETLchWfmXWEB9XQOVVZcWBUD7oued4Dy4 wZqLWzYhPUfmy/NhPt/DHBSTJ6jYqZYpCl8fL5oITsGg62NgiVjU5Kd8D0ZZ6QAWm5bZ /pcA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=kKR9I4FV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q16-20020a170902edd000b0016cca5430aesi1832664plk.51.2022.07.18.12.29.29; Mon, 18 Jul 2022 12:29:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=kKR9I4FV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235201AbiGRTNH (ORCPT + 99 others); Mon, 18 Jul 2022 15:13:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234420AbiGRTNF (ORCPT ); Mon, 18 Jul 2022 15:13:05 -0400 Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F4182F037 for ; Mon, 18 Jul 2022 12:13:03 -0700 (PDT) Received: by mail-io1-xd30.google.com with SMTP id z132so10113454iof.0 for ; Mon, 18 Jul 2022 12:13:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=from:to:in-reply-to:references:subject:message-id:date:mime-version :content-transfer-encoding; bh=ZJEuLsMRKUxpd8gJCMilrz767jCkM6zmrnjpbeCFU9M=; b=kKR9I4FVfr4npYm/FwMPeGKnE1tPcWbWEboAMzIbnqmGPBfE0HhcHLODZX9wCjssBr pIUHKVSchsGIf/CRmXV3AjI6hb232hHVwMabwFCJwXNIzJhMe/b9sVmdtA2r7mtLtfFs 4twaLIAXt43x48uQ5vN9z2s1Z8E0PIpg4DoZaTTW6AhYaKY+mAfb2Nhd5DQjizgXwESg T8haaDru1vuB3FX/EN/76vlFksF1xER108KfwUr4xtLQVmchCdtRad8ClkBLQ68m5n2e zOHsoZG6c7eLCsvZXa1YWo7tTEuhqAOgjhUsI6N7yKddSlOuvbqqmJHFYFtZfMG7vadu hIig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:in-reply-to:references:subject :message-id:date:mime-version:content-transfer-encoding; bh=ZJEuLsMRKUxpd8gJCMilrz767jCkM6zmrnjpbeCFU9M=; b=BBSkt1LjiTvYWyAWj/HO+nizME61FeGQOSOVrNr1UivK0LDcev7xSff962OBWVdqlk eOarVNR73flWDK8wHsZO4MMPs3bYsupAPYJg3PsIOIQ0mIPqH7DokFyX9HevdfQweLLo eWGV1j8k58dtVDnQNZypMhmWaapDZ8ViuWukzR1K1kCcjQ5zTMqnOHnmUNhysS7F2QZ5 0Auwi9W2TaLd2vNzP26B+lrku5xUz6nhUbn9ObcYYqzzd9JyilR8msY3N5zt4jGSyvtI K91QarYTb4vKOYxK8PiAOt1eRE1CzZ1T1bO5Z4RrPQaG8xnS4y7/g4meZ10AbzESgt3H d5JA== X-Gm-Message-State: AJIora9uIS5geJpQxA0rXUQSeKYJYYmWdoRA4QDNsMcYfyYgZw0JJKXO xkM3r0oc+wogwITxmd3CigjJG/bpv7qFGw== X-Received: by 2002:a05:6638:1a1a:b0:33f:405d:b1ed with SMTP id cd26-20020a0566381a1a00b0033f405db1edmr15085179jab.164.1658171582231; Mon, 18 Jul 2022 12:13:02 -0700 (PDT) Received: from [127.0.1.1] ([207.135.234.126]) by smtp.gmail.com with ESMTPSA id j195-20020a0263cc000000b003417ba4f66asm725116jac.41.2022.07.18.12.13.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Jul 2022 12:13:01 -0700 (PDT) From: Jens Axboe To: linux-kernel@vger.kernel.org, yangyingliang@huawei.com, linux-block@vger.kernel.org In-Reply-To: <20220718042408.3132835-1-yangyingliang@huawei.com> References: <20220718042408.3132835-1-yangyingliang@huawei.com> Subject: Re: [PATCH -next] ublk_drv: fix missing error return code in ublk_add_dev() Message-Id: <165817158152.143885.14328206381467598787.b4-ty@kernel.dk> Date: Mon, 18 Jul 2022 13:13:01 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 18 Jul 2022 12:24:08 +0800, Yang Yingliang wrote: > If blk_mq_init_queue() fails, it should return error code in ublk_add_dev() > > Applied, thanks! [1/1] ublk_drv: fix missing error return code in ublk_add_dev() commit: f50e5d670c622349277a46996a70386cc3661b10 Best regards, -- Jens Axboe