Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 18 Jul 2022 13:16:27 -0600
From:   Rob Herring <robh@kernel.org>
To:     Akhil R <akhilrajeev@nvidia.com>
Cc:     dmaengine@vger.kernel.org, jonathanh@nvidia.com,
        ldewangan@nvidia.com, linux-kernel@vger.kernel.org,
        linux-tegra@vger.kernel.org, p.zabel@pengutronix.de,
        thierry.reding@gmail.com, vkoul@kernel.org,
        devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: dmaengine: Add compatible for
 Tegra234
Message-ID: <20220718191627.GA3375779-robh@kernel.org>
References: <20220711154536.41736-1-akhilrajeev@nvidia.com>
 <20220711154536.41736-2-akhilrajeev@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220711154536.41736-2-akhilrajeev@nvidia.com>
Precedence: bulk

On Mon, Jul 11, 2022 at 09:15:34PM +0530, Akhil R wrote:
> Document the compatible string used by GPCDMA controller for Tegra234.
> 
> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> ---
>  .../devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml      | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> index 9dd1476d1849..399edcd5cecf 100644
> --- a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> +++ b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> @@ -26,6 +26,10 @@ properties:
>            - const: nvidia,tegra194-gpcdma
>            - const: nvidia,tegra186-gpcdma
>  
> +      - items:
> +          - const: nvidia,tegra234-gpcdma

This can be added to the above entry changing it from a const to enum.

> +          - const: nvidia,tegra186-gpcdma
> +
>    "#dma-cells":
>      const: 1
>  
> -- 
> 2.17.1
> 
>