Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220714191745.45512-1-andrealmeid@igalia.com> <20220714191745.45512-2-andrealmeid@igalia.com>
In-Reply-To: <20220714191745.45512-2-andrealmeid@igalia.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 18 Jul 2022 15:26:42 -0400
Message-ID: <CADnq5_MBa3ip2De7ztVpBAaupnynjAnO0sBcd2_io7Y2Pnkywg@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] Documentation/gpu: Add GFXOFF section
To:     =?UTF-8?Q?Andr=C3=A9_Almeida?= <andrealmeid@igalia.com>
Cc:     Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
        Pan Xinhui <Xinhui.Pan@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Hawking Zhang <Hawking.Zhang@amd.com>,
        Tao Zhou <tao.zhou1@amd.com>,
        Felix Kuehling <Felix.Kuehling@amd.com>,
        Jack Xiao <Jack.Xiao@amd.com>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Tom St Denis <tom.stdenis@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        kernel-dev@igalia.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied the series with some minor tweaks to the documentation.

Thanks!

Alex

On Thu, Jul 14, 2022 at 3:18 PM Andr=C3=A9 Almeida <andrealmeid@igalia.com>=
 wrote:
>
> Add a GFXOFF section at "GPU Power Controls" file, explaining what it is
> and how userspace can interact with it.
>
> Signed-off-by: Andr=C3=A9 Almeida <andrealmeid@igalia.com>
> ---
> Changes from v1: file created
>
>  Documentation/gpu/amdgpu/thermal.rst | 41 ++++++++++++++++++++++++++++
>  1 file changed, 41 insertions(+)
>
> diff --git a/Documentation/gpu/amdgpu/thermal.rst b/Documentation/gpu/amd=
gpu/thermal.rst
> index 8aeb0186c9ef..14c0fb874cf6 100644
> --- a/Documentation/gpu/amdgpu/thermal.rst
> +++ b/Documentation/gpu/amdgpu/thermal.rst
> @@ -63,3 +63,44 @@ gpu_metrics
>
>  .. kernel-doc:: drivers/gpu/drm/amd/pm/amdgpu_pm.c
>     :doc: gpu_metrics
> +
> +GFXOFF
> +=3D=3D=3D=3D=3D=3D
> +
> +GFXOFF is a feature found in some mobile GPUs that saves power consumpti=
on. The
> +card's firmware uses RLC (RunList Controller) to power off the gfx engin=
e
> +dynamically when there is no workload on gfx pipe and puts gfx into "idl=
e"
> +state. GFXOFF is on by default on supported GPUs.
> +
> +Userspace can interact with GFXOFF through a debugfs interface:
> +
> +``amdgpu_gfxoff``
> +-----------------
> +
> +Use it to enable/disable GFXOFF, and to check if it's current enabled/di=
sabled::
> +
> +  $ xxd -l1 -p /sys/kernel/debug/dri/0/amdgpu_gfxoff
> +  01
> +
> +- Write 0 to disable it, and 1 to enable it.
> +- Read 0 means it's disabled, 1 it's enabled.
> +
> +If it's enabled, that means that the GPU is free to enter into GFXOFF mo=
de as
> +needed. Disabled means that it will never enter GFXOFF mode.
> +
> +``amdgpu_gfxoff_status``
> +------------------------
> +
> +Read it to check current GFXOFF's status of a GPU::
> +
> +  $ xxd -l1 -p /sys/kernel/debug/dri/0/amdgpu_gfxoff_status
> +  02
> +
> +- 0: GPU is in GFXOFF state, the gfx engine is powered down.
> +- 1: Transition out of GFXOFF state
> +- 2: Not in GFXOFF state
> +- 3: Transition into GFXOFF state
> +
> +If GFXOFF is enabled, the value will be transitioning around [0, 3], alw=
ays
> +getting into 0 when possible. When it's disabled, it's always at 2. Retu=
rns
> +``-EINVAL`` if it's not supported.
> --
> 2.37.0
>