Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220629213632.3899212-1-blakejones@google.com>
 <Yr6u/jdLvg2TcT8s@krava> <YtVzVZoo5PTj0qXH@kernel.org> <CAP_z_CjUi-Uk_mftfw33+eac13sLyHMBtQJd8V393SaD4OocNg@mail.gmail.com>
 <YtW1aFY4MyeqxhdH@kernel.org>
In-Reply-To: <YtW1aFY4MyeqxhdH@kernel.org>
From:   Blake Jones <blakejones@google.com>
Date:   Mon, 18 Jul 2022 13:22:50 -0700
Message-ID: <CAP_z_CgPPg7o1TYyQ0b9MtEO17X-69Te3zOfocXK2MYc-SmPmA@mail.gmail.com>
Subject: Re: [PATCH v3] Add a "-m" option to "perf buildid-list".
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Jiri Olsa <olsajiri@gmail.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Ian Rogers <irogers@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Ah yeah of course, sorry about that!


On Mon, Jul 18, 2022 at 12:33 PM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> Em Mon, Jul 18, 2022 at 10:07:32AM -0700, Blake Jones escreveu:
> > Fabulous, thanks!
> >
> > On Mon, Jul 18, 2022 at 7:51 AM Arnaldo Carvalho de Melo <acme@kernel.org>
> > wrote:
> > > > > Signed-off-by: Blake Jones <blakejones@google.com>
> > > >
> > > > Acked-by: Jiri Olsa <jolsa@kernel.org>
> > >
> > > To clarify, b4 found v3 and that was the one applied.
>
> Now fixing this:
>
>   28     5.28 debian:experimental-x-mips    : FAIL gcc version 11.2.0 (Debian 11.2.0-18)
>     builtin-buildid-list.c: In function 'buildid__map_cb':
>     builtin-buildid-list.c:32:24: error: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'u64' {aka 'long long unsigned int'} [-Werror=format=]
>        32 |         printf("%s %16lx %16lx", bid_buf, map->start, map->end);
>           |                    ~~~~^                  ~~~~~~~~~~
>           |                        |                     |
>           |                        long unsigned int     u64 {aka long long unsigned int}
>           |                    %16llx
>     builtin-buildid-list.c:32:30: error: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'u64' {aka 'long long unsigned int'} [-Werror=format=]
>        32 |         printf("%s %16lx %16lx", bid_buf, map->start, map->end);
>           |                          ~~~~^                        ~~~~~~~~
>           |                              |                           |
>           |                              long unsigned int           u64 {aka long long unsigned int}
>           |                          %16llx
>     cc1: all warnings being treated as errors
>   29    23.06 debian:experimental-x-mips64  : Ok   mips64-linux-gnuabi64-gcc (Debian 10.2.1-6) 10.2.1 20210110
>   30     6.08 debian:experimental-x-mipsel  : FAIL gcc version 11.2.0 (Debian 11.2.0-18)
>     builtin-buildid-list.c: In function 'buildid__map_cb':
>     builtin-buildid-list.c:32:24: error: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'u64' {aka 'long long unsigned int'} [-Werror=format=]
>        32 |         printf("%s %16lx %16lx", bid_buf, map->start, map->end);
>           |                    ~~~~^                  ~~~~~~~~~~
>           |                        |                     |
>           |                        long unsigned int     u64 {aka long long unsigned int}
>           |                    %16llx
>     builtin-buildid-list.c:32:30: error: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'u64' {aka 'long long unsigned int'} [-Werror=format=]
>        32 |         printf("%s %16lx %16lx", bid_buf, map->start, map->end);
>           |                          ~~~~^                        ~~~~~~~~
>           |                              |                           |
>           |                              long unsigned int           u64 {aka long long unsigned int}
>           |                          %16llx
>     cc1: all warnings being treated as errors
>
>
> These should use PRIx64, etc.
>
> - Arnaldo