Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 18 Jul 2022 22:44:05 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     Dave Hansen <dave.hansen@intel.com>
Cc:     Kristen Carlson Accardi <kristen@linux.intel.com>,
        linux-tip-commits@vger.kernel.org,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Shakeel Butt <shakeelb@google.com>,
        Roman Gushchin <roman.gushchin@linux.dev>, x86@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [tip: x86/urgent] x86/sgx: Set active memcg prior to shmem
 allocation
Message-ID: <YtXGFWOJ4Z3BURa3@zn.tnic>
References: <20220520174248.4918-1-kristen@linux.intel.com>
 <165419442842.4207.2566961916839377924.tip-bot2@tip-bot2>
 <YtUs3MKLzFg+rqEV@zn.tnic>
 <b1476c7d-c514-227f-2735-092b5afb7d3a@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <b1476c7d-c514-227f-2735-092b5afb7d3a@intel.com>
Precedence: bulk

On Mon, Jul 18, 2022 at 11:52:54AM -0700, Dave Hansen wrote:
> As a further cleanup, it would probably be nice to explicitly document
> that "lookup" and "alloc" also require a subsequent "put". 

Certainly. That is not really clear from the sparse comments over it.

> It would also be nice to change sgx_encl_get_backing() to
> __sgx_encl_get_backing() to make it clear that it's an internal thing.
>
> So, I think the _code_ is OK as-is, but it could use some more love.

That makes a lot more sense.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette