Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <57f1b92b-3422-7d3c-96ae-10ad5d3d22c4@nvidia.com>
Date:   Mon, 18 Jul 2022 14:32:03 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v2 0/6] gpiolib: cdev: code cleanup following hte
 integration
Content-Language: en-US
To:     Kent Gibson <warthog618@gmail.com>, linux-kernel@vger.kernel.org,
        linux-gpio@vger.kernel.org, brgl@bgdev.pl,
        linus.walleij@linaro.org, andy.shevchenko@gmail.com
References: <20220714020319.72952-1-warthog618@gmail.com>
From:   Dipen Patel <dipenp@nvidia.com>
In-Reply-To: <20220714020319.72952-1-warthog618@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MHkraGhHM0VwRHU2TWNKa2lTUG42SnpNVHltMEt2Q2lINDg2WXcwbUFoNStz?=
 =?utf-8?B?VTlNbHpMYzZ2TktQS040VXlRa1dDZ015dm5kY2hUcTlaZkR1SmFVcll6anNn?=
 =?utf-8?B?NDJXK1ROWDJJYU4wM05xVWRFTUIrZDJTeUZWbVpLcENvdWNPek8xeG9UQkcz?=
 =?utf-8?B?dEw1QzJHZkNFNS9PS2VQa1NiVEF2ckxZc1kvY0RVVEpzaks5WkVJWVkwTlBO?=
 =?utf-8?B?YlZhM1dQb3VlUlFWOHZxcVFBcGpOR0lNZ2ZOR3lhcEZVaERjNS9CRHljMTlj?=
 =?utf-8?B?S2ErUjZpSnJqdlhQWFFOa01LNTZrZVBnRTVlREd2bDhBNHd3MDA5YXlNNU1n?=
 =?utf-8?B?WUh2cDNBc2RGS2pkVkZoek1SV2FJMjVOUGtPY0Q3WWdEc3NZRWlEWjVMQW9x?=
 =?utf-8?B?MnEwbFo5NmlhTG52L0JUeDlYRm5pOHFkRlNBWGtmUlVvSkNNTkZzR2xmdS90?=
 =?utf-8?B?Sys1M1ZjZk1hRjBwdkNVWDV2N2pjKytsMmcyckM2NklpZkFVN3MxM2czbmpi?=
 =?utf-8?B?T3RNZjNqaVlmemNBZTFWa3BJNHNiaVpTa1RGbm15Yk8zRnpqNTA4Qm5IRCsr?=
 =?utf-8?B?Q2dWOVhJSFBtanpxNFlhVHRWRk5TV2tUa2dvVmtPNlYzWit0ZklzMlplazlv?=
 =?utf-8?B?bytjZHNOaFN3VEdqTE93OUlXL0xIUFU1SE40b3RFYlpVSXhXaU9xTHNWOGMw?=
 =?utf-8?B?bXBBU3FYaXJ3b0xnU3FUQ3FrRkxyclVPZWlocVNRcWdTUjU5a0JOSE56RXY5?=
 =?utf-8?B?ajYzS2ZTckc4WWJYVmVabjZBdDdYZUZuNDlFNk5tQnNySkYwVGV5allEaFdi?=
 =?utf-8?B?a2x6blh3dHZ5VUNReStRVnJ1ZmE4a0ZXN1VISVVGVk4yWHBvUVZtNklxZ0JM?=
 =?utf-8?B?YVgraUVHaG16KzNHdjhsRDhRNE5JbmdWaWEzMnM4TXpZcmc4TW9FUjVZeER2?=
 =?utf-8?B?SE9RdlJSTHFmTlNYbWJBRkYrUmFadEI2Mnhyazc3QjQ1N3FqZHhtQ3JXTGRL?=
 =?utf-8?B?WVduTnJqMmU0TjJ0NXZUNUhUMEMrREJJZUpGdndnNy9IamZFVlUxUWp2Um5I?=
 =?utf-8?B?cDBOQlJtaVJZVFV4R2JXYlZtTXhPNGoyY08velZucUhuOVV0T3VOMXptMFo0?=
 =?utf-8?B?MWl0NW56ckdaVm1wbVdJL3BXQjNySnlvNzE0WU1iRXVwS1dwN2FVbXlHSkli?=
 =?utf-8?B?RFpjdWJMREVrOFd5VFpNWUpTWHdqRllUWDRlWmM4ZWpwbHF4OWJodXl0YVJy?=
 =?utf-8?B?WUxYZU5VRkQ2QUl2TWY1Z0NRZWE2eGdPRVBwRG52K0V4dG9sYlYzS0VQclg2?=
 =?utf-8?B?THpuYnNBb3JObW5yUDgwalpFck1FSi9jWDJUdXMrRGdJRVZ0QVU2ZnducnFU?=
 =?utf-8?B?UFhHa1diK25TR3ZDenV3YU9mdnNMOFNXRlV5ZE4xU0tuVlc2MXdpRHN5dWgx?=
 =?utf-8?B?TW9XN1luanZLTXhkUzhvNXN3amJEL09nVkhyakZzYUhRanlKYmZvWS9vc3Bw?=
 =?utf-8?B?MWFtN2Q4K2xqZDZhcnJrNkVpVFNkT1dQc0JIRURCYml1M0hjV3ZrcTZub1hS?=
 =?utf-8?B?emtqVkxhb2JxUUgxYTRLZlpuRnFWditwN2puSFAxOWV4RHcwU2JudXBrOXpD?=
 =?utf-8?B?YmxUNUhoSmgzUCt2UStUeDgycDBIUDJWSHF2TjNWU0xwc0VZb20weDlZbGhm?=
 =?utf-8?B?NTJKQ09YMzhqTFcxbXJ2NjZWd2NZcUpwblFPU1NGVDQzY2tRSWMrQ001Z2dP?=
 =?utf-8?B?a3BXU3plZVNlYjg2UXI3ejVORHQ1U0FIWjRUYnBkbVU4cEx0bG1CYXBlSFJ0?=
 =?utf-8?B?Q0NudzZpM0psUC9DQkpHNXk2alhDT1IzWlBEcXhiUlhOd2dhR3IrMnhqeHA4?=
 =?utf-8?B?NVNONlJBTVg5WGpiWXFFNGVKeHBGU1REOUpPSHNsdW52OUVPd3l6ZEoyRERM?=
 =?utf-8?B?NHBNTTR6SytkUjY5eGxPRkdMY0h0VnoxQmlWN3BkeHlZTHFvL29MMWxJYkJ1?=
 =?utf-8?B?RzJBOUd6eUpZNlNWOXZyTUZ1RHJkQk9BcjU0bGRBWUVFWmRrTHRUTnNrRUxR?=
 =?utf-8?B?aWJNQ21OdVlKaFc1WjBDN0VJb3R4NzlYNEh5UTg4TDhIK05kWEtGcnl2Qnk3?=
 =?utf-8?Q?yqJ7LNWdVEp8YSZ8+MvAIjgpf?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8712accb-a310-4051-3af5-08da6904f5ff
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4116.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 21:32:05.5527
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UcNszoO3UyMfvLwsm8HkP4FNm4iAnT/agIBHRTwG4ZYc/GAf7/5ZYqDQRU3kpIUJ2XxNMb8YcW7kyK+FqNYrYw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6066
X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/13/22 7:03 PM, Kent Gibson wrote:
> This patch series is a collection of improvements to simplify the
> code, improve readability, and compile out unused code.
> There are no functional changes.
>
> The first patch is a cleanup for my recent linereq_free() fix. I
> noted then that the edge_detector_stop() could probably be safely
> moved inside the line desc check block, but wanted to keep that
> change minimal just in case.  It can be safely moved, and so here
> it is.
>
> Patch 2 makes use of an existing macro to simplify a call.
>
> Patch 3 replaces some more if-else chains with switches, which is
> more readable (YMMV).
>
> Patch 4 reorganizes the line identification code to share code
> common to alternate paths.
>
> Patch 5 consolidates a number of separate flags into one.  This
> reduces code complexity, simplifies any future edge source additions,
> and makes patch 6 significantly simpler.
>
> Patch 6 totally compiles out the hte specific code when CONFIG_HTE
> is not selected.
>
> I've based this series on gpio/for-current, as it requires the fix
> patch -
> commit c8e27a4a5136 ("gpiolib: cdev: fix null pointer dereference in linereq_free()")
> Happy to rebase if that doesn't suit.
>
> Dipen, I don't have any HTE compatible hardware to test with, so
> could you check that this still works for you?

Only hte logic

Tested-by: Dipen Patel <dipenp@nvidia.com>

>
> Changes v1 -> v2:
>  Address Andy's review comments, specifically
>   - Patch 4 move ternary initializer into a helper function.
>   - Patch 5 variable declaration ordering.
>   - Patch 6 remove obsoleted comment and tidy some if expressions.
>
> Kent Gibson (6):
>   gpiolib: cdev: simplify linereq_free
>   gpiolib: cdev: simplify parameter in call to hte_edge_setup
>   gpiolib: cdev: replace if-else chains with switches
>   gpiolib: cdev: simplify line event identification
>   gpiolib: cdev: consolidate edge detector configuration flags
>   gpiolib: cdev: compile out HTE unless CONFIG_HTE selected
>
>  drivers/gpio/gpiolib-cdev.c | 291 +++++++++++++++++++-----------------
>  1 file changed, 151 insertions(+), 140 deletions(-)
>
>
> base-commit: 7329b071729645e243b6207e76bca2f4951c991b