Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp3838703imw; Mon, 18 Jul 2022 15:43:01 -0700 (PDT) X-Google-Smtp-Source: AGRyM1t7kUII22NtgeCRjp463r/VlLc/m9zz1VOAHcDvNflkxcihOUcg5RM/ZvZpTCZ/JGRknpJk X-Received: by 2002:a17:907:7608:b0:72b:4f33:bcce with SMTP id jx8-20020a170907760800b0072b4f33bccemr27388151ejc.252.1658184181736; Mon, 18 Jul 2022 15:43:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658184181; cv=none; d=google.com; s=arc-20160816; b=ROWAhMpoY3u4iNEU7eyEl0K4U7PnF19vOOs5Bfg3W8oBSQYjOqV1gsKRo0VI6le/Q7 KX74VFp3Hk+DawyOIt7aqys4UpboA6lj2/c7Laa0ZGMYOeWwoStDseYX2RyhmnDZsADj yenuHyHJkYYFN2dh7M9eS7EYVNyjoteTvNkryXW9T48Gcd+Fg8JtwJOnicUyt2ba5NGO Vb9HlE54slbGeQBCwTkrQxOkkCbBV9y3KOgKON4ejg2LTcBNhss6CL9VUln24BQONuOj RWs7KXnaWe/HsLIYOJgIrshnhWIY1v9nG+LBcCGohds/RStRJMJB5bp+IhrhrpqAEbG7 +UvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :message-id:subject:cc:to:from:date:dkim-signature; bh=nu7OKtBp+qhHDs6ezEmAccNAsl4zUd41PG6sPURFEb0=; b=rbnJ6GK9TOTx6sZJF2pvRyW0gxHt6Pwh5Cg2Xr2SzhGQjxFVMigJhrS4Dg9x9u4o+a pomraYJWf3qaWv27YLgL6FBESi0GEVPHmQsRzT444GKSq2tUb7VHCKF4C/mL0b2H2f4M OTiJdJieyHiDRdR3DLumtRq6/zXSsjshWyHR8RdhSypWtED89SPQl6zQfLzrbWlIghip CKei66e5o65kAjEiLSLBilL4TygssM2/fLrIiSNhqxyleNaY5R7/TL2IHheV4+f+2cT3 HYOBBuDZMWAUeua3POOSF1q1C6lAp1jmdg2i65etmosqlf1d+xhoOzuwTOwpLURTsDu+ RiDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=i6dod+Gg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cs18-20020a170906dc9200b0072b5ed5a846si19338333ejc.43.2022.07.18.15.42.36; Mon, 18 Jul 2022 15:43:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=i6dod+Gg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235276AbiGRWkH (ORCPT + 99 others); Mon, 18 Jul 2022 18:40:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234908AbiGRWkG (ORCPT ); Mon, 18 Jul 2022 18:40:06 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A85EA2BB04; Mon, 18 Jul 2022 15:40:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 364EBB817B1; Mon, 18 Jul 2022 22:40:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD605C341C0; Mon, 18 Jul 2022 22:40:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658184003; bh=1aFmPSkN+eagXMzM2UhrmyC197VaFyr+ob4HH3VJnOM=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=i6dod+Gg9t7S2m5jhwrZaYhc/CEWouVzPBYUpPvjCUfu415cW7RT36QV5KSiBUILw OJl5UhyysiCDFoXrVxQGsIangXj1B6qVawJg799QutQFlcLp9YrZCqDlJusiCOani9 bpvbsaGSehixnEzJpx/zrvG7tYndlGxUyz8MR/X2x9LpQKWng+eaPNm+5WdNBKZQm1 hS94aGjcPofP/LoU22U5Iqo+M2paLim9dJ9bfkLC30F4WD9EYcX8bSggJN6DIkd1ys qTcihfM+tBTVTZb9medpOau4UG/UVEnoYkvg3JMPc/2gsP6vr0eoLwK/fzaaXoyaF7 NrZxxEIFP09bg== Date: Mon, 18 Jul 2022 17:40:00 -0500 From: Bjorn Helgaas To: Jim Quinlan Cc: Jim Quinlan , "open list:PCI NATIVE HOST BRIDGE AND ENDPOINT DRIVERS" , Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" , Florian Fainelli , Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list Subject: Re: [PATCH v2 2/6] PCI: brcmstb: Split brcm_pcie_setup() into two funcs Message-ID: <20220718224000.GA1456196@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 18, 2022 at 02:56:03PM -0400, Jim Quinlan wrote: > On Mon, Jul 18, 2022 at 2:14 PM Bjorn Helgaas wrote: > > On Sat, Jul 16, 2022 at 06:24:49PM -0400, Jim Quinlan wrote: > > > Currently, the function does the setup for establishing PCIe link-up > > > with the downstream device, and it does the actual link-up as well. > > > The calling sequence is (roughly) the following in the probe: > > > > > > -> brcm_pcie_probe() > > > -> brcm_pcie_setup(); /* Set-up and link-up */ > > > -> pci_host_probe(bridge); > > > > > > This commit splits the setup function in two: brcm_pcie_setup(), which only > > > does the set-up, and brcm_pcie_start_link(), which only does the link-up. > > > The reason why we are doing this is to lay a foundation for subsequent > > > commits so that we can turn on any power regulators, as described in the > > > root port's DT node, prior to doing link-up. > > > > All drivers that care about power regulators turn them on before > > link-up, but typically those regulators are described directly under > > the host bridge itself. > > Actually, what you describe is what I proposed with my v1 back in Nov 2020. > The binding commit message said, > > "Quite similar to the regulator bindings found in > "rockchip-pcie-host.txt", this allows optional regulators to be > attached and controlled by the PCIe RC driver." > > > IIUC the difference here is that you have regulators described under > > Root Ports (not the host bridge/Root Complex itself), so you don't > > know about them until you've enumerated the Root Ports. > > brcm_pcie_probe() can't turn them on directly because it doesn't know > > what Root Ports are present and doesn't know about regulators below > > them. > > The reviewer's requested me to move the regulator node(s) > elsewhere, and at some point later it was requested to be placed > under the Root Port driver. I would love to return them under the > host bridge, just say the word! Actually, I think my understanding is wrong. Even though the PCI core hasn't enumerated the Root Port as a pci_dev, brcm_pcie_setup() knows about it and should be able to look up the regulators and turn them on. Can you dig up the previous discussion about why the regulators need to be under the Root Port and why they can't be turned on before calling pci_host_probe()? Bjorn