Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 18 Jul 2022 15:56:21 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     "Darrick J. Wong" <djwong@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>
CC:     "ruansy.fnst@fujitsu.com" <ruansy.fnst@fujitsu.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
        "nvdimm@lists.linux.dev" <nvdimm@lists.linux.dev>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "david@fromorbit.com" <david@fromorbit.com>,
        "hch@infradead.org" <hch@infradead.org>,
        "jane.chu@oracle.com" <jane.chu@oracle.com>
Subject: Re: [RFC PATCH v6] mm, pmem, xfs: Introduce MF_MEM_REMOVE for unbind
Message-ID: <62d5e515de3a_929192941e@dwillia2-xfh.jf.intel.com.notmuch>
References: <20220410171623.3788004-1-ruansy.fnst@fujitsu.com>
 <20220714103421.1988696-1-ruansy.fnst@fujitsu.com>
 <62d05eb8e663c_1643dc294fa@dwillia2-xfh.jf.intel.com.notmuch>
 <YtXbD4e8mLHqWSwL@magnolia>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <YtXbD4e8mLHqWSwL@magnolia>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1j2bbgLAckfSVdVyJerHhmlDq3y7hxWddLxJ/FTSEwkBVk7MaK2mn+R49n0Q?=
 =?us-ascii?Q?MUkbSyZ1OqUCk/UebDUT9t6YVulr6DZcy9qrk9gOebBw1STTSAW3DLp1nVoL?=
 =?us-ascii?Q?inv32Ki2XfdPiTcGDEB3km66Yd9Mna74OawsXC9rgMvjjWbdN5KcWivmu1M/?=
 =?us-ascii?Q?Zw/1cpFGFl+rjW7pmfodHpkSoPqmUVbilp8lNmc2U2anVfbAOwEcxCHiSkk4?=
 =?us-ascii?Q?evwFCjPyd7bEoV2Vn/Ro7uT8ZOScdms1v8hAFGPMrs9PW+qbfKefdAdcs2wK?=
 =?us-ascii?Q?32N8ZshMznGiv5BIn8u2iLRliVVdWpnVvSQ//ISYjoSzkYGYWFG2poEkQN2j?=
 =?us-ascii?Q?nLqOo+ES4iqz5xunWKV5biooVtKB0SV7/ctSQc7kLOCGj7i1grFnwzrbMHgh?=
 =?us-ascii?Q?tRiZq4aVe6rYHkf1+Rb2F+IODMGuYp/7f9umEXKELQx8hG4lPWP1HIADhHuO?=
 =?us-ascii?Q?GQH+30aEUwYMnfxo1KcgPiIce6i3XUqrdijHam40U2IOLXt9pSQGNOq2VG0D?=
 =?us-ascii?Q?hicT0Gk+pgEhxFYRpSomX+v+M+uuX5GhTeGqzfpJcAjzrag/NecynCv8vjFO?=
 =?us-ascii?Q?nU/um3C1en4ljUtOUdfGd+gDOg3L7k8lVQYWZbQzrsAg9OiaEiXXFae/2gpC?=
 =?us-ascii?Q?R7gQ+GvbjRaM60i8jGXHcqLtFWEi5/7WO49fmIqrtYAxGAx1hCYDve14j5cE?=
 =?us-ascii?Q?e3POHhtviym5G+9abvS9DK+QOxTwRtiNgd6TrKRZmNtYkGKMWsMjMbX79aOv?=
 =?us-ascii?Q?kVL0OkeNEFZSi20GRvQdg96nVyTacYoY/Wnn75Ka4f4qEcdSCjC2Rmw6WYpD?=
 =?us-ascii?Q?Rk/icqCQWGOHUuKT/hQzndbh//4Cn8TdfejImJ688naSvRobxLKoFb+1y289?=
 =?us-ascii?Q?X3Z3JO/frkrLaVy0zsnw+c6qwDd8+ccMc5t/dY/3EP0BXWLLL84CZn1FZckz?=
 =?us-ascii?Q?35TeIEdFaD5f+vGodpaj9AJTR0NRuqT2HfKWEkuZdC2Hj1UyC5iHDPG2rzVE?=
 =?us-ascii?Q?8AtnGZwQr2Cc2EDRHLp6XXTIPh3UOihAgT7u0TWVjd+I13BmUbjdz15lRfar?=
 =?us-ascii?Q?Y64ft3zbLwu4QHfkjamcF2do1LRa8I4LEEjXOwlt/SMNlbvwkVt4EfXfSEgp?=
 =?us-ascii?Q?jfMzpXQ5RirHlbRxF1aZSivubz+xnC1ghqW/umlzIhLIaNlqH0fFXnd2Y2TI?=
 =?us-ascii?Q?Ix70zh2i2goTREJVaFsPuGoWQgC+LGwUyG2JNiYIK9q+iq1h/LBoZFNm7nx5?=
 =?us-ascii?Q?K6nuNeQ1W0ZS8Sfjkvs1pGPZVLKHGBRdW80JnR7E7mzVhgPeVk++PaJTyQ7x?=
 =?us-ascii?Q?h37VwF8J95LpUZMobXOuUnjMJqgEMBvlviBqX2tDeUqengJ5rxO9WUrrA5Sz?=
 =?us-ascii?Q?GdXaSIOrshupRwZtp82b+ica6MsKmPHGEP1kfiEUAFd1Nt2arm922f4WLJzV?=
 =?us-ascii?Q?mfXRCD/5Nzi6HTAtVjWSLWX8C1yiJT0c+VJeHt7CQSBFNdn+mecb3XmG1MYp?=
 =?us-ascii?Q?amDj0LFvJROKn572RXaMZlfHTn3SSHqJYpn2vRO6rmXM/aEuVJhVo9TSweg7?=
 =?us-ascii?Q?PsjVrv1EXMH1FWEkw7HDati/wRWW0ppTpDoBvZNdsEPoHvpwrYd+82ppkjF/?=
 =?us-ascii?Q?xw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b30833be-9922-4b13-9cf6-08da6910bcbb
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 22:56:23.4870
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Hak7VjNaAZc869DeUuMpYaXsKgC54UnhUpnu5BYYdx3KAqLgoNDZCXMTaS/BN7jj99FlD8gIJpiUtGp8wakEFY1DiW+gQGNGSjslW8ZJbj4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1768
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Darrick J. Wong wrote:
> On Thu, Jul 14, 2022 at 11:21:44AM -0700, Dan Williams wrote:
> > ruansy.fnst@fujitsu.com wrote:
> > > This patch is inspired by Dan's "mm, dax, pmem: Introduce
> > > dev_pagemap_failure()"[1].  With the help of dax_holder and
> > > ->notify_failure() mechanism, the pmem driver is able to ask filesystem
> > > (or mapped device) on it to unmap all files in use and notify processes
> > > who are using those files.
> > > 
> > > Call trace:
> > > trigger unbind
> > >  -> unbind_store()
> > >   -> ... (skip)
> > >    -> devres_release_all()   # was pmem driver ->remove() in v1
> > >     -> kill_dax()
> > >      -> dax_holder_notify_failure(dax_dev, 0, U64_MAX, MF_MEM_PRE_REMOVE)
> > >       -> xfs_dax_notify_failure()
> > > 
> > > Introduce MF_MEM_PRE_REMOVE to let filesystem know this is a remove
> > > event.  So do not shutdown filesystem directly if something not
> > > supported, or if failure range includes metadata area.  Make sure all
> > > files and processes are handled correctly.
> > > 
> > > ==
> > > Changes since v5:
> > >   1. Renamed MF_MEM_REMOVE to MF_MEM_PRE_REMOVE
> > >   2. hold s_umount before sync_filesystem()
> > >   3. move sync_filesystem() after SB_BORN check
> > >   4. Rebased on next-20220714
> > > 
> > > Changes since v4:
> > >   1. sync_filesystem() at the beginning when MF_MEM_REMOVE
> > >   2. Rebased on next-20220706
> > > 
> > > [1]: https://lore.kernel.org/linux-mm/161604050314.1463742.14151665140035795571.stgit@dwillia2-desk3.amr.corp.intel.com/
> > > 
> > > Signed-off-by: Shiyang Ruan <ruansy.fnst@fujitsu.com>
> > > ---
> > >  drivers/dax/super.c         |  3 ++-
> > >  fs/xfs/xfs_notify_failure.c | 15 +++++++++++++++
> > >  include/linux/mm.h          |  1 +
> > >  3 files changed, 18 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/dax/super.c b/drivers/dax/super.c
> > > index 9b5e2a5eb0ae..cf9a64563fbe 100644
> > > --- a/drivers/dax/super.c
> > > +++ b/drivers/dax/super.c
> > > @@ -323,7 +323,8 @@ void kill_dax(struct dax_device *dax_dev)
> > >  		return;
> > >  
> > >  	if (dax_dev->holder_data != NULL)
> > > -		dax_holder_notify_failure(dax_dev, 0, U64_MAX, 0);
> > > +		dax_holder_notify_failure(dax_dev, 0, U64_MAX,
> > > +				MF_MEM_PRE_REMOVE);
> > >  
> > >  	clear_bit(DAXDEV_ALIVE, &dax_dev->flags);
> > >  	synchronize_srcu(&dax_srcu);
> > > diff --git a/fs/xfs/xfs_notify_failure.c b/fs/xfs/xfs_notify_failure.c
> > > index 69d9c83ea4b2..6da6747435eb 100644
> > > --- a/fs/xfs/xfs_notify_failure.c
> > > +++ b/fs/xfs/xfs_notify_failure.c
> > > @@ -76,6 +76,9 @@ xfs_dax_failure_fn(
> > >  
> > >  	if (XFS_RMAP_NON_INODE_OWNER(rec->rm_owner) ||
> > >  	    (rec->rm_flags & (XFS_RMAP_ATTR_FORK | XFS_RMAP_BMBT_BLOCK))) {
> > > +		/* Do not shutdown so early when device is to be removed */
> > > +		if (notify->mf_flags & MF_MEM_PRE_REMOVE)
> > > +			return 0;
> > >  		xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_ONDISK);
> > >  		return -EFSCORRUPTED;
> > >  	}
> > > @@ -174,12 +177,22 @@ xfs_dax_notify_failure(
> > >  	struct xfs_mount	*mp = dax_holder(dax_dev);
> > >  	u64			ddev_start;
> > >  	u64			ddev_end;
> > > +	int			error;
> > >  
> > >  	if (!(mp->m_sb.sb_flags & SB_BORN)) {
> > >  		xfs_warn(mp, "filesystem is not ready for notify_failure()!");
> > >  		return -EIO;
> > >  	}
> > >  
> > > +	if (mf_flags & MF_MEM_PRE_REMOVE) {
> > > +		xfs_info(mp, "device is about to be removed!");
> > > +		down_write(&mp->m_super->s_umount);
> > > +		error = sync_filesystem(mp->m_super);
> > > +		up_write(&mp->m_super->s_umount);
> > 
> > Are all mappings invalidated after this point?
> 
> No; all this step does is pushes dirty filesystem [meta]data to pmem
> before we lose DAXDEV_ALIVE...
> 
> > The goal of the removal notification is to invalidate all DAX mappings
> > that are no pointing to pfns that do not exist anymore, so just syncing
> > does not seem like enough, and the shutdown is skipped above. What am I
> > missing?
> 
> ...however, the shutdown above only applies to filesystem metadata.  In
> effect, we avoid the fs shutdown in MF_MEM_PRE_REMOVE mode, which
> enables the mf_dax_kill_procs calls to proceed against mapped file data.
> I have a nagging suspicion that in non-PREREMOVE mode, we can end up
> shutting down the filesytem on an xattr block and the 'return
> -EFSCORRUPTED' actually prevents us from reaching all the remaining file
> data mappings.
> 
> IOWs, I think that clause above really ought to have returned zero so
> that we keep the filesystem up while we're tearing down mappings, and
> only call xfs_force_shutdown() after we've had a chance to let
> xfs_dax_notify_ddev_failure() tear down all the mappings.
> 
> I missed that subtlety in the initial ~30 rounds of review, but I figure
> at this point let's just land it in 5.20 and clean up that quirk for
> -rc1.

Sure, this is a good baseline to incrementally improve.

> 
> > Notice that kill_dev_dax() does unmap_mapping_range() after invalidating
> > the dax device and that ensures that all existing mappings are gone and
> > cannot be re-established. As far as I can see a process with an existing
> > dax mapping will still be able to use it after this runs, no?
> 
> I'm not sure where in akpm's tree I find kill_dev_dax()?  I'm cribbing
> off of:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/tree/fs/xfs/xfs_notify_failure.c?h=mm-stable

https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/tree/drivers/dax/bus.c?h=mm-stable#n381

Where the observation is that when device-dax is told that the device is
going away it invalidates all the active mappings to that single
character-device-inode. The hope being that in the fsdax case all the
dax-mapped filesystem inodes would experience the same irreversible
invalidation as the device is exiting.