Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp3884653imw; Mon, 18 Jul 2022 16:43:35 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uiiYx/AgfqqFsF8qaVL+a+0l9L0xQyv5SPeauXiQWopyot4FpCHBI2N5T9EJSGeyBz+whc X-Received: by 2002:a05:6402:5193:b0:43a:eaa8:74b2 with SMTP id q19-20020a056402519300b0043aeaa874b2mr41078648edd.111.1658187815138; Mon, 18 Jul 2022 16:43:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658187815; cv=none; d=google.com; s=arc-20160816; b=l0tSAiwwrR8eByvr57msZh191lIuV0KHWl7jiKCcBBqBKLf+eBkxjbw0/WNrxv9OsK 6llV82+kYUi91XlN+0/NHlipC62uzEb52t7kgTvLLBKPzZ9LDPY9U7tsyqUo1AyfjnH/ lvLRrwKX7FY22J9NL+TOgzMOzfEezUzFJIpaK4Ey1+YHknD5IyhaKJDX/3wny6cg8XkZ twTNrDH8/+XcIkGSpHhW/TldZqsXKydLOi4OLhNMTlB1IsFtyqUyVrLBjt51+du1Homg vU4N29LC5Ws7epvD8BEwzMr0o75PBk1ITAZbLQK9fYV+sTT2y5QcNe+Qw01SL9/iRtNu 5eTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=SxxNZtcVY0b8c3g8HahpgL2HEMB3NUWSQPhANcfFpcw=; b=AC6CtelmPisdvgWTzw3Z2LeEmho9WV/xXaewpxd4W8nvCjOt+6lpd8F628pQDZhxD0 dmDiBfVkVMncsNNsI85hvuqzeeq2pxIwJHtFB9xJJjMsvR0WgXCfCM3TjVqnWB2djPHm f6jf9Ze7sjG/QoJqEowzE7uJWf7Xy9c3pAV9bUtSuhRRYUnOL+0HoUP1Lr/6Vck+K+Dl VUxoCGcTE0AN/ftQUXK4Gugf9qS8BOBhl/dRb8pnsAIqd8MkfbR6qzJlm1RxQzcZ7Kih WZkjb56O9BFUPeUsc4vNUGm02RX+gnZHScfRPEffbWQOmzUe1nPxBMj1bq6at1TIPMd6 c5LQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qScpjRmb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f24-20020a056402329800b0043a897d1de2si17132181eda.128.2022.07.18.16.43.10; Mon, 18 Jul 2022 16:43:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qScpjRmb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236393AbiGRW7h (ORCPT + 99 others); Mon, 18 Jul 2022 18:59:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236291AbiGRW7Y (ORCPT ); Mon, 18 Jul 2022 18:59:24 -0400 Received: from mail-oa1-x34.google.com (mail-oa1-x34.google.com [IPv6:2001:4860:4864:20::34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82D55286C5 for ; Mon, 18 Jul 2022 15:59:23 -0700 (PDT) Received: by mail-oa1-x34.google.com with SMTP id 586e51a60fabf-10bd4812c29so27852452fac.11 for ; Mon, 18 Jul 2022 15:59:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SxxNZtcVY0b8c3g8HahpgL2HEMB3NUWSQPhANcfFpcw=; b=qScpjRmbKjILEK47SQVCEsWqBHMsmQf4XSp/wuZVwOsMjUVKZdEkrGbXnnuy1EERXk sMPMCbWDEOWxGcqU88TEWa+qxEDKsNPfuTMHcNXlBvjKQOiYPvG+qZqgnmaNB1Bgq9Bh KObNSdP235mb+8JgL9uU8PlOnMtbcppuB59vDaPWvCrcSdwo4xpuRPnE111wkKJD3spR krwTD3vVI3ZXvcbcyZIP/E3FMlmCs8eYUtW1ecKGOYoxDFM58AsADBbWLhqBjbRsI7DM HxEm79xV3zcUFoLqqP+YdgGjv4TUrki0UqB1FHeG58cVQ+/7b6TZX3W082eCJ24K5eo7 19wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SxxNZtcVY0b8c3g8HahpgL2HEMB3NUWSQPhANcfFpcw=; b=XTQc65ZzNjijzUQpw6SGdU3pDtcDOspb0acVq5G8mgP7bCEyTh02+UqLwoS4Blteoa WPfonk1eE1bKuS1tGHblRQ3V6eF4rYfKneMemUd4rQwgFFffRkPXA2eYZAvb9fyCmU4U yKROEHNJe6mWTyKwBCuKwtRncfME7PEVw2AcWe/I1N5DoQjl5ZsFzhJ7aRYjSkI+TfMs ojlxPaXJpyBfhmKGY4LviqQ7WFOcPyKZywlPUQzDqErbm4tpkgzWXbMAJl4fF+0W6bUS uYjzaJpJD14sIslSu37PTQnVAhoft2RbIXC1ytdHPkv4NzhQndhvOzhgwNNgH9pKa7Gx bwfg== X-Gm-Message-State: AJIora+Wp26b6kZ3O8gYWrySetCIRi4stz5yiZ8naTSmCuyZFPcl6MBX mgH5WZ/K0wOd7F5ve93yW5uP76E/H3iIjg== X-Received: by 2002:a05:6870:a110:b0:10c:2d87:9dad with SMTP id m16-20020a056870a11000b0010c2d879dadmr18379216oae.57.1658185162537; Mon, 18 Jul 2022 15:59:22 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id j10-20020a4a908a000000b0041ba304546csm5330931oog.1.2022.07.18.15.59.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Jul 2022 15:59:21 -0700 (PDT) From: Bjorn Andersson To: linux-kernel@vger.kernel.org, krzysztof.kozlowski@linaro.org, agross@kernel.org, mathieu.poirier@linaro.org, linux-remoteproc@vger.kernel.org, linux-arm-msm@vger.kernel.org Cc: sboyd@kernel.org Subject: Re: [PATCH v2 1/3] rpmsg: qcom: glink: replace strncpy() with strscpy_pad() Date: Mon, 18 Jul 2022 17:59:07 -0500 Message-Id: <165817634384.1905814.9434531838630907611.b4-ty@linaro.org> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220519073330.7187-1-krzysztof.kozlowski@linaro.org> References: <20220519073330.7187-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 19 May 2022 09:33:28 +0200, Krzysztof Kozlowski wrote: > The use of strncpy() is considered deprecated for NUL-terminated > strings[1]. Replace strncpy() with strscpy_pad(), to keep existing > pad-behavior of strncpy, similarly to commit 08de420a8014 ("rpmsg: > glink: Replace strncpy() with strscpy_pad()"). This fixes W=1 warning: > > In function ‘qcom_glink_rx_close’, > inlined from ‘qcom_glink_work’ at ../drivers/rpmsg/qcom_glink_native.c:1638:4: > drivers/rpmsg/qcom_glink_native.c:1549:17: warning: ‘strncpy’ specified bound 32 equals destination size [-Wstringop-truncation] > 1549 | strncpy(chinfo.name, channel->name, sizeof(chinfo.name)); > > [...] Applied, thanks! [1/3] rpmsg: qcom: glink: replace strncpy() with strscpy_pad() commit: 766279a8f85df32345dbda03b102ca1ee3d5ddea [2/3] rpmsg: qcom: glink: remove unused name commit: 6c3ebc96ffefbc48297d7c2fd266e9cb78e6941e [3/3] rpmsg: qcom: correct kerneldoc commit: 101042f4c0eb2daa331b4f7ce32c6d547114830a Best regards, -- Bjorn Andersson