Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <87pmi2ko2z.wl-kuninori.morimoto.gx@renesas.com>
From:   Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To:     Jiada Wang <jiwang_wang@mentor.com>
Cc:     <lgirdwood@gmail.com>, <broonie@kernel.org>, <perex@perex.cz>,
        <tiwai@suse.com>, <alsa-devel@alsa-project.org>,
        <linux-kernel@vger.kernel.org>, <jiada_wang@mentor.com>,
        <Dean_Jenkins@mentor.com>, <erosca@de.adit-jv.com>
Subject: Re: [PATCH v1 1/1] rsnd: ssiu: add missing .quit callback for gen2
In-Reply-To: <20220718110404.1529085-1-jiwang_wang@mentor.com>
References: <20220718110404.1529085-1-jiwang_wang@mentor.com>
User-Agent: Wanderlust/2.15.9 Emacs/26.3 Mule/6.0
Content-Type: text/plain; charset=US-ASCII
Date:   Mon, 18 Jul 2022 23:17:46 +0000
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PaHqKcN14zViK0BXgQZGXTyPnIAPLR8FEZRV7mcqpW+f/P8BqQQ1cKlGcDMa?=
 =?us-ascii?Q?80McDUT/j7+0EDxCka82cYa6iixQwSxYPII7uKGSlQ+HT5fKx7CRugCgW4yF?=
 =?us-ascii?Q?fursfpew1sS7pCqqmlKRMTAAoxWUedgNn9RZcJNXLIWaRXKVMVbb1T3Il4Kk?=
 =?us-ascii?Q?IQ3Pq1snixEwJRP4kqsI87K6K5aMWpwGyzpB6Nd5BBjNzSPkkkP/JTy5V8V4?=
 =?us-ascii?Q?J1MwbAJi2oVmI3SpjMbmM+0dQ1aJikjy2pLilMP1L+/scKqrRDLZz7ykiWDs?=
 =?us-ascii?Q?5KBMic0LFb8ZRhun9NhXRIRoxPhUJ+L0r/5p/Grx9/6kuveEII+PNagV7p5b?=
 =?us-ascii?Q?mHgjhAdfeExyepIIvoNxV7L6/YP/Dnn/L5TtBrVD5T8XFxqPClKO8GY/SiG5?=
 =?us-ascii?Q?un2yJPEMfdgppMcdWEeuaLkOqrHcTry9ucCUfg+gRgivpIcBsxMIPXxqks17?=
 =?us-ascii?Q?2d7HNXW9X/+Kfd2vleMWyUmN7JCV2QZ4sCopcbsR7vbLOY5vRoWDns/jZh6A?=
 =?us-ascii?Q?C7gQlL0vGZRwxc5NjIeeuSR3+UrQR/Py2dYHwzl/G6S+X/yTIW7517lTsvZu?=
 =?us-ascii?Q?2mqWUakfwawb7qn2mI46R5BxqMliCOXFWXW1jj75i6t350pTFjDI4NoARbq4?=
 =?us-ascii?Q?IUswBxgu2bIvvre5tqLurlnoXjUfPMFpA2UGS6El2xKZruoPYn7z2Jurtk52?=
 =?us-ascii?Q?rIsftw1tVoE9G9+j1st9UkeY88iRwrlDs573K+NCYuLdgEMwPfSzTlqzvKoy?=
 =?us-ascii?Q?ruKbjFZQwaPIFVlZh+tWld6XXYxl4vdKdVqIfSurWWypeP4gBX8hjx/J8t6C?=
 =?us-ascii?Q?eaeZVKtCfLbtWhraJhuqS2BnqfmPHJD9o9YI+F1L0msqWY98iMbjhD/yjYPq?=
 =?us-ascii?Q?uvkmvx5BUaK9keIL20O3kVkkGCG+DFKzYJTYfA1LiwPyu35m+eGsyYBW3G/4?=
 =?us-ascii?Q?oW/IuWahsy3RPZ/yoVKZCjVfe2+7DK8w42+tDrku6bZUSSW3+9/dBchePPyP?=
 =?us-ascii?Q?T3m3LXDQUeFgUjeZ8hfiJAer0+LDEHh8xcQhJjiHX9Tb4nOc4EGu/LHxmXCL?=
 =?us-ascii?Q?ouwncOeXvTDcFrhz5vJv5ndP37spnN5mSYLga8uqxYbRU1EHjM5BRCWrkpm2?=
 =?us-ascii?Q?HS4TKewoexPkqIU83tVfav0CNE4nogrjbA1rGMtxIKID4VY4VpsD/8duLFr4?=
 =?us-ascii?Q?fXY5dabKgM1ylDmR0nmW2ymRsmUOW2L8zqHwh5aCtV+a4TxTNaOCXKmfBGm9?=
 =?us-ascii?Q?rAZdwBzwBS8/+ZUBI9eYzbcHhiIcx5uadXHM9w64F7fo+pkNFBGJKeEOaDso?=
 =?us-ascii?Q?pwtjr+dcMa75NZ+acTQhEPv6Xp4PzEfC5OeEor+Lcx/ZDLqYaIkzghcgCK42?=
 =?us-ascii?Q?Il/vkNVzsLtqeZOGb8JIy6LM7WwVMWg+faZrlBJYF5VVEanp2UpI8dm50tWa?=
 =?us-ascii?Q?fe8rEQN9TovievKuBaQveN48DtwvrIFWHtN+XoeAcjdTBAVMo7HioZAg8plO?=
 =?us-ascii?Q?0nW7Evfgg4ClfDDRiEBOqLVe5cpf09fAXnPZv9FOQjZMbXPXYCTXEG/0bb63?=
 =?us-ascii?Q?9V53LqCJ0CVIdpnRQ6OMe92cWJUTrKNIih1XXnUNYy2hizTzNYKWtvFz3yX+?=
 =?us-ascii?Q?iWO9VZumlX6ndEsfEL91esA=3D?=
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aa9a74b5-902b-43a9-00d0-08da6913b98d
X-MS-Exchange-CrossTenant-AuthSource: OS3PR01MB8426.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 23:17:46.6073
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ua4rQo15dihcPbfpq89FJXUiJjPUsZUfV0neTpjk09XkunH5ZSZwiO/JTYEfAkFOVFV1R/5q5S6b63bGdt7wiAKkGBvNqAhmGkz4nMzF+S258gdKuSX+k9N/QTtHh7RQ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR01MB3788
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi

> From: Wang Jiada <jiada_wang@mentor.com>
> 
> commit 83b220cf8eb2a ("ASoC: rsnd: implement BUSIF related
> code in ssiu.c") moved BUSIF related code in ssiu.c
> which added .quit callback in ssiu.c to disable error irq
> when ssiu quits.
> 
> But .quit callback was added only for gen1 and is missing
> for gen2, this causes error irq is left enabled after ssiu
> quits on gen2.
> 
> This commit adds missing .quit callback for gen2
> 
> Signed-off-by: Wang Jiada <jiada_wang@mentor.com>
> Cc: Dean Jenkins <Dean_Jenkins@mentor.com>
> Cc: Eugeniu Rosca <erosca@de.adit-jv.com>
> ---

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Thank you for your help !!

Best regards
---
Kuninori Morimoto