Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 19 Jul 2022 08:49:30 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     "Yuan, Perry" <Perry.Yuan@amd.com>
Cc:     "rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
        "viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
        "Sharma, Deepak" <Deepak.Sharma@amd.com>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        "Fontenot, Nathan" <Nathan.Fontenot@amd.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Su, Jinzhou (Joe)" <Jinzhou.Su@amd.com>,
        "Huang, Shimmer" <Shimmer.Huang@amd.com>,
        "Du, Xiaojian" <Xiaojian.Du@amd.com>,
        "Meng, Li (Jassmine)" <Li.Meng@amd.com>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 05/13] cpufreq: amd-pstate: simplify cpudata pointer
 assignment
Message-ID: <YtX/mo8XmX+eODQF@amd.com>
References: <cover.1657876961.git.Perry.Yuan@amd.com>
 <e75b941f2c994d5b52cb42cd31eaf90d24efb73e.1657876961.git.Perry.Yuan@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e75b941f2c994d5b52cb42cd31eaf90d24efb73e.1657876961.git.Perry.Yuan@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?l1WUWJNN1l4m5mytLrpLwzGSczFtHDgJo8QybSRN/Z9GUnma3hE0A1WDxEP7?=
 =?us-ascii?Q?vyX78Qoec17UpwZx9TXocDwyu1TEB/HkUoiLUDjcnbSGAekkHb/DYH/qnece?=
 =?us-ascii?Q?AGFwmPqkt4uOOpD7FFJeTfktlsGZqwKpBRURkNuvm5vJREF0kqKEo+R0dm3r?=
 =?us-ascii?Q?DPkyIm7SveQpXjoQDQCEGNlk1o9fiHjnUbAoXBX3ul6Yc5B60fBdwtSAHxdx?=
 =?us-ascii?Q?wfkfZetyKCOr8bwdynLL1Rlg4tlqmJ9cRqa76SxqUxtN7r4f70OktshW9z+B?=
 =?us-ascii?Q?M0u4SDwH9DcGQI9Bs3Ilz8UUPwKGQ3BNiwtU+hDigRQqk2BGlt0BW+evu4rN?=
 =?us-ascii?Q?UqJgGaX14cl13HUaMQGZfonrxG6y5vzOM3vldfSgK4H7pze/B6bYIX8kXZ2B?=
 =?us-ascii?Q?sq5t9yVEjPAtmmVhrcohPdl3XUtFH7qqU5Sg6z4Yeb1UKrQZNNVpjmgBngjx?=
 =?us-ascii?Q?TcKa2AHwtF1JxTaCJY/DCPOKOJVE3BEgQx63KL7tF0EuCL6UYfbzgtF2slmP?=
 =?us-ascii?Q?qOfpjuRk91qbJecj99lz6+oMs7Folw7E081/MWGGKFCanoqbwwJ5yYNn+WMj?=
 =?us-ascii?Q?4I3+AlL4+3EJTyGw44wTIT5TpBfFQ0q1y35Z3OhUASxlXLaIh5nop14tAgH0?=
 =?us-ascii?Q?UOssK7zkncAAZbsbGNN0k1p+J3nPvOqy2wYpPM3m+k/q2nsIvU2mbboCnf71?=
 =?us-ascii?Q?Mei7scY4fTr1wf2apHAkkDEfr3b4xKFXwJW8bP4YEARoQgBHJFOEEaVd/aH1?=
 =?us-ascii?Q?thx7MbE31MCwA/BsAclBQRasL8JCFjES7+14NqqdH21fwgtSdjpS9l5h/mlu?=
 =?us-ascii?Q?oj5ri/sAvF6xqNWcukiWBC1SaBC/pfFi3VN+pqFoaRf7MBjuRE2nZtUFsC4E?=
 =?us-ascii?Q?vKKS++NEkFl1iS5Tk5HHPsu5pOJWi7+cj0KfsZ9YWqGBJw0IwIuYZmXZ0HDv?=
 =?us-ascii?Q?s9awzXyWpUahivZ37fjBN9pAT3FqWSEENpCChDXskaK1Zmpt3OMrFO+LUSEg?=
 =?us-ascii?Q?tA4pCAFUFjDwcVufueR+pcn60XW8zUWLABsyheSpKeMHSww2IgOkPiVnyXDo?=
 =?us-ascii?Q?szsUhXR9NmrJoqZHfmt5GOFaRiwZs8FHpSeoQ2VUVj/JJbvU7SyZTsWHhDTo?=
 =?us-ascii?Q?hF2eiAlXI/8wQGpdO1B4M3ejTpgKl7mRFRmWHa7pw8PHV1RQpYU5WzNtf57C?=
 =?us-ascii?Q?YwHvdUTztZheSMIAVshFhNYOoM5Soua4lZjRY80Aw/nX9Bqk+xx/r0Hu3ADg?=
 =?us-ascii?Q?gd8eEessiYrYYQDnyOYWC++ahHYDtAve7L+f4XWTCvJk2ibq/hrEwHITp87f?=
 =?us-ascii?Q?ncoXT+jLF6rAwSSgWlvZCyO7599/26uI6dEAeEle47Byviuh44z9f7sAc+3F?=
 =?us-ascii?Q?88QGD6PmdIn/rjbFhRgE9o8Ue2dyvsv+pySLtCAAwmsU5nnTGWVnRVHNpNd3?=
 =?us-ascii?Q?haZ6V0oZuXVcELBjksmlNIOOQH8c0XKgaE7hptgcnllJ5l4WryqNIzE8wZqf?=
 =?us-ascii?Q?u0nN06AY/jgBu25LbQX7g4YXlWd1lNNDha4Xeegn0FHh9N02QL3Ja6xyH2n+?=
 =?us-ascii?Q?F1LRKQUiK/hTDeSbI64hUY2bKYochuhhowPPFaTn?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b6fce565-d659-453b-faaf-08da692097fd
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 00:49:53.7158
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NHxtnMdIzQ9eIS24h7EjWLY0YghhVvsTKO5plPtG6UHhRFBU/EiubfPnrM8o58GL4ou6AlV/h7osmxWpDEpIxQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3314
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 15, 2022 at 06:04:24PM +0800, Yuan, Perry wrote:
> move the cpudata assignment to cpudata declaration which
> will simplify the functions.
> 
> No functional change intended.
> 
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>

Reviewed-by: Huang Rui <ray.huang@amd.com>

> ---
>  drivers/cpufreq/amd-pstate.c | 12 +++---------
>  1 file changed, 3 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index d8c4153dbe4f..0c8256638ed7 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -574,9 +574,7 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy)
>  
>  static int amd_pstate_cpu_exit(struct cpufreq_policy *policy)
>  {
> -	struct amd_cpudata *cpudata;
> -
> -	cpudata = policy->driver_data;
> +	struct amd_cpudata *cpudata = policy->driver_data;
>  
>  	freq_qos_remove_request(&cpudata->req[1]);
>  	freq_qos_remove_request(&cpudata->req[0]);
> @@ -618,9 +616,7 @@ static ssize_t show_amd_pstate_max_freq(struct cpufreq_policy *policy,
>  					char *buf)
>  {
>  	int max_freq;
> -	struct amd_cpudata *cpudata;
> -
> -	cpudata = policy->driver_data;
> +	struct amd_cpudata *cpudata = policy->driver_data;
>  
>  	max_freq = amd_get_max_freq(cpudata);
>  	if (max_freq < 0)
> @@ -633,9 +629,7 @@ static ssize_t show_amd_pstate_lowest_nonlinear_freq(struct cpufreq_policy *poli
>  						     char *buf)
>  {
>  	int freq;
> -	struct amd_cpudata *cpudata;
> -
> -	cpudata = policy->driver_data;
> +	struct amd_cpudata *cpudata = policy->driver_data;
>  
>  	freq = amd_get_lowest_nonlinear_freq(cpudata);
>  	if (freq < 0)
> -- 
> 2.32.0
>