Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4063f7c1933c02f3681832f522a41e1bb5229f41.camel@intel.com>
Subject: Re: [PATCH v3 2/4] thermal/core: Avoid calling ->get_trip_temp()
 unnecessarily
From:   Zhang Rui <rui.zhang@intel.com>
To:     Daniel Lezcano <daniel.lezcano@linaro.org>, rafael@kernel.org
Cc:     quic_manafm@quicinc.com, amitk@kernel.org, lukasz.luba@arm.com,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Tue, 19 Jul 2022 09:01:03 +0800
In-Reply-To: <70a992e3-bf1c-0c33-c122-3c4730ffb232@linaro.org>
References: <20220715210911.714479-1-daniel.lezcano@linaro.org>
         <20220715210911.714479-2-daniel.lezcano@linaro.org>
         <aeb6a9d2447a8bbd7d386f88a7f72b33253776c7.camel@intel.com>
         <70a992e3-bf1c-0c33-c122-3c4730ffb232@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.1-0ubuntu1 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2022-07-18 at 16:04 +0200, Daniel Lezcano wrote:
> On 18/07/2022 06:59, Zhang Rui wrote:
> > On Fri, 2022-07-15 at 23:09 +0200, Daniel Lezcano wrote:
> > > As the trip temperature is already available when calling the
> > > function
> > > handle_critical_trips(), pass it as a parameter instead of having
> > > this
> > > function calling the ops again to retrieve the same data.
> > >=20
> > > Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
> > > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> > > ---
> > > =C2=A0=C2=A0 v3:
> > > =C2=A0=C2=A0=C2=A0 - Massaged the patch title and the description
> > > ---
> > > =C2=A0=C2=A0drivers/thermal/thermal_core.c | 8 ++------
> > > =C2=A0=C2=A01 file changed, 2 insertions(+), 6 deletions(-)
> > >=20
> > > diff --git a/drivers/thermal/thermal_core.c
> > > b/drivers/thermal/thermal_core.c
> > > index d9f771b15ed8..f66036b3daae 100644
> > > --- a/drivers/thermal/thermal_core.c
> > > +++ b/drivers/thermal/thermal_core.c
> > > @@ -340,12 +340,8 @@ void thermal_zone_device_critical(struct
> > > thermal_zone_device *tz)
> > > =C2=A0=C2=A0EXPORT_SYMBOL(thermal_zone_device_critical);
> > > =C2=A0=20
> > > =C2=A0=C2=A0static void handle_critical_trips(struct thermal_zone_dev=
ice
> > > *tz,
> > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int trip, enum
> > > thermal_trip_type
> > > trip_type)
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int trip, int trip_temp=
, enum
> > > thermal_trip_type trip_type)
> >=20
> > This indent cleanup belongs to patch 1/4.
>=20
> It is not an indent cleanup, the 'int trip_temp' is added in the
> parameters.

Sorry, I meant the indent cleanup in Patch 3/4 can be moved to 2/4.

thanks,
rui
>=20
> > Other than that,
> >=20
> > Reviewed-by: Zhang Rui <rui.zhang@intel.com>
>=20
> [ ... ]
>=20
>=20