Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 19 Jul 2022 09:04:59 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     "Yuan, Perry" <Perry.Yuan@amd.com>
Cc:     "rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
        "viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
        "Sharma, Deepak" <Deepak.Sharma@amd.com>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        "Fontenot, Nathan" <Nathan.Fontenot@amd.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Su, Jinzhou (Joe)" <Jinzhou.Su@amd.com>,
        "Huang, Shimmer" <Shimmer.Huang@amd.com>,
        "Du, Xiaojian" <Xiaojian.Du@amd.com>,
        "Meng, Li (Jassmine)" <Li.Meng@amd.com>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 11/13] cpufreq: amd_pstate: update transition delay
 time to 1ms
Message-ID: <YtYDO+tXShYLKh2B@amd.com>
References: <cover.1657876961.git.Perry.Yuan@amd.com>
 <c1b46c68d521ff2c8ed49a6e8f5ad75ce51fb772.1657876961.git.Perry.Yuan@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c1b46c68d521ff2c8ed49a6e8f5ad75ce51fb772.1657876961.git.Perry.Yuan@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/jImK9ohTeGFPniV0+nIOQ9jxmlgKiPcxHyjSwriMeD1agvLEKrGNfU3Pem6?=
 =?us-ascii?Q?EZF8xbfd8VVI2lfl8IIqUJZY3y6vvAeloZAQuU7GT3KXa/z7tawLcXhIGB0i?=
 =?us-ascii?Q?jkBiAYRHtWf21iic8APfTTFqwx0zAeDxkbiEd/BUeqTE2U8Dn0JgfbjIzvrT?=
 =?us-ascii?Q?A2+lTguEEqnOl9OMyf99ekOLcwo0Njy5n4LYVfh/xZ/BBGXJWOtePoZofeol?=
 =?us-ascii?Q?3dTeDVVpgvmElQaZYVtEGQcybv6m6lwVhOtXrZuIHX9wQAZ4LZzKnIGu/DHJ?=
 =?us-ascii?Q?xAgLR6RxvhZRsyh9B0msd0HQlamxj0a2XP8WA3PvPA0RLvoSXefOmnhiDtG1?=
 =?us-ascii?Q?9BYe7rSa4Vbiu6FYnwz2s2aGwJPHzFOt5fvDSHoavIKzHAf4Kz3MQuDFLlGK?=
 =?us-ascii?Q?vCPs00JEHMkH60FZHjr54b1eMkyv1Mrxli3KabkNWZIzn48uWpcYLXDu2kJ7?=
 =?us-ascii?Q?oKCI4K6yn7+zuzdLGgoC0MZJrcOID4emT+qR0L5xeNvf2ovwGHOY2KNMFPAZ?=
 =?us-ascii?Q?2OIkSL2ztGnJWxAaqLr5dstwbjoV4qjvqduUSGm2+UjVQhwn1sFarAgHZULe?=
 =?us-ascii?Q?nfT43LDgu2d1nF42CaRqwrSQZ0sD9V5kybwswTEQ9DFE4mcyIO1PzaUxGKTe?=
 =?us-ascii?Q?dvOK+SCqYSfAEfO3xouF1QeHx6FM0RL+HZEqpnclLwzS1EMg7JP7nYAprsHy?=
 =?us-ascii?Q?7ONyCT0xgDm8Npnm7XNdqVq9zwvU92gujgwFTShhqlLiMETqgoN7pGKfuRoB?=
 =?us-ascii?Q?52FRmvNi+M0xQpJmkC/8aJcm7ywkFBGYY0viWJzV7NKDgcttdKzplDn/pJJe?=
 =?us-ascii?Q?9PqvZzQmXyewDjp28kDhMS4jZ2gc5tu2iFBu8g9/HXoEA7bq9w60J3RfuvM8?=
 =?us-ascii?Q?9VGIWYTpZDzkGNH80RFujq3tXqPQVX81htc4+EV8coU1IsQ3Gin6PE+5HHOR?=
 =?us-ascii?Q?N5ROCA5S7gVloVUn463Ekf6m01zVavP2iJSanjBCr+LeEKKLyg76nPxlX+sd?=
 =?us-ascii?Q?iKM/vMJR3cGzg/KWisJ7aObsZiTvAQ4LVVlBLbREbYGNadQSFUcirngcQdPY?=
 =?us-ascii?Q?HENSp9HvNxq68QhOs1b7IT8ijhCBaIagQD4QNB3It4u6aVOGNQRE4SMm/QeI?=
 =?us-ascii?Q?Amz2PgxySclqeIqXDcKlbHa2+d0vyWJwJQ4H596VolpelrFc62JuXurkNzG3?=
 =?us-ascii?Q?2ncQgrPX5ROvyqM3kPZcV3Juquqh+/eP/IColAhszed4gRA7ITOB6KXHOOQ9?=
 =?us-ascii?Q?p0YJsdFWvTO7y+wBeywSwOg+E36292bL/w1el/LonzbTKMLNDyU0KOinrxbt?=
 =?us-ascii?Q?xaAg//fM5PuPG3qJAQddJpSMcQgeBO9yRYzjrEdkuGCviddPEpc/RG0zCtWx?=
 =?us-ascii?Q?INgiTL9KcmAJGJZ7MQF7Yvh0nFJlTblA11A05Khlh1ZYxa9byxUOjAmbyQrZ?=
 =?us-ascii?Q?u+SK8b3hdi45zCwsUpR+OmM5A12uTAxiC5Bd8A8BDmCBLSU+OGVnLqm2VYgE?=
 =?us-ascii?Q?+eC2XeCFzy8xdFSPBxba47NN1TicaIt7jooZKB7PgfLXhRB0n4iZacmCrCFJ?=
 =?us-ascii?Q?5G9XBy4E+RitOzfGAn7gdAAB45wfy9FbAmO5gcw2?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b9315b68-e2e8-4e9d-cd43-08da6922c1f9
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 01:05:23.1618
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Uaz9naOviaG9TcOg5r40Ei6Nnd7vuiJ+YEQQ4CYemmVEMfOaWK7i1Onf6NUcdbFiBoYeip20LWjD+jegXuTrsA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB2850
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 15, 2022 at 06:04:30PM +0800, Yuan, Perry wrote:
> Update transition delay time to 1ms, in the AMD CPU autonomous mode and
> non-autonomous mode, CPPC firmware will decide frequency at 1ms timescale
> based on the workload utilization.
> 
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
> Signed-off-by: Su Jinzhou <Jinzhou.Su@amd.com>

Please squeeze this patch into patch 9. I don't really want to separate the
transition marco update as two patches.

Thanks,
Ray

> ---
>  drivers/cpufreq/amd-pstate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 4f8600a36194..d3bc441b3923 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -42,7 +42,7 @@
>  #include "amd-pstate-trace.h"
>  
>  #define AMD_PSTATE_TRANSITION_LATENCY	20000
> -#define AMD_PSTATE_TRANSITION_DELAY	500
> +#define AMD_PSTATE_TRANSITION_DELAY	1000
>  
>  /*
>   * TODO: We need more time to fine tune processors with shared memory solution
> -- 
> 2.32.0
>