Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 19 Jul 2022 08:50:45 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     "Yuan, Perry" <Perry.Yuan@amd.com>
Cc:     "rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
        "viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
        "Sharma, Deepak" <Deepak.Sharma@amd.com>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        "Fontenot, Nathan" <Nathan.Fontenot@amd.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Su, Jinzhou (Joe)" <Jinzhou.Su@amd.com>,
        "Huang, Shimmer" <Shimmer.Huang@amd.com>,
        "Du, Xiaojian" <Xiaojian.Du@amd.com>,
        "Meng, Li (Jassmine)" <Li.Meng@amd.com>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 06/13] cpufreq: amd_pstate: fix wrong lowest perf fetch
Message-ID: <YtX/5YOaad1M5kFR@amd.com>
References: <cover.1657876961.git.Perry.Yuan@amd.com>
 <7091e6ddb8605bdd870bad3273b03eea67354bdc.1657876961.git.Perry.Yuan@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7091e6ddb8605bdd870bad3273b03eea67354bdc.1657876961.git.Perry.Yuan@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iHqTzkheVAOJQGjSm8zMULb4UEQd16zAvD8+Jcm4DSAmmp/G24XkFvXIhWs5?=
 =?us-ascii?Q?5Yzs3JPpLJct59Xc/AgQtn+E0zgG5s5AWjJzVoIkO4lT3t8u6/j74qGisd+f?=
 =?us-ascii?Q?cRZP7yZ6U+yC7lpTN/Kt517J5sx1VDjrh4j2mDWqSikpRDuFdQgO0hJg2yE2?=
 =?us-ascii?Q?KwLQ0nOTyd6tx4JzK7vW6n15P91lAwRErGTQ3beIMABzWotpChkOf/Sr+btO?=
 =?us-ascii?Q?P10XvyX2NZgEjUZC4xQ6TaLTGPvGWC65fv+WEdSYME+vbTzAfeQyB8W7c5m1?=
 =?us-ascii?Q?9WEThw9M7uT1g/wGLZKTa+F8Scgf6w0uNb+0FeRV3cpaJe4nS558sTtq2XH2?=
 =?us-ascii?Q?K4ILvEAQjex1+mO406vjh7v7bE1vpqnRrtdB6gE3J07SYuFRv6HIjP7sGpLk?=
 =?us-ascii?Q?znw+AzaqYxvNQRjuTkQ0L7AoNKauxAtkrSgiL2dwojuT2UKBoTdaRsOJx0jA?=
 =?us-ascii?Q?nAIQ4Ob2Mg7pn9pwuVtOuNw7JApmIaAGCv+H79Mo6EvMOYY6uUfX6V3+h1nF?=
 =?us-ascii?Q?OFLf9ShZ01iHHj0AmlTytJqB6xiT/fbNt2ziBQYJz5UhjFo+kCxD0pJgc8uj?=
 =?us-ascii?Q?AiHtifGEtjqERoKAMirkBuPxOVh2OfHGb2Cd7M5nLnmPpxsAgRvGbDT6+giV?=
 =?us-ascii?Q?GUXxsIOOUkSODaLUIX+UND1YRg4eYUn8+myVW4D8AwzBVSKLgtU708+yQrVQ?=
 =?us-ascii?Q?rO9vqTRD8jReQDoFho7HBOVCyBvtTi8WtDt+OAmETsTm7LDEOq5Tjobeq2Pg?=
 =?us-ascii?Q?q0SvYRdtoQ9YcWWcL9lGuV1d5sZEBvGa9rhEaNRtd9xR0ezlydEFjyxWG+cv?=
 =?us-ascii?Q?1FX1ty77FfC+OmmBqMn6Tvs5K44qszsyFjhWNuBtEA4aKsNbmjmC0RYSr34i?=
 =?us-ascii?Q?YDlMAr7ahxfitHtyQTGZtTce9YTGxAr3UT5Mc9a53whjeJT56FVyRjvkJ84z?=
 =?us-ascii?Q?YUOeWCBON/8kalEAKE4VyKtCrKK/yp3NZ80EhPworfMaPi6MDHQKGQZkxN3X?=
 =?us-ascii?Q?LL1QfwUk/ZbdDCYDVbwEcc0MiRo5OVuZvPoaw7vgg4uyqU0yPLVdz7c4f4p+?=
 =?us-ascii?Q?PryZWVjzQ/+/Ed2rRDweoRqrjzI9nzjRD0p7iuAgZV1UUBRgED2T/Wxum6KW?=
 =?us-ascii?Q?t963bauFzojPYdkdlzkB3943AE9PNqg6Ltc8HJNRDM13uT6+jwfcuYkMSKro?=
 =?us-ascii?Q?P3y48snxOPVNzCZ/14kxshNXk+uCnZ2ap0F/dZb5Fs/J8hLKDrWkiBR5+4Ej?=
 =?us-ascii?Q?nvND/yjILekSUhM7wBfeIp+pJcRFKevkKExwm6Ajj/hcU4DmTBId1Jab1MIT?=
 =?us-ascii?Q?Domx8Zdq58PTkgr3lVjUSPoTTXhXJi2j8ljD8FXFtwm7VAymteQSOw2+WcKy?=
 =?us-ascii?Q?xgG6rtBvtKTAmgbmcfnCqWDeQdrxFG8yYY4Pn7a6ne7q/nUv3spjg/x8r5FJ?=
 =?us-ascii?Q?uRgm3jROyAy7RJ4CTynAMNHAMDW57LSg8L0g4199nk+jINaWnqwUI/i/Wgkb?=
 =?us-ascii?Q?8PRU+/ownjFJ7PJ+64Ri+7IXMllB2JvVC+7mC3HAZ9sMNL9B1f+4WzkEcNxi?=
 =?us-ascii?Q?tqdIVQ9MBcJntuL16uRsKYERbBIjbh7fLtNO2wG4?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9545e9dc-f450-4321-4174-08da6920c4aa
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 00:51:08.6802
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jyWEqa/hDLE333gd1gyk6tYwHRhxgL3dK+Eg4bHu2toNiF7KATU1OtOO9GcYTemiZnrAwDsIgidYJVireK1cIw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3314
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 15, 2022 at 06:04:25PM +0800, Yuan, Perry wrote:
> Fix the wrong lowest perf value reading which is used for new
> des_perf calculation by governor requested, the incorrect min_perf will
> get incorrect des_perf to be set , that will cause the system frequency
> changing unexpectedly.
> 
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
> Signed-off-by: Su Jinzhou <jinzhou.su@amd.com>

Reviewed-by: Huang Rui <ray.huang@amd.com>

> ---
>  drivers/cpufreq/amd-pstate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 0c8256638ed7..4b764870035e 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -311,7 +311,7 @@ static int amd_pstate_target(struct cpufreq_policy *policy,
>  		return -ENODEV;
>  
>  	cap_perf = READ_ONCE(cpudata->highest_perf);
> -	min_perf = READ_ONCE(cpudata->lowest_nonlinear_perf);
> +	min_perf = READ_ONCE(cpudata->lowest_perf);
>  	max_perf = cap_perf;
>  
>  	freqs.old = policy->cur;
> -- 
> 2.32.0
>