Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 19 Jul 2022 09:07:53 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     "Yuan, Perry" <Perry.Yuan@amd.com>
Cc:     "rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
        "viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
        "Sharma, Deepak" <Deepak.Sharma@amd.com>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        "Fontenot, Nathan" <Nathan.Fontenot@amd.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Su, Jinzhou (Joe)" <Jinzhou.Su@amd.com>,
        "Huang, Shimmer" <Shimmer.Huang@amd.com>,
        "Du, Xiaojian" <Xiaojian.Du@amd.com>,
        "Meng, Li (Jassmine)" <Li.Meng@amd.com>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 13/13] cpufreq: CPPC: remove the acpi_disabled check
Message-ID: <YtYD6bRaFxby2KBW@amd.com>
References: <cover.1657876961.git.Perry.Yuan@amd.com>
 <da43e5feeb246c02ba4ce6ffb5fbd35fe7bd9f14.1657876961.git.Perry.Yuan@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <da43e5feeb246c02ba4ce6ffb5fbd35fe7bd9f14.1657876961.git.Perry.Yuan@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iTIqHZ6DJAMwP4EI6siyU88qHLpppXj03TCmg/tflKBAoJYc1s7xR2L4AhWR?=
 =?us-ascii?Q?+oFVjs/UehfROfYEPgTs47fLFGR4yn1F6xiZSKDTVIokIy+rDpUL+ePQYX7N?=
 =?us-ascii?Q?djF82sT9WRWYjLSt/IrH0/f/OJyiN0M5HRtkPQPxMmM212n+VyJ9RNDHiPAf?=
 =?us-ascii?Q?43dUc60Xesb99HEIsRc6crhVCLcM6ru89j17vOAzt5POKPwbdGUq7Zz1PR9D?=
 =?us-ascii?Q?0R8TG70YBwlraMLDQwcpTKgo0s+lJy83vG1p26ymE3bce7EcuLQQWNc806AU?=
 =?us-ascii?Q?XiTA7boc5zw6YBecwlILfMTecK439m7hQLBmC2L9TPA0PAE2NwJs7tmOfgnU?=
 =?us-ascii?Q?3Snse93Qfb18suPquK+ePXLsGgv2mRh9LNJGMd317B9pRr2cX8V2G3bCcs6Q?=
 =?us-ascii?Q?oTft+F0TBAlykU0WehBzVsvDkmdyQCexO2KMHn/QujiiwozAzZsXXG00aJt+?=
 =?us-ascii?Q?C9MeDhhIzbO1jyBqJXGyGadrTjIY0cCznc0R8BnOXoHKPS0dvc08slJjhwNz?=
 =?us-ascii?Q?cLLQVzTdew59ykQVzAbdVpcaWJ7aOs7thPk2bvtLi9W3/E2rgZWMyRbxFK6F?=
 =?us-ascii?Q?gKw6orYku4qx8wtDcS0SGdXQXKNr5iis3ogzwxAsrS8l5W0gsXEe3kW7w7AE?=
 =?us-ascii?Q?SJecsiH1JLqPvrjkU2t9wPwpcDtDcCxGX2j2mGKXDgSncGOt7+7Q0JruNhlh?=
 =?us-ascii?Q?ATLILKaLaJ2bOQHLlTSVH+U6a7VBvLOsQZFVHokLWzAM2BXKjZYXCshUS6iR?=
 =?us-ascii?Q?QDJTNdApVUi05IqBOn2L619N0y3iPgPgyNwzQtDjC2rRYFsAALOXekm74x6W?=
 =?us-ascii?Q?4CCLL/WRj6tYAth1ljclhtzFe7Xefh3/xtR7OrqFymR4Fwlunit++yLwLLeg?=
 =?us-ascii?Q?Y3XaEbuUyTwX5Rqnrm8GDSGSeNDlIyS7aW/QlCOkp7P3eubPZHvVekr0esq0?=
 =?us-ascii?Q?irlf34OF/qebcH77dKiYccPlXziMa89y0FmnSYYgR1pbPRVSIMptzsmDpUWU?=
 =?us-ascii?Q?ufVpv+5ZkUcG2Q48srrU56u7+gPoTBusvxQUjGF9/G8dchNnEbLTOnJR4CTe?=
 =?us-ascii?Q?P1HC9YY9jT7QKaCvRD+vatuWf7nLtJSoTjWisySKM+yydWf0amK2oDflZ/8s?=
 =?us-ascii?Q?BTJfdQOe6fOVGmvpOiFRvoO5eb9u8uVY4rvNbzadcFu2Ql1ym0GRh374yCK+?=
 =?us-ascii?Q?oqk+qoUlk+HCH1y/SC9jzEw814DWh3yVa7PizTz0rptU60alRzPrHIqvWK9o?=
 =?us-ascii?Q?bWlGSzVdY1JHy8D+ClPdAF0vMdWu0bHExsXwp0LfkYcZjNEY0z42TqMNDUMG?=
 =?us-ascii?Q?pPwcGIDeW44wPAunNjsyfZlg5eLja00wnyMYwW2Z8iq8blxg2HyDxkXlRZi1?=
 =?us-ascii?Q?0UeT5B0GiiWS403idQ5m6lksQ28iXYbdZVjm35TKJ2mYdC44kk7B2XQAZxkj?=
 =?us-ascii?Q?m1kNxo+5aZR36s3tNuTbLAQBTvFRyD+lytQpnNjPVBWRDCP0YCq+ec2AuBKf?=
 =?us-ascii?Q?KE7bffoojM8Mxurk3zYai50wZABw7fmZwjCfTIupB15CRS65+0oU4tkSGlrg?=
 =?us-ascii?Q?S74pxnTJu7GKjwLQc9byGFHajls+4NQ7wvDOkie+?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cc1db5e5-d15c-41e5-53ef-08da692329b3
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 01:08:17.1830
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wihGuIleXO+05eo2PuYBWRgdUTbbT0vjF0Nae0M4FnlmX13LHjLpTvU9Fn9yRn6opRbiekCw+ILzMBxx1eHZoA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1201MB0253
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 15, 2022 at 06:04:32PM +0800, Yuan, Perry wrote:
> "acpi_cpc_valid" function already includes the acpi_disabled check and we can
> remove the duplicated check here
> 
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>

Patch 10, 12, and 13 should be one function update to move the
acpi_disabled check into acpi_cpc_valid(), should we squeeze them as one
patch?

Thanks,
Ray

> ---
>  drivers/cpufreq/cppc_cpufreq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
> index 24eaf0ec344d..9adb7612993e 100644
> --- a/drivers/cpufreq/cppc_cpufreq.c
> +++ b/drivers/cpufreq/cppc_cpufreq.c
> @@ -947,7 +947,7 @@ static int __init cppc_cpufreq_init(void)
>  {
>  	int ret;
>  
> -	if ((acpi_disabled) || !acpi_cpc_valid())
> +	if (!acpi_cpc_valid())
>  		return -ENODEV;
>  
>  	cppc_check_hisi_workaround();
> -- 
> 2.32.0
>