Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 18 Jul 2022 19:01:17 -0700
From:   "Darrick J. Wong" <djwong@kernel.org>
To:     sunliming <sunliming@kylinos.cn>
Cc:     hch@lst.de, dchinner@redhat.com, linux-xfs@vger.kernel.org,
        linux-kernel@vger.kernel.org, kelulanainsley@gmail.com,
        kernel test robot <lkp@intel.com>
Subject: Re: [PATCH RESEND] xfs: fix for variable set but not used warning
Message-ID: <YtYQbQ48Evn62pgb@magnolia>
References: <20220719015442.646442-1-sunliming@kylinos.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220719015442.646442-1-sunliming@kylinos.cn>
Precedence: bulk

On Tue, Jul 19, 2022 at 09:54:42AM +0800, sunliming wrote:
> Fix below kernel warning:
> 
> fs/xfs/scrub/repair.c:539:19: warning: variable 'agno' set but not used [-Wunused-but-set-variable]
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: sunliming <sunliming@kylinos.cn>
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>

Ah, right, I did forget to push it in last week's batch, sorry about
that.  It'll be in Thursday's posting, thank you for the reminder.

--D

> ---
>  fs/xfs/scrub/repair.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/fs/xfs/scrub/repair.c b/fs/xfs/scrub/repair.c
> index a02ec8fbc8ac..032de115e373 100644
> --- a/fs/xfs/scrub/repair.c
> +++ b/fs/xfs/scrub/repair.c
> @@ -533,14 +533,12 @@ xrep_reap_block(
>  {
>  	struct xfs_btree_cur		*cur;
>  	struct xfs_buf			*agf_bp = NULL;
> -	xfs_agnumber_t			agno;
>  	xfs_agblock_t			agbno;
>  	bool				has_other_rmap;
>  	int				error;
>  
> -	agno = XFS_FSB_TO_AGNO(sc->mp, fsbno);
>  	agbno = XFS_FSB_TO_AGBNO(sc->mp, fsbno);
> -	ASSERT(agno == sc->sa.pag->pag_agno);
> +	ASSERT(XFS_FSB_TO_AGNO(sc->mp, fsbno) == sc->sa.pag->pag_agno);
>  
>  	/*
>  	 * If we are repairing per-inode metadata, we need to read in the AGF
> -- 
> 2.25.1
>