Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Justin Stitt <justinstitt@google.com>
Cc:     linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
        llvm@lists.linux.dev, martin.petersen@oracle.com,
        mgurtovoy@nvidia.com, michael.christie@oracle.com,
        mingzhe.zou@easystack.cn, nathan@kernel.org,
        ndesaulniers@google.com, target-devel@vger.kernel.org,
        trix@redhat.com
Subject: Re: [PATCH v2] target: iscsi: fix clang -Wformat warnings
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq14jzdq01g.fsf@ca-mkp.ca.oracle.com>
References: <20220708211447.135209-1-justinstitt@google.com>
        <20220718180421.49697-1-justinstitt@google.com>
Date:   Mon, 18 Jul 2022 23:00:38 -0400
In-Reply-To: <20220718180421.49697-1-justinstitt@google.com> (Justin Stitt's
        message of "Mon, 18 Jul 2022 11:04:21 -0700")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WcCu5KBVBNi2yeAYbbHF9UMZs1M8U6/aIU6HGYI4qFOY1tjhNahf3+VpsKS1?=
 =?us-ascii?Q?FD0zXNKL7tE/yFGjv279GgRnL+UOQuWjb9+oMPctzbe+YeRdH1XYnnd51PdD?=
 =?us-ascii?Q?bEmBBH9LjrOUUIbj8PUEj2IwOucdZh/Y6sYkfpT2BKwnUhxk5ZGXx/v2VRMw?=
 =?us-ascii?Q?tqxCmR/mFjZdzpf8i2gm8jdXFKTzBpBS+zS/8IFjnQLuIA7h8iN8L8Flzhq9?=
 =?us-ascii?Q?utrzDm/+k+1Pa/JRLIXG/tveEP72TSpZ338lOsSK1nz1kSpUfjd8J66/o6wj?=
 =?us-ascii?Q?1oEvEIBNqFJdJwjofVdvS93oSf47hvCBUL9ElBqpqlOd1AhdtubOAVXuLUHW?=
 =?us-ascii?Q?NGCRys8T4IfBdequl+9ZbBd6rD5ScdjO3L3zT10qp9O1weC8fSmwPdq7wb8v?=
 =?us-ascii?Q?W/WiUoanNrh2Bq1JOSZpNtqC30wSyDTpJ/Z7AIPZ6bhar3DQk55Bq+7nENlP?=
 =?us-ascii?Q?7mRk7bsu4BqEr4kfeov9MV3lNtjKMH5EadH5CLuq3I2GODpVl6QOrkf9CThb?=
 =?us-ascii?Q?kH/mq9wBQUVp2BCHC0Mya6PMnkhmsyATrz+vMDR0vW2dfGtoD78wJOZChLkl?=
 =?us-ascii?Q?U+P3VCfYPScXK1MkzUMfuc6a9+QSh56ZX4SEnd+I2Tm/LaUz1K+YwDRbhcWI?=
 =?us-ascii?Q?4BugMDyLpPki7lPAMHKdZbRAmkYzb6+dvFZnXQnm64b/trr5i1EC4ET+rx1b?=
 =?us-ascii?Q?sCklCh2hnk00lHItF166qC8TFHUQb6uaX1D0ZDqvRfnODhfEQ75PgwBDV5lM?=
 =?us-ascii?Q?jpuQP0m9+NJpBc9s+a3fCiyofih4FF5Z54u3vx6Qm9QdiEzut2UDcHIjxYHq?=
 =?us-ascii?Q?/bg9zAAV+yzTniRh/7k7OTg4nlKhjEjPtVAyUOyBpKAjOer/KCpqHG1e1/SV?=
 =?us-ascii?Q?23h356kk37qhEY1tYV/rij7mezu/NFWs2hrHaCL+1SAc0+2WdVNfjTFO1Xki?=
 =?us-ascii?Q?y6aMhW7ILnwcJJI+yabpUYtCEwxzSlWrMDBCk6DpI7dK9snF5XOgoA9ym+v8?=
 =?us-ascii?Q?OW/aHMSLRsiCVK2UolQv9JsZnqw37Ye/I0AqummWf4wBAPkDUrO5jRREmsrT?=
 =?us-ascii?Q?o2zpgbBvmcvg9xHGalaIlV5BoyCD6PeuGf7A5/2bJZG71vi+W53D0jzPS9t1?=
 =?us-ascii?Q?/jQYnBMjXUGWdjRQVWjdIHb89Z5gw5CjhP4P2xzdN/e4DC4bvVV7/hxL9WRu?=
 =?us-ascii?Q?hsPWpQJVScdbYBDydLSAoqzJyG5aGM4bs76KXAo7K7OdnDV/A/li7W6fd46K?=
 =?us-ascii?Q?zHzqtRAExXdeXS7pxla2hDsKaqVfXOR7vZI8sck5TbZ1JX9nGtknKV97U3ZL?=
 =?us-ascii?Q?CmGiTxpiSX+UNLhTqJdRyuUjILHNn54rASpgnuO140CyyBFxnL+M4/MgRpQW?=
 =?us-ascii?Q?s+i4aREdw80e8BsY4g8uXI31L3AdmZltyn2KefyMWBfIG7/AgzJZQHnv5aNl?=
 =?us-ascii?Q?uGmsS3Yi0bANQZQQcLc3HO1WfyopYZnl8Ai4gUE8ER23IEskylOjyCwmgpxb?=
 =?us-ascii?Q?cKzQABsuOMQUtJfNcKM7toWIdwvP8m1vtq0rWLnjOkliInfKP31zjzQ42BqN?=
 =?us-ascii?Q?zHuVKWMHLwOVkKpz5ZLYlFxoN/dvRHvv6JVHwUAW/gei/kyiVgZxrQ1U/H7c?=
 =?us-ascii?Q?Tw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0bdb0fb7-01c0-4fb5-6603-08da6932dd92
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 03:00:42.2516
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C6ml9irXejvJR2jtvhmB+Te+XZMZ1QvnnDtE/JVf08gVLS/ZNDPaOnajHBLQyGHTtvDFZdzR8w/E1pMEYNoc3g8tWiGRwgrldNNHF0q2jDk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB3937
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-18_22,2022-07-18_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 phishscore=0
 suspectscore=0 mlxlogscore=737 adultscore=0 spamscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207190009
X-Proofpoint-GUID: 1Htu93G4MZ0ez-cJ7CT9y3C0LYFT4KVm
X-Proofpoint-ORIG-GUID: 1Htu93G4MZ0ez-cJ7CT9y3C0LYFT4KVm
X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SORTED_RECIPS,SPF_HELO_NONE,SPF_NONE autolearn=no
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Justin,

> For all warnings, the format specifier is `%hu` which describes an
> unsigned short. The resulting type of atomic_read is an int. The
> proposed fix is to listen to Clang and swap the format specifier.

Applied to 5.20/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering