Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <24ccd22f-6708-3265-4012-66f01108ff22@amd.com>
Date:   Tue, 19 Jul 2022 09:45:31 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [RFC FIX PATCH] x86/e820: Stop kernel boot when RAM resource
 reservation fails
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
Cc:     linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com,
        x86@kernel.org, dave.hansen@linux.intel.com, nikunj@amd.com,
        hpa@zytor.com, Abraham.Shaju@amd.com
References: <20220718085815.1943-1-bharata@amd.com>
 <E7A3FF43-C49F-415E-81C6-CD14F4107349@alien8.de>
 <be498c32-bed6-d31a-ae94-6006dd59ea1e@amd.com> <YtV3Ipvt96X/iO2J@zn.tnic>
From:   Bharata B Rao <bharata@amd.com>
In-Reply-To: <YtV3Ipvt96X/iO2J@zn.tnic>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MlhjMkdJa3NIZ08rQ3d4ZmhISTh2bEhkYjFRVEtRdzJUWEp1ZXNoaU5Hclpo?=
 =?utf-8?B?V3VuR1kvelJBN1didmhrQ2tVcVNQUDhvcHNzL2tCa0VKSGNDSkZTSVpBdFp5?=
 =?utf-8?B?SDBzck9zT3YyUjhTSnBsNyswWENEQ3RvdTQ3YU05bjNxSjNTeDhDd1E3ejhW?=
 =?utf-8?B?OXY0WEYyeERYaklnOUVrZzRxaGxiS2g2d1dQYkZ4Q3pGMnBLRGxrTVQxc003?=
 =?utf-8?B?SUllRDJEUTNSVDlXbWx2NzgrTkRtd2VwS21zSGlZZXFzNy9CbnExQks5ZXpU?=
 =?utf-8?B?bzNaYWNVZ0pLQitJWEVFbzRlVElkclZsanRGdmJ4SFJhamttV1pXVnlXWlBm?=
 =?utf-8?B?RFZod0RhSDI2dUVCMnVmYW4vVWswbVBwYmpLVzdqdFhzZExhb1pQckRoKzVp?=
 =?utf-8?B?TWVSVlVFK0dsNGFQYXdzWWdaMm9QbmJ0WkxqOG1kWGhIVGNSUDBYSXI4NkVJ?=
 =?utf-8?B?eEhhaDNMRXJ5UVRBcFZpUEtFMXlQQUJrRWR5QUt4ODUxbmpoSk5aUUdXaHJu?=
 =?utf-8?B?RVdLdmNjQ0FIMUd5YTFSTUsrOHBYQ014aU10cUJwSUJTNzlZMSt4UEJwaW9r?=
 =?utf-8?B?aWpFb3J2dGkweGNZeU92UVlESFFEMzRROUo3S1hmTUFaUlBCMk5aNWlEWDNl?=
 =?utf-8?B?TFdmUUNNSzROckp1RmpsN0hDbnYzMXFINTljSmFaLzJDNnRDaVd0WHZDeEJ1?=
 =?utf-8?B?ZmxNWGFDdUYvM2U3bjVWZ3EyeDhzTWZod1RwUG9uMVYySWlBRW92WmE0LzBJ?=
 =?utf-8?B?RDNHTkc4ZlMwdzVWSHdpYWhYT2E0R3RsOXNRQUFjNUIzaHphLzJCYVA3MTIx?=
 =?utf-8?B?dTMvNDB6eDRvVS9ZNGhKemRTendkMHJOa0o1WUE0L000MksrcGkxcEZob3Ri?=
 =?utf-8?B?UkdhaTJEYjY5a1BrdWUzUDlXQkhKbWtlS1BVNGVjOFdNbnZtdlpqcVNocFJn?=
 =?utf-8?B?TC9vVzZHZzZ0QU1JbE1zbEF2T1Bxd0ttOG14THJ0MHBZYWw1dU5qRnhvYTRJ?=
 =?utf-8?B?d21idzVWRVR1SVRHUjhiSXArY1YzbENFZFhvbUwzZ0g5ZVBjNVdkcml4NXhk?=
 =?utf-8?B?Mk44NitQNFlLb3dPYkhjK2tqZGttWDFETjRsUG1KdVRWcGw2ZHdaWWxWT2lP?=
 =?utf-8?B?ZnZ6WU5rZHVsaU1JRVdxMDhwakhiZk9XT3NtYnBtdGk1RHRNbHNvdllFWXpV?=
 =?utf-8?B?ZXJJZzZlVFIrd1N1YTZObWZyaHgyM3BxbFR4NHR3M1NqMlhOK3dYVXo0akFC?=
 =?utf-8?B?ekdJd24wWkEySVBFeVNtc1NrYjllUWQrdUlDLzVXTFRadVVzeEorS3drOEFK?=
 =?utf-8?B?YzE1R1NSM0ZvZ01pWkVvYWhxMWpDZTZ0RnNFOUJ5NFg1bUZsUEJUTWVQRHdk?=
 =?utf-8?B?VmNwZzVtVHZyMnRnZ1hzOVRJVzNRVG5PWk9TSldZcmZmTEFLREdjdXY0bTVP?=
 =?utf-8?B?L21MUGtmd25zbC9vMWZkRWtrMHd3V29ZQW5SUm12UWg5aHhSSW9XZGNRRHVi?=
 =?utf-8?B?WlhpTEZ0OXZjci9WYnp1UG92QXJCYUlTTHhGQmtvajJLUC9aNWZuLzlrVnk2?=
 =?utf-8?B?Smd6aG9JU0pRdmVCcEVSbXZ2MW5rSEJqNW5GRHlhK0N5MGxxYUUrOUl0K3Vn?=
 =?utf-8?B?QWZpTWZCY1lGbm93TFIyZnIwMXBTK1Zjd0oxZ1p2RE0wb2IvR2FtSEVxWHVw?=
 =?utf-8?B?cjlZRk9Wc2VXdUlxUkRhSlB5ZkZLV1g5SEQ1dXhuTTM0aUxPV0N3QVEyWTZG?=
 =?utf-8?B?ZnVWdzdya0JBV2ovR0JYekUxUWVsbEMrMmR5M3FHa0RmVnRmV1NXRTJDSmt5?=
 =?utf-8?B?bnp4cmZ2eTBYYzBrOSt0V1ByZVduWlN5c3FmUGpSV1huTkdpamUyOXM5NmFm?=
 =?utf-8?B?UkFtQVU5V29RWU50ck5nVE51dWJ4TlFOTzN3VHE2bHFSQmVkV09jKzV1cTkx?=
 =?utf-8?B?MS9mYmx3Rmk0Q3o0MFRjT29nOW5IRmcyTzh1SGxUVkljZTVacVpmY1BId1Qz?=
 =?utf-8?B?Y1JKZWZZMWNtR3paWlJjUlowZEhqaXlRSlAxRGRWbEsrcFdWaGtyc3hCb0l0?=
 =?utf-8?B?bm5pSlBScVYyaUxmdWRIa3lBUDl0aTJjcm9FVXBUVG8ySXNJU0lpNEJCK1Ra?=
 =?utf-8?Q?QUhasAb1dUZUNuJOT3Hl5aOU9?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 410a5a1c-b355-430e-909f-08da693d576e
X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6434.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 04:15:41.0569
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JUMuHATLIaJxX2t8MqVQEMfKTmlyzSXRRtsPDR879E1ZW9IsvSejV4tm0XZRFOeuZJoMjfk3tEgOeItCJxS6dw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3032
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/18/2022 8:37 PM, Borislav Petkov wrote:
> 
> I betcha you can generate a lot of "kernel bugs" with weird qemu
> options. If it is not a real use case, nobody cares.

I see that we will hit this problem by default when starting
a guest with 1T or more memory using QEMU.

> 
> And even if it were a real use case, panicking the machine is not the
> right fix.

I couldn't see a clean exit/recovery option in setup_arch()->e820__reserve_resources()
where this happens. Any suggestions?

Regards,
Bharata.