Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3cc2e18a-1813-9939-4808-a59858f6451e@amlogic.com>
Date:   Tue, 19 Jul 2022 13:57:21 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH 2/3] arm64: dts: meson: add S4 Soc clock controller in DT
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        <linux-clk@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-amlogic@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Kevin Hilman <khilman@baylibre.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>
References: <20220708062757.3662-1-yu.tu@amlogic.com>
 <20220708062757.3662-3-yu.tu@amlogic.com>
 <f5b3e2de-ec60-88ee-4066-6b3860b6c89a@linaro.org>
From:   Yu Tu <yu.tu@amlogic.com>
In-Reply-To: <f5b3e2de-ec60-88ee-4066-6b3860b6c89a@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Krzysztof,
	Thank you for your advice.

On 2022/7/12 17:41, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
> 
> On 08/07/2022 08:27, Yu Tu wrote:
>> Added information about the S4 SOC Clock controller in DT.
>>
>> Signed-off-by: Yu Tu <yu.tu@amlogic.com>
>> ---
>>   arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 9 ++++++++-
>>   1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
>> index ff213618a598..ad2ec26a1f4a 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
>> @@ -86,7 +86,7 @@ gic: interrupt-controller@fff01000 {
>>   		};
>>   
>>   		apb4: apb4@fe000000 {
>> -			compatible = "simple-bus";
>> +			compatible = "simple-bus", "syscon";
> 
> This is not allowed.
> 1. syscon needs also dedicated compatible
> 2. simple-bus with syscon means it is not a simple bus anymore, so nope.
I will correct it.
> 
>>   			reg = <0x0 0xfe000000 0x0 0x480000>;
>>   			#address-cells = <2>;
>>   			#size-cells = <2>;
>> @@ -118,6 +118,13 @@ gpio_intc: interrupt-controller@4080 {
>>   					<10 11 12 13 14 15 16 17 18 19 20 21>;
>>   			};
>>   
>> +			clkc: clock-controller {
>> +				compatible = "amlogic,s4-clkc";
>> +				#clock-cells = <1>;
>> +				clocks = <&xtal>;
>> +				clock-names = "xtal";
>> +			};
>> +
>>   			uart_B: serial@7a000 {
>>   				compatible = "amlogic,meson-s4-uart",
>>   					     "amlogic,meson-ao-uart";
> 
> 
> Best regards,
> Krzysztof
> 
> .