Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp4127842imw; Mon, 18 Jul 2022 23:31:33 -0700 (PDT) X-Google-Smtp-Source: AGRyM1u16pqUssq1zqXBtMlfyhUjURrOKs2sJwBM0lFtNagAPf2R+xVukCzr184bsNtgU9PN+0g5 X-Received: by 2002:aa7:c657:0:b0:43a:4a68:bcc5 with SMTP id z23-20020aa7c657000000b0043a4a68bcc5mr43354900edr.337.1658212293572; Mon, 18 Jul 2022 23:31:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658212293; cv=none; d=google.com; s=arc-20160816; b=yX7QBANZC9suYVrNDOyA/ZVOGhhF0eSKzXMCQaONBTwhiI0XXBstxz+g1lDtayk9qy LDYti3YrSTbHb998n2o5ETmgUAiPtgJUc9XP1+eAbo+eifjmU3XUSqe7JugZ2+MeuerY 4gMlWnJwnpMG4EhXktatNYdNrqdwWAKFiqwIjXmzMrEELQDw3Iu3vMW3NQK6YYoXont4 kabZ4D1KNtN7eQEz1wbyKn++xxpgtEg4UQQcjQvfga1HcTl9vzKKPwgQ1OP9typspOFA J1USnleUJsw8f2L1502empi/rlOrJPaVIs0v6kf10VaQUp+JVUcQJd7tbjOn2aHOC14Y j+Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=UGreb3otYXicSc9AyATwfdoBfIrCHzGc1xh2ozqtBEs=; b=fmVXQGhsjxFM03xfnoFI3uJcDn12Aet6lwUGzfz+JzLX23HW+J27MRWH8jdlUCEr4J UrwcTGE8R35xAxUfVI1+5UCgOEl7qEe8j9Ou+7UEr56wEDXXAhqvtVvbeIHybiUolwAI KQ5s2r2MlyF4/5STAdw6adX1YTEnelw/3lnzUJL40ogBPBFCsjm9Bto9+S6IzyFaydM3 V2ElNm7/umzZcHJUJ6n0M9pEB9fuUBHTRNji4JfxyQuQLs62kC1ds/fNUswRISXQ+bu6 Dj6c2cbv+O+ZbESnDh7J2JopQiYJejP3B8KWJVQ0LsaXc+j9YyPnIu/UYqXxydwwIQh3 J7Pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=OYOtd68a; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i8-20020a1709064fc800b0072b872932d6si24407820ejw.567.2022.07.18.23.31.08; Mon, 18 Jul 2022 23:31:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=OYOtd68a; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229798AbiGSFwA (ORCPT + 99 others); Tue, 19 Jul 2022 01:52:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229618AbiGSFv6 (ORCPT ); Tue, 19 Jul 2022 01:51:58 -0400 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 848513340E for ; Mon, 18 Jul 2022 22:51:57 -0700 (PDT) Received: by mail-pl1-x633.google.com with SMTP id p8so1246516plq.13 for ; Mon, 18 Jul 2022 22:51:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UGreb3otYXicSc9AyATwfdoBfIrCHzGc1xh2ozqtBEs=; b=OYOtd68a+OLe314P9GifUJZ4m5i3HRORK2DfvIerbUosILabyXspkzeS5vIBIQ/jrS oc+68fW3haoF+noCVEKxfrQah/IRqa25Db3KLUH/emzoGOXrD0QeqQIfxECtcGeLdmZy rRUHe8JfuFS6HO3DzmsbPX0wme1xbPcSqO31gbBoanjWiOAp0YNcCgO9wuL2rk37hY6z 0QmsZy6GRnkyOXNVfFNwGsf+fnqmwt7N/iwEXOPDt94a7QTd3C9uWlFTCDtZLAiSy7SW pRP5qX1sDDYxNb687kR0UccQEfflolGuhkAfr12k441kpCaS1umwfOUk9zBrHn9CR9TA KASw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UGreb3otYXicSc9AyATwfdoBfIrCHzGc1xh2ozqtBEs=; b=5LTNa+mHoAKEZoLuvNPhtXpv5VxlC4oQ3HwL06DEX8AVOM9A915KsjsblDG4tbjRDx d87q3eQkPZiUzmCjyvpaXbe/u2bzY0UEtFeB1aVRlTVLfwPEsPGGYQnODBTFeN7dB4yF CXkY4VV25eDHRFOhA5HgPPYChJ6DwO1l5mbMkSKc/QL9b+81r293ZXW7k1Ei9nl0G456 0MS3Lhx6og0Lzcqgh4dsC6ePvXkLLVB+3MeL9IwKIrRHaGAGT3sU9FGxUtyIOOnX1J4f k2kupRnZiQlkOwu+zRWl4VpVYmVl68D0InvKcnr+AEHeXga5b4uHSK+kpI/blAWhtgSH lDvg== X-Gm-Message-State: AJIora9mrFgZtSQ3XyH8VHmSFgSxJ3W+oCKCseFPh6ltJcVOvO3ZEN8+ IDfkjVOy2IBLSioHAcJMPKE= X-Received: by 2002:a17:90a:bc8c:b0:1ef:91ca:1c24 with SMTP id x12-20020a17090abc8c00b001ef91ca1c24mr42539239pjr.81.1658209916771; Mon, 18 Jul 2022 22:51:56 -0700 (PDT) Received: from tong-desktop.local ([2600:1700:3ec7:421f:33db:e37c:7ee3:662b]) by smtp.googlemail.com with ESMTPSA id a16-20020a170902ecd000b0016c20d40ee7sm10709338plh.174.2022.07.18.22.51.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Jul 2022 22:51:56 -0700 (PDT) From: Tong Zhang To: Greg Kroah-Hartman , Tong Zhang , Jakub Kicinski , Colin Ian King , Saurav Girepunje , Nathan Chancellor , Johan Hovold , linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Cc: dan.carpenter@oracle.com, Zheyu Ma Subject: [PATCH v2 0/3] staging: rtl8192u: fix rmmod warn when wlan0 is renamed Date: Mon, 18 Jul 2022 22:50:35 -0700 Message-Id: <20220719055047.322355-1-ztong0001@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220718120149.GD2338@kadam> References: <20220718120149.GD2338@kadam> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There are 4 debug files created under /proc/net/[Devname]. Devname could be wlan0 initially, however it could be renamed later to e.g. enx00e04c000002. This will cause problem during debug file teardown since it uses netdev->name which is no longer wlan0. To solve this problem, add a notifier to handle device renaming. Also, due to this is purely for debuging as files are created read only, move this to debugfs like other NIC drivers do instead of using procfs. Reported-by: Zheyu Ma Tested-by: Zheyu Ma Signed-off-by: Tong Zhang v2: break down patch and fix pointer check Tong Zhang (3): staging: rtl8192u: move debug stuff to its own file staging: rtl8192u: move debug files to debugfs staging: rtl8192u: fix rmmod warn when wlan0 is renamed drivers/staging/rtl8192u/Makefile | 1 + drivers/staging/rtl8192u/r8192U.h | 6 + drivers/staging/rtl8192u/r8192U_core.c | 223 ++++------------------ drivers/staging/rtl8192u/r8192U_debugfs.c | 188 ++++++++++++++++++ 4 files changed, 235 insertions(+), 183 deletions(-) create mode 100644 drivers/staging/rtl8192u/r8192U_debugfs.c -- 2.25.1