Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp4154785imw; Tue, 19 Jul 2022 00:21:09 -0700 (PDT) X-Google-Smtp-Source: AGRyM1u7LL7VZZJJo7IiJqSpYMZ3ySrjQ19hZerW+c5nhpVSF9iKAJ7z0N9k3Kd/qbny8YwRnL/k X-Received: by 2002:aa7:cdc2:0:b0:43a:7255:5274 with SMTP id h2-20020aa7cdc2000000b0043a72555274mr18922162edw.159.1658215268824; Tue, 19 Jul 2022 00:21:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658215268; cv=none; d=google.com; s=arc-20160816; b=C2DD3B0/8p5lZp1wyvx2ajoOznEvKMMWT76rXKHTXUBQfiRoUrDpmtMTNP7zt2oYe4 ZDyd0XefFTlQ2zhCe/+KQYLf5778ATAc0M+9ocHgsV+4KpCtKPuQx3/OZsU0JipMbw4K qeY56++J/Ok7CwFqygj4/N8NzlpezfvasA6FK0U0A5keIeDiqm92w96JCL2M4MShtlTl pqtfMgQA+Jke2pmj+8blcVRFbckLU4AK3JsL+8/AnhB/9x5u1xp22fKeYtR46AstiLZU cqgF8FGT5evw9MHF+/WMSHSq9+gTsP0ZFtXxH43yRLWetK2uZB8iqaRER33YzFDPPWob U+fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=zqOmOnEJCv9IVysfrttSXHsZ2IYQybgfG/pH607LPbA=; b=DWXmk9g4/d2OJpmIjILrogM/UVaYHloKm/gKnu99l/MQfz6YliIJVJzRcihTNfcAlT GR32Y69a4LDpGAxblpqdmyYLMFKgqe45t0TiiI4+1CcSoJffjE73pu1VsOhbfA+40qiv J3phd3OzjDA3mtzgrFRpVbchdGIh60dFMB3KVyeb2Xubu2exBTWZbo9P7XEduMHOiaMG ZOm+N8Y4xkmjCBUO5o8hbnllZDAY1J36bjmbayf0LkbHrBOVAY9+6k4L2lQsOYkMaWmo sKZN7wC7URqEPLZxARl2T3vKBMOdnrrslekRmIhRoTiUJOrZxRwReLjSsJ+WFjkdFegs gTOQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l17-20020a170906795100b0072b4b197fa4si20697087ejo.88.2022.07.19.00.20.44; Tue, 19 Jul 2022 00:21:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235165AbiGSHI2 (ORCPT + 99 others); Tue, 19 Jul 2022 03:08:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230328AbiGSHI1 (ORCPT ); Tue, 19 Jul 2022 03:08:27 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6230025C54; Tue, 19 Jul 2022 00:08:26 -0700 (PDT) Received: from dggpemm500020.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Ln8w26wWPzVgQ4; Tue, 19 Jul 2022 15:04:34 +0800 (CST) Received: from dggpemm500007.china.huawei.com (7.185.36.183) by dggpemm500020.china.huawei.com (7.185.36.49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 19 Jul 2022 15:08:11 +0800 Received: from huawei.com (10.175.103.91) by dggpemm500007.china.huawei.com (7.185.36.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 19 Jul 2022 15:08:10 +0800 From: Yang Yingliang To: , CC: , , , Subject: [PATCH -next] media: vimc: fix wrong pointer passed to PTR_ERR() in vimc_create_links() Date: Tue, 19 Jul 2022 15:17:21 +0800 Message-ID: <20220719071721.703986-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500007.china.huawei.com (7.185.36.183) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It should be 'ret_link' passed to PTR_ERR(). Fixes: d534b9520a12 ("media: vimc: add ancillary lens") Signed-off-by: Yang Yingliang --- drivers/media/test-drivers/vimc/vimc-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/test-drivers/vimc/vimc-core.c b/drivers/media/test-drivers/vimc/vimc-core.c index c73f91947f44..2ae7a0f11ebf 100644 --- a/drivers/media/test-drivers/vimc/vimc-core.c +++ b/drivers/media/test-drivers/vimc/vimc-core.c @@ -211,7 +211,7 @@ static int vimc_create_links(struct vimc_device *vimc) media_create_ancillary_link(ved_primary->ent, ved_ancillary->ent); if (IS_ERR(ret_link)) { - ret = PTR_ERR(link); + ret = PTR_ERR(ret_link); goto err_rm_links; } } -- 2.25.1