Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp4178078imw; Tue, 19 Jul 2022 01:03:08 -0700 (PDT) X-Google-Smtp-Source: AGRyM1ujgiwK8k56Etev1P1+/O/EUUYiHtFzGL9QC9H5fKm4zn5yhjr9puZ4T3liYhU6+UXNA4mm X-Received: by 2002:a17:906:9b8b:b0:72b:13f6:8957 with SMTP id dd11-20020a1709069b8b00b0072b13f68957mr29181808ejc.239.1658217788317; Tue, 19 Jul 2022 01:03:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658217788; cv=none; d=google.com; s=arc-20160816; b=ll7QPfQjAXltg1aFz8knHVO8CBc3T5iO9EH8yoS3poZKyNyO4Ry6mS1wz7TWEfmywa 8mplF/+4lszDpSpdTV4Jdwdm9kZqafp/1bG3nJ+qNbWvaULhRjAD794CAXUEgHmNBlI9 6PIKl9vocwL7Dwc/8cqDYz9OelV47Nh8nx/NSs42IpknuvT60dzOS0k1ZNBsQlui9cvS r2q42noqMG2akkuaWc4JjGeHlnQhxh81WECCbLPxrTeC269rSwt4BS/jHohoCYQMEOXy L6x3c3bKGTBU5jsvWcVAOwAMZ43zwYzJq+eOAuMk2kv9ToKZROyvvVm0pjEd6qLV6bdG Nbjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=TZJK2+UHw9IfQSA8Jz9jMJzE6vbq53LySvelY/Wqz4Q=; b=r8ze29Bl11fL72TjJQ2fRd0ZN9wA+RIkZI6b4srIhqssqh/P9KieM5TV98OuLDzXmJ 0c4ICkAdBJ1HcpPQeNYuMcMUFoEOI3jEWgf9PLh1cDdMUt0UY9CHvKGoJeKgzmBTZy2V VthdXo9ZI6aP47btoZcgPYIQCjtlxPjicYfrrnv1tAF/YOCTkZuxxa4Ae1s/ZqgFF7Zo z1nEr6t2azn465lYsW0QWA/om4XWPHI0LGZ9MrBNgw8smwZuspbm7kt2mFMage+NcIWj Ai9Y+s4ipdOVwqy+Scsx5I27s5JTie+6h4/fe2TTLNSFYhMwOlVq5Jm8WMdHNwXwJ+GO HaAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TbtXJsdN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f12-20020a056402160c00b0043a6d0dc5c7si16917745edv.605.2022.07.19.01.02.43; Tue, 19 Jul 2022 01:03:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TbtXJsdN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237055AbiGSH5t (ORCPT + 99 others); Tue, 19 Jul 2022 03:57:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234892AbiGSH5s (ORCPT ); Tue, 19 Jul 2022 03:57:48 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD68533A12 for ; Tue, 19 Jul 2022 00:57:46 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id v12so18477732edc.10 for ; Tue, 19 Jul 2022 00:57:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TZJK2+UHw9IfQSA8Jz9jMJzE6vbq53LySvelY/Wqz4Q=; b=TbtXJsdN2sKD6oakm5TuE9Y8jv4K28Vl0MI8OF9L3RV6a0PaLRCf2jiTdvA8WCuiCZ NKkzst65SFMbfHFotDaKH0LYahPClkhG0S5r5re9Luc0c1ElQKIegec37Jace4rnX4Eg 5GuknkNzK8iwSvqWrslLRJ0/h+FcMmOiExBCXfKE/wCOdFSSv8/6U12G+niEo8ZB3cnt GrmXKGj8U1ttbkHfe8SZ/IKBffPn9GuTITucqsDDa+j/4ETSkg8e6zwMd4NRb7wyhqig 7P7IhopEVykaoXfiQBvWnpw/tZ233AZBt/Atd2WNkLTROimVQPs7O1H2QdnSGdkyAgLu Y6kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TZJK2+UHw9IfQSA8Jz9jMJzE6vbq53LySvelY/Wqz4Q=; b=FY8JrZIpdw1dmEwhsukEMHTZg4dcxSuCUV87KWkURxYxwUl1k1AtjlQBz46yrLX0K9 DraTPPgKok5gFi9tggSEHJgcb6I8tIDpamlKdlE4HG92W7P+A5iVVFj6tA22+5+jfTMK UncqOgN1W9rpIFMmGN2SXGFevLc4SM221kDLuoGyxNbA6ojxfSQlya03ABNLiPxfXuHH Rxq60Vsn7aaCmV6KRr/pRZ0ZaIQ2uHSsXQFp7w3guidSDI8OMf19WDH9jGU82uHpH1U5 snZKvpWjWuZWA2DxIyaJnwNTl2LSwdafi31yJxqZSmiXWL4zIZ/CyiRuBpI0Y+dPyOqU yklA== X-Gm-Message-State: AJIora8keP6E4r3zIBqezDKtpuU9+fRCuH2rEQhZgfbhUI16WkFPVHtT pWilIMLCXkYhfiog+rE79E80adk5iqIayiJcjDtllMVQv+m2VQ== X-Received: by 2002:a05:6402:26c3:b0:43a:a846:b2c1 with SMTP id x3-20020a05640226c300b0043aa846b2c1mr42621866edd.133.1658217465302; Tue, 19 Jul 2022 00:57:45 -0700 (PDT) MIME-Version: 1.0 References: <20220719022743.305189-1-trix@redhat.com> In-Reply-To: <20220719022743.305189-1-trix@redhat.com> From: Linus Walleij Date: Tue, 19 Jul 2022 09:57:34 +0200 Message-ID: Subject: Re: [PATCH] power: supply: ab8500: remove unused static local variable To: Tom Rix Cc: sre@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 19, 2022 at 4:27 AM Tom Rix wrote: > cpp_check reports > [drivers/power/supply/ab8500_chargalg.c:493]: (style) Variable 'ab8500_chargalg_ex_ac_enable_toggle' is assigned a value that is never used. > > From inspection, this variable is never used. So remove it. > > Fixes: 6c50a08d9dd3 ("power: supply: ab8500: Drop external charger leftovers") > Signed-off-by: Tom Rix Thanks Tom! Reviewed-by: Linus Walleij Yours, Linus Walleij