Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 19 Jul 2022 11:04:31 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Tong Zhang <ztong0001@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Colin Ian King <colin.king@intel.com>,
        Saurav Girepunje <saurav.girepunje@gmail.com>,
        Nathan Chancellor <nathan@kernel.org>,
        Johan Hovold <johan@kernel.org>, linux-kernel@vger.kernel.org,
        linux-staging@lists.linux.dev, Zheyu Ma <zheyuma97@gmail.com>
Subject: Re: [PATCH v2 0/3] staging: rtl8192u: fix rmmod warn when wlan0 is
 renamed
Message-ID: <20220719080431.GY2316@kadam>
References: <20220718120149.GD2338@kadam>
 <20220719055047.322355-1-ztong0001@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220719055047.322355-1-ztong0001@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?F93Z3L9b1RTLXcIipDglMkyMNsk7sHCXZHMMghSdJQmGOYWYTXig7RzxGu+t?=
 =?us-ascii?Q?quqk7bJleXLHiOCJwbUUxZ4CObQEZZVt1A4sKeBhUD3om2L5s5ikIiVJqAFk?=
 =?us-ascii?Q?P9kphHFPX4YRSUFMEmu+1ne8zen/4YtnV0af6g5tWBRhfjd7fEolGUzXupYv?=
 =?us-ascii?Q?qog2WIHzoFYo4+IWrCA06cf2LnR2rw4lCy0zsX9uXi+/CLQXSz2ibQRxWV1O?=
 =?us-ascii?Q?PxWPTGbEbXt/OxMRWDayxza9odlvy4APCP299rG+kvnR4V5LeD8reM/VT3vy?=
 =?us-ascii?Q?vH7qwq2c+cRPYjuQtAz9xFjoGIyXSlyw9OaDUs7RE0Lq8VIAjjSDyCMIqWDq?=
 =?us-ascii?Q?lX4dv1Ud+wNXTN19lMB9gO7LYB19gikProEU+EbfhuMN19w27YI6ywP/MddE?=
 =?us-ascii?Q?rff988yMmjbP/T7KBB5B/g/EjSjsXtSfQ3gvcHLErE1QkbMpihX4QGd0Ujpc?=
 =?us-ascii?Q?WHwowZ1okTarICrUl6wfAtJ+i2ylqbH2yukma6C//UrsRoqWXC+EUyuSjpuz?=
 =?us-ascii?Q?p5qIcHZxLD7WX9ElQ/RgnWH+GM7PtSjZD7QS/3buPM4+H2w1rJ2I8bqPW7eC?=
 =?us-ascii?Q?mKCSIqJYrTHC5pgvOqiJuaftoQmbasMOl44cwPghagdWGR4gzQhXPk/K8BeL?=
 =?us-ascii?Q?07MWjSc6fZ8hXty5RzWfmiX/tMqqc7iGhzU4X8LkfBKEwMVJZZ0tRTLVMg/m?=
 =?us-ascii?Q?GcypUyYHaNuICDzvFokWzTKZoQbtNyRe814ejf5WtwMRUbySUcjAUCScpSNV?=
 =?us-ascii?Q?we2LEOeayat/yCSBQPXLbrsKtuCfIU3jkO5cJtRYGeDd3LGVWDMHH2ZyspVi?=
 =?us-ascii?Q?Vs+ljKwvC9XDkJD8e3H+4qgqOMek84+M0x1lfuIWEKwwasa3pMV52UfcHV6O?=
 =?us-ascii?Q?HT9bjkvGNA+feFY5i8xibLAkC6qeo0EP+lhyIGhbcBDHKwgL7pix3+Of5oA9?=
 =?us-ascii?Q?NN2nXz9DJFzrbocPFKs2xZq2JJD38dNuKm4OkAYW7HT8NVYnn+biuDIMub+4?=
 =?us-ascii?Q?ZPT2D5IKiItZywLMqfwNNQjdK3mR/YsMeujJgZqzLZ/FXSBcPFyJFV+wdHp3?=
 =?us-ascii?Q?2ZE0Gg1HJWut6qhbG3DjTmjKOSDV6mg8kokXNNZIz3VUpuAgeAM3BUxB5NG9?=
 =?us-ascii?Q?tsjXCIeX/OgW/+OARXfWof1aNaRjlugDKaXjVMSQcTmzJiFWZXcRUj/R6C84?=
 =?us-ascii?Q?atHZ9iI8OSVjqICglOEdim+HuGFsO63RivEPxbFT+EIsWTdrjj4hna6uwJhi?=
 =?us-ascii?Q?xx0rZKEO/xS+aSBEmvJMjlgOKsFonfU+0yHiVQPtQN9HNMmHSTlsAgWqduk4?=
 =?us-ascii?Q?LDYfUgSwHqOkL4KtweksqRjnDWCpYZbsjrIdZmIv9deD+YjoN+JxQNPi2HNp?=
 =?us-ascii?Q?0jgzF1X6rMwk/lSG7+qfQyKJkjpy+HkciB/IpIaxom8S/wkQgR10GZtmMMV9?=
 =?us-ascii?Q?RjegI+TqCGFVKGaj82lz0wXUku1WZ+/KUIcRugE5UaAOTz2F3uehfAraHAxS?=
 =?us-ascii?Q?mq1lWspgCI5ckdOQ74ooy4dMDCtSPJO1hy9brLs31kl4OWivRhJSe9D1dZ1+?=
 =?us-ascii?Q?OG/yqihIwWgCEHyWZT/q2N9KCw1/F977IeKlYSepQoOHZZHioRjR7UQzLzZg?=
 =?us-ascii?Q?Mw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69c21fb3-64ea-41a5-2a9e-08da695d5aa1
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 08:04:50.2232
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VP6caeVbJD2Pe6BL+o+dl0OYAYBDSqrGaW0GEZHOnimVPyJY28AoomgZB2QmYrchIHE+HS7QVU7MQ/IV1Qli/Y9KEktnjHu1zNQXYhPpc24=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB3946
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-18_22,2022-07-18_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 adultscore=0 phishscore=0
 mlxlogscore=999 spamscore=0 malwarescore=0 bulkscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207190034
X-Proofpoint-ORIG-GUID: nWW5rN5K0NoOozUWuXrzKqMBSB6EMOfW
X-Proofpoint-GUID: nWW5rN5K0NoOozUWuXrzKqMBSB6EMOfW
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jul 18, 2022 at 10:50:35PM -0700, Tong Zhang wrote:
> There are 4 debug files created under /proc/net/[Devname]. Devname could
> be wlan0 initially, however it could be renamed later to e.g. enx00e04c000002.
> This will cause problem during debug file teardown since it uses
> netdev->name which is no longer wlan0. To solve this problem, add a
> notifier to handle device renaming.
> 
> Also, due to this is purely for debuging as files are created read only,
> move this to debugfs like other NIC drivers do instead of using procfs.
> 
> Reported-by: Zheyu Ma <zheyuma97@gmail.com>
> Tested-by: Zheyu Ma <zheyuma97@gmail.com>
> Signed-off-by: Tong Zhang <ztong0001@gmail.com>
> 
> v2: break down patch and fix pointer check
> 
> Tong Zhang (3):
>   staging: rtl8192u: move debug stuff to its own file
>   staging: rtl8192u: move debug files to debugfs
>   staging: rtl8192u: fix rmmod warn when wlan0 is renamed

Thanks!  This is much better.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter