Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 19 Jul 2022 09:33:33 +0100
Message-ID: <87mtd5zele.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     wangwudi <wangwudi@hisilicon.com>
Cc:     <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>, <lizixian@hisilicon.com>
Subject: Re: [PATCH] drivers: irqchip: Allocate alignment addr by ITS_BASER.Page_size
In-Reply-To: <945e4200-9555-b6a4-5588-0d1c1b0be152@hisilicon.com>
References: <1657955136-6622-1-git-send-email-wangwudi@hisilicon.com>
        <87tu7h4d78.wl-maz@kernel.org>
        <945e4200-9555-b6a4-5588-0d1c1b0be152@hisilicon.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, 18 Jul 2022 08:35:47 +0100,
wangwudi <wangwudi@hisilicon.com> wrote:
>=20
> Hi Marc,
>=20
> =E5=9C=A8 2022/7/16 17:30, Marc Zyngier =E5=86=99=E9=81=93:
> > On Sat, 16 Jul 2022 08:05:36 +0100,
> > wangwudi <wangwudi@hisilicon.com> wrote:
> >>
> >> The description of the ITS_BASER.Physical_Address field in the ARM GIC=
 spec is as=20
> >> follows:
> >> "The address must be aligned to the size specified in the Page Size fi=
eld."
> >> The Page_Size field in ITS_BASER might be RO.
> >>
> >> Currently, the address is aligned based on the system page_size, not t=
he HW=20
> >> Page_Size field. In some case, this is in contradiction with the spec.
> >>
> >> For example:
> >> ITS_BASER.Page_Size indicate 16K, and kernel page size is 4K.
> >> If HW need 4K-size memory, the driver may alloc a 4K aligned address.
> >> This has been proven in hardware.
> >=20
> > Ah, interesting bug. Thanks for bringing this up. Can you describe how
> > this occurs? I suspect you are using indirect tables.
> >=20
>=20
> Sure. In the system, kernel page size is 4K, and ITS_BASER.Page_Size is 1=
6K.
>=20
> As you suspected, HW used indirect VPE table and indication supports a sm=
all
> number of vpeids, like 2-bits vpeid. So that HW requires only less than 4=
K-
> size memory, and 16K aligned base address. But driver alloctes 4K aligend=
 base
> address.

Well, that I dispute, see below.

>=20
> >>
> >> Cc: Thomas Gleixner <tglx@linutronix.de>
> >> Cc: Marc Zyngier <maz@kernel.org>
> >> Signed-off-by: wangwudi <wangwudi@hisilicon.com>
> >> ---
> >>  drivers/irqchip/irq-gic-v3-its.c | 3 +++
> >>  1 file changed, 3 insertions(+)
> >>
> >> diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gi=
c-v3-its.c
> >> index 5ff09de6c48f..0e25e887d45c 100644
> >> --- a/drivers/irqchip/irq-gic-v3-its.c
> >> +++ b/drivers/irqchip/irq-gic-v3-its.c
> >> @@ -2310,6 +2310,9 @@ static int its_setup_baser(struct its_node *its,=
 struct its_baser *baser,
> >>  		order =3D get_order(GITS_BASER_PAGES_MAX * psz);
> >>  	}
> >> =20
> >> +	if ((psz > PAGE_SIZE) && (PAGE_ORDER_TO_SIZE(order) < psz)) {
> >> +		order =3D get_order(psz);
> >> +	}
> >>  	page =3D alloc_pages_node(its->numa_node, GFP_KERNEL | __GFP_ZERO, o=
rder);
> >>  	if (!page)
> >>  		return -ENOMEM;
> >=20
> > However, I don't see how you end-up with the incorrect value here.
> >=20
> > * No indirect table:
> > 	alloc_its_tables():
> > 		order =3D get_order(baser->psz);
> >=20
> > * Indirect tables:
> > 	alloc_its_tables():
> > 		order =3D get_order(baser->psz);
> > 	its_parse_indirect_baser():
> > 		new_order =3D *order;
> > 		new_order =3D max_t(u32, get_order(esz << ids), new_order);
> >=20
> > So in both cases, we should end-up with order >=3D get_order(psz).
> Yes, totally agree.

OK. So what does your patch actually fixes?

>=20
> >=20
> > Clearly, I'm missing a path, but your commit message doesn't make it
> > obvious. Can you please enlighten me?
> >=20
> My commit is based on the premise:
> "alloc_pages_node gives a size-aligend address".
> For example, if HW apply for 4K-size memory, then allocated address is 4K
> aligned.

Right. And if baser->psz is 16K, the memory returned will be 16K
aligned.

The only thing I can imagine is that there is a code path that doesn't
use baser->psz as the minimum value when allocating memory programmed
into a ITS_BASER register. But I can't see that path. Can you?

	M.

--=20
Without deviation from the norm, progress is not possible.