Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp4234984imw; Tue, 19 Jul 2022 02:36:53 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uFLu+eMLBNE5HcBX15icU63sN8iP2Zuei9C1XyMqpEgecnCMqF2otZhNzQN/fQxgzxPoAy X-Received: by 2002:a17:90b:1e12:b0:1f0:4b4c:868a with SMTP id pg18-20020a17090b1e1200b001f04b4c868amr36396869pjb.57.1658223413072; Tue, 19 Jul 2022 02:36:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658223413; cv=none; d=google.com; s=arc-20160816; b=qf4Jcg0t/SQWrGl9iHKYPQkDvvRmKrcVJRtTFLM4MURWRj974CG8Q+XVg7z4NhcSrd ZmeuimqhtJqUJBXPHQox8JE4IWR14gNpAQ3Vgoo5JziD6uuRUVZO9xPFAN/5uuh3G8TB NtnYU9NpHCejaJbNYNDFzIH5LacD1rCZ6UyIcQPtpyVBOTcFOxzKBrPdTLxZCDbQKOMG ggUKaweoJmA6sgeHwgH6ovTThAM4kqvgHR2q2vE6zh7ZBSXn02ODUehwYwT280Hfnbk2 BudLee4NeVtYgsZ+xB1zijozA8IFLrghy12B6RxQaNwwe5PjkHdwq+jrRNja0q4Zveqh Qv6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=EiPIlo7Vs9DiAdVRyUDYHpIazmfJsBIl7QHLBcvn4ws=; b=Z6GIpw/PCCbcU+tWIhRpfWyhRdPz3SWMPF9wvr4BKB705wKIHluKxOxHgl1bkRG/cm EURhFxUau+91RYD+oj4DVukwssLUKw1FX1X7ocq5xLYc1UPF3/NAZnhj674LXzy6CjJi EqcPGi28QSLjoB2APXUV0DXEEkype+JyS7zbl7FGFHgCXP4Fd8oXCzLvWlZSDuUVWr1H m3dz9Ds2gE1QgTp6RXMVaKysziQtW7vYkKYWSiKIkCNkcPdydq+1wEdEXJWlt9/iww5+ p41ZLvqlWhfiBm4szLf3gY/9WZKYJs/mbL4cfolCgN5j7zJ4A0dMcoYbq3OGHR7QhXf0 5AIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hM+2WuSb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i189-20020a6387c6000000b00419fc0f56a3si10786621pge.89.2022.07.19.02.36.37; Tue, 19 Jul 2022 02:36:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hM+2WuSb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236686AbiGSJQS (ORCPT + 99 others); Tue, 19 Jul 2022 05:16:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234384AbiGSJQQ (ORCPT ); Tue, 19 Jul 2022 05:16:16 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8744E192A9 for ; Tue, 19 Jul 2022 02:16:15 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id u15so16612936lji.10 for ; Tue, 19 Jul 2022 02:16:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EiPIlo7Vs9DiAdVRyUDYHpIazmfJsBIl7QHLBcvn4ws=; b=hM+2WuSbikErcQCOyaqBuoFCnyPuxWNYo2/OMPttH7Y+o88vMjcPOOVYbMmyYshBoC 0Zd0smGcJAQi+FWY5zER6o4dtm2BcBXLViOZAsX8cMDsfyFjLCun/gcf2YfnvaWOu8+4 gAaOfvj+DZKGqN0AU3gu/5I6Sh4TCcmM4l3I/98FBFhBYRq9fwjh+ayXkfuH1btdPbFh hzdb8EH68P8mQkg15y2/ULYK1FffxEWB5nzdqnnNb/6oU8me87tFyH4/iTHA16nvIzSH 7sKeLscjXs42YoBmS/DBQHkZ1z9CS9qRJ7DVHA/yMS0Kg3LQ5eGKzAdUy7b9Y3UBd6Cf g5eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EiPIlo7Vs9DiAdVRyUDYHpIazmfJsBIl7QHLBcvn4ws=; b=s8pxMpzgO2SDOVTrl7JCMvYQkUqiC+wAjStN5K6JFQepsutcBC0gp9xV4N6FNM/N05 zmkkjn1QiO37vVicc64J6RZlW/dLf6as2k0R/xhLwl8LtIw4Fx5Rul+Qwxvourbt9X7G ND6QQPwW0mymTTFEQyMcT4jSwiD8/Kf53Gyqf93wmBFWfIWNHeP+RmkaWQ6KoFNYThug ehAh/SNYObjKLq2EjBoJyPERyM+Kap0omAT+jkGLNQCag7t8qj18fMoR6DvbaSDFPCiN 9Z3ThIwkcs6iKFH4wAZ/UzVWbFgnthsAIf3xhCyftvbli+h/I5EQMiPE44IDP1QylS+E B0SQ== X-Gm-Message-State: AJIora8OorWmRfENoRQNJ3hE5Hkp6Ln6WagbAj4sHe8OmbSh20t5xlG6 QGNR3Omr3j4O36ZaCN57sjwQhGoByaPtybf0 X-Received: by 2002:a2e:87d9:0:b0:25d:88e1:d710 with SMTP id v25-20020a2e87d9000000b0025d88e1d710mr14162688ljj.361.1658222173596; Tue, 19 Jul 2022 02:16:13 -0700 (PDT) Received: from krzk-bin.. (89-162-31-138.fiber.signal.no. [89.162.31.138]) by smtp.gmail.com with ESMTPSA id c23-20020a2e9497000000b0025d520648d1sm2549062ljh.43.2022.07.19.02.16.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 02:16:13 -0700 (PDT) From: Krzysztof Kozlowski To: linux-kernel@vger.kernel.org, windhl@126.com Cc: Krzysztof Kozlowski Subject: Re: [PATCH v2 1/2] memory: of: Fix refcount leak bug in of_get_ddr_timings() Date: Tue, 19 Jul 2022 11:16:11 +0200 Message-Id: <165822216749.37301.12699502568759184723.b4-ty@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220719085640.1210583-1-windhl@126.com> References: <20220719085640.1210583-1-windhl@126.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 19 Jul 2022 16:56:39 +0800, Liang He wrote: > We should add the of_node_put() when breaking out of > for_each_child_of_node() as it will automatically increase > and decrease the refcount. > > Applied, thanks! [1/2] memory: of: Fix refcount leak bug in of_get_ddr_timings() https://git.kernel.org/krzk/linux-mem-ctrl/c/b54af20531018c2bb7181ba2f511327b3c9f1cef [2/2] memory: of: Fix refcount leak bug in of_lpddr3_get_ddr_timings() https://git.kernel.org/krzk/linux-mem-ctrl/c/2f1b3550a152baa8287ee95586f0385410a5296b Best regards, -- Krzysztof Kozlowski