Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <895e7df5-65e5-7b26-81d6-864e68957ab6@linaro.org>
Date:   Tue, 19 Jul 2022 12:18:45 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] arm64: dts: Add device trees for MSC SM2S-IMX8PLUS SoM
 and carrier board
Content-Language: en-US
To:     Francesco Dolcini <francesco@dolcini.it>
Cc:     Martyn Welch <martyn.welch@collabora.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, kernel@collabora.com
References: <20220718152310.1937899-1-martyn.welch@collabora.com>
 <4473378f-1c14-3ec7-5380-12f49f3b1e3b@linaro.org>
 <YtaEUvP4jpO5Dggg@gaggiata.pivistrello.it>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <YtaEUvP4jpO5Dggg@gaggiata.pivistrello.it>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 19/07/2022 12:15, Francesco Dolcini wrote:
> Hello Krzysztof,
> 
> On Tue, Jul 19, 2022 at 12:01:34PM +0200, Krzysztof Kozlowski wrote:
>> On 18/07/2022 17:23, Martyn Welch wrote:
>>> +	tca6424: gpio@22 {
>>> +		compatible = "ti,tca6424";
>>> +		pinctrl-names = "default";
>>> +		pinctrl-0 = <&pinctrl_tca6424>;
>>> +		reg = <0x22>;
>>
>> compatible, then reg, then all other properties. This applies everywhere.
> 
> Is this documented somewhere? It would be easier to enable new people to
> contribute, if it was.

Unfortunately it's not documented. It's a common practice - most
popular, but of course you will find other examples. There is reasoning
behind - compatible is the most important property. Reg is useful to
have at the top as it must match unit address.

> Anyway, I would add to this list status as last, when present, 

Yes, this as well in some trees is recommended/enforced although not
documented.

> and I do
> try to order alphabetically all the other properties.
Best regards,
Krzysztof