Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp4339230imw; Tue, 19 Jul 2022 04:56:58 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sjmet/a2ewwBg6kuYgwnYZoVZ9dn+ma1hc9B6FCFnNVFqdG6M5qbVJxrmlEg6aMRftA2cR X-Received: by 2002:a63:d5:0:b0:41a:58f:929e with SMTP id 204-20020a6300d5000000b0041a058f929emr12506597pga.260.1658231818198; Tue, 19 Jul 2022 04:56:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658231818; cv=none; d=google.com; s=arc-20160816; b=BehUfYVSde18YohrnFfhYbO9dayi6ac7AnOuX7nVyhpjNZG/79G9oXd65eBnVQIOeF GGE+Dv48tdFRzK66YhHqe2uVLn5f7/HAUP/gZrAIIEpnwkkMsQ4lzvRVY1csaCtX0Fvl uW31mt+Kv3stzuvKpIu8r/rr6o/i7NoGrsu1Y4t6D2dmUnycexvKJBmfURwls2NkuIts qSB48OEAbBdEB5HAr+OjId40leDXEYmIhXzEvcrh3bNcIHRSvuk0IZR0wLCoK+iuaoqV PjvOraCKxtaLAzDr0LiYKL1H0PK7UXoAN7ZRZhg+pp7i2LNyIFrQCmPuNnxgqU+M8RAN D/FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=2QtaEebb33QAnNGR3maPW67cVEqrTx/qayao3uGwdSw=; b=f6Zh5bIlOwniuY1ZOf4dx2lTHVm0+xfCdkvRicRo0ZtDFwOYSkB5S6jQcZxmcA0UCj Be1SJ54ySyYfsI9N8H16C0F/FKxnTpe53qLlPlDPTap5lbgQOYd8391kTbB/5QA5xLSz mPNs1TmMNq8vCG/l++UGl37aAPWKN0r5CzQTLwCT9ziOj5yvSpuCRgJsbGo7FHbQft8J a2dauIkwFCbM8nstUbQuE6JzlTCliGAewjnMhRTKU3euu9f/6c+Gq0bUkyKEbLfeTyDU htMIFCsKCiSsB5Nq/XONU1zvzQ0o5DsJyX6X2Xp43lU9JN0ag5b5osd0iSmvAj3FKa4y tivw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m10-20020a056a00080a00b005295011e4f8si7727715pfk.228.2022.07.19.04.56.43; Tue, 19 Jul 2022 04:56:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237138AbiGSLlO (ORCPT + 99 others); Tue, 19 Jul 2022 07:41:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230459AbiGSLlN (ORCPT ); Tue, 19 Jul 2022 07:41:13 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D4793F304 for ; Tue, 19 Jul 2022 04:41:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D7D2C615C9 for ; Tue, 19 Jul 2022 11:41:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2822BC341C6; Tue, 19 Jul 2022 11:41:06 +0000 (UTC) Date: Tue, 19 Jul 2022 12:41:02 +0100 From: Catalin Marinas To: Conor Dooley Cc: Paul Walmsley , Palmer Dabbelt , Palmer Dabbelt , Albert Ou , Sudeep Holla , Will Deacon , Greg Kroah-Hartman , "Rafael J . Wysocki" , Daire McNamara , Conor Dooley , Niklas Cassel , Damien Le Moal , Geert Uytterhoeven , Zong Li , Emil Renner Berthing , Jonas Hahnfeld , Guo Ren , Anup Patel , Atish Patra , Heiko Stuebner , Philipp Tomsich , Rob Herring , Marc Zyngier , Viresh Kumar , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Brice Goglin Subject: Re: [PATCH v4 1/2] arm64: topology: move store_cpu_topology() to shared code Message-ID: References: <20220715175155.3567243-1-mail@conchuod.ie> <20220715175155.3567243-2-mail@conchuod.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220715175155.3567243-2-mail@conchuod.ie> X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 15, 2022 at 06:51:55PM +0100, Conor Dooley wrote: > From: Conor Dooley > > arm64's method of defining a default cpu topology requires only minimal > changes to apply to RISC-V also. The current arm64 implementation exits > early in a uniprocessor configuration by reading MPIDR & claiming that > uniprocessor can rely on the default values. > > This is appears to be a hangover from prior to '3102bc0e6ac7 ("arm64: > topology: Stop using MPIDR for topology information")', because the > current code just assigns default values for multiprocessor systems. > > With the MPIDR references removed, store_cpu_topolgy() can be moved to > the common arch_topology code. > > CC: stable@vger.kernel.org I'd quantify how far back you want this to go. IIUC based on the Fixes tag in the other patch, it should stop at 5.4. If you send a pull request instead and have a fixed commit id, you could add it as a prerequisite on the following patch without a cc stable here. Either way: Acked-by: Catalin Marinas