Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c4c73918-edbc-8cea-329b-51be967b26ba@intel.com>
Date:   Tue, 19 Jul 2022 13:40:08 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH 1/2] lib/string_helpers: Introduce strsplit_u32()
Content-Language: en-US
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
CC:     =?UTF-8?Q?P=c3=a9ter_Ujfalusi?= <peter.ujfalusi@linux.intel.com>,
        "Andy Shevchenko" <andy@kernel.org>,
        Mark Brown <broonie@kernel.org>,
        "ALSA Development Mailing List" <alsa-devel@alsa-project.org>,
        Takashi Iwai <tiwai@suse.com>,
        Jaroslav Kysela <perex@perex.cz>,
        <amadeuszx.slawinski@linux.intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        "Kai Vehmanen" <kai.vehmanen@linux.intel.com>,
        Bard Liao <yung-chuan.liao@linux.intel.com>
References: <CAHp75VckU2ZraLJ-frjWXjUu9pFW+-XmWgTbYqUXOUNAD-1HGA@mail.gmail.com>
 <6c8e4104-2239-a188-649d-585f059cabdd@intel.com>
 <YsgjdKEtE7pMDTnZ@smile.fi.intel.com>
 <a73b3ec0-5abb-ddfd-414b-b9807f05413e@linux.intel.com>
 <CAHp75Vd4D0KF7ik+aMOwv-+bofWja_tDe4YUmihQBF+RiHZTmA@mail.gmail.com>
 <e2fe6351-f9ee-48eb-ad7f-280249f7f3f7@intel.com>
 <CAHp75VfvN-iJTpgg6JeKhOqJLhtYSieo7d7SOCBoUu-81FtSqg@mail.gmail.com>
 <c19ed4a6-6a96-b4a4-0f5a-7ca1dba925d1@intel.com>
 <YsnoH64cKCT7gndw@smile.fi.intel.com>
 <2c6a4a61-e6c8-0487-8d29-dc3fbb90bbe2@intel.com>
 <Ys2EFtNVL8ZALQ5Q@smile.fi.intel.com>
From:   Cezary Rojewski <cezary.rojewski@intel.com>
In-Reply-To: <Ys2EFtNVL8ZALQ5Q@smile.fi.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S0EyKzhEQ3RuazNZZ0V4MHMwK1dndGZCeGliQjVyeUc4dkJTVDBFNFpSdEZP?=
 =?utf-8?B?SnJyWWlENkdaQW1aUGJMajlHa0thV0lkMjJpVDlhMFZFN20zRGNqeGpvK1Aw?=
 =?utf-8?B?a1VoanJ2SWI5L0NRQldiWElVdVA4WmM2eDNiMWhVVHEvUzYycDhGRXczWC82?=
 =?utf-8?B?NzUvOU9Qb2FrUVRaWHdMQ2JadWkxTE5rTzRsbVY3WXZlVWtmdUQ1ZlB5VGpF?=
 =?utf-8?B?cWxCVFU4bTd1NTM4ZDZxU01NMnN3bjYrUkc1ZFpoa25Eam1JZGs1UjYzdnEz?=
 =?utf-8?B?ZUcrc1p6Qm05eTY4bmVyNGhBbEp6UmVFUGhWQ2R4cW1ncTRMa1BaTzBSTGRo?=
 =?utf-8?B?bHZkTzhSVlN4WTlKSlNoK2xUR0VNTkpFVFFHUVlzRDQ5WVJiOHloMzVNWkV2?=
 =?utf-8?B?REYwVWpNR1VuSi9HMU1TUmJ3ZlNINlYrTEtWS21WY2s4aW52aGxrRE42WHRH?=
 =?utf-8?B?bEg1QTZyWHZBZ2w5WlBXU3ZEUDIzMnF3YnViM3Y0TWF6V0cwakkyMHJiZkhY?=
 =?utf-8?B?U051bzNPNjQ0SmVJeXVjSmhlMW9NTEZXUFZwUld0TmU5K21UdzlINm13UXhw?=
 =?utf-8?B?ZUVVd3l2UVpFN3lRWnNHZnVTaXdVMkVJTnhIOWpLTThxN2RNNTM2emV5NFN3?=
 =?utf-8?B?SndWZnJGbjZBckdzMWZjS3NrOFlPclZ5M2pwa25mR0xsQXhwMlhydUdoMy9F?=
 =?utf-8?B?WThMK1pQeSt5SUIzYkd0KzdjOTFxRHVFaktvWHdSamdZUUNIL2JiZk1xRis4?=
 =?utf-8?B?bjFjUVdBVWxRdlpnTWRSNWpPZS9ZdmtuMHE0alAvbHVVdFJLYmo2cWZHdHgr?=
 =?utf-8?B?UlhSWGxYL1VmaUF5cUxVRUd0Y1J5alBzQzNoVzUrdDlQSFpVeHlnLzNRQTB3?=
 =?utf-8?B?bWt1QlpsLzRkK3UvWWxIMVVSNEJvQmZFWjJJRmFpMzVzS3k5b0RnZ21FWS8r?=
 =?utf-8?B?b3NrbTN6Vys3bmNDRnlWa0NzcVRCMFBseEc3dFFkdmhKMHF0YnIzeEpidmFF?=
 =?utf-8?B?TkVzU3BoaFRoWWEwenVza2EyZzBYMDA2NGFseU1GOUtnanRFODNBL2NsTUIx?=
 =?utf-8?B?OC9rVnZRYUUydmlXYXlyZmwvUlpELzFLZzYvSldVaXBDYkJuTzFFeVdmSXlE?=
 =?utf-8?B?ZElqYmNFNElZTzhicWdzN0lmNzJYWFJiTXl1Smt5d0hoRTRhK2NxWStIUFNl?=
 =?utf-8?B?NUZkVi83QklCMGpaUFdKTitnbTF2RDJ3aHd0aklNNjRTYkNRcmorVnNiUDMv?=
 =?utf-8?B?MmFZSDROZmFXK2YzWmV6L1hRcHlqdi8rVFJWYzl6UlllR1ByOWJBbXViMDBR?=
 =?utf-8?B?MVdtaXBhRXl4blZteEtrZERjczNYVlNMbktldEdDRmRrbFU3UlFmd0NVZW1Z?=
 =?utf-8?B?TXptdXFIZjFGcmpiZExrY29vNDBWSlladDlLTCtvVWlUd0gyaTlUU3JmSllp?=
 =?utf-8?B?ME9yM2pEU1VGcWE2Q05aUi9keTcrcGZhZGdyMkdYSlptTzE5YXI3c01QbzBD?=
 =?utf-8?B?amliZnREK2Q3Y1RtTkNtbnNNOWpOYjRjWTlWa2tMWnJ2byszZXNMeWJMdllu?=
 =?utf-8?B?d2k4VU51a3c0TDhZQVlGbkJaWDBxT3lsZmVxSlRKM1JzYllUMlY3dS9mU1B4?=
 =?utf-8?B?c0czT3lSK3dzRm9ncmw0d3FBZFk0N1ZzdE5YYy8vSms3b3VKbEVXM01QY1BD?=
 =?utf-8?B?UERYUW5ZNFFxZE5CK0ZlYWFvV1BNRm1TZWpoVXEwbEJtVjVNZ2huUVcvZVNp?=
 =?utf-8?B?U1NONithRnlhV3phNzAzZFNkN1JObkRtM0I4bTdVVDgvNU0rZHdQd1lpZks0?=
 =?utf-8?B?TW0yRVFwcDBQVk56Y2F4bjhSQWR2dlFaUDdjZGlhUU02ZDk2OXdJd29oaWNQ?=
 =?utf-8?B?T1hBblEySGozdlB5S09DaXF4Nk1nWk5aSVYvSXhBa3VNMFdZMWxhNmd6Z01O?=
 =?utf-8?B?clkyYkNMMWFROE9LTENoNWk5VnZHWHVsdWdlZzJpUWllSmlSQmxTZWZWdXpH?=
 =?utf-8?B?OWRpN2JtS09sbHIrVGxGdTRHMnFQUXZqcmxNOXZnazZFUm9wN2p4dVBRaDlt?=
 =?utf-8?B?b0NMZVVQMDNjS0xzSXZaeFJ3SVFPQ0FvbTdNRUdmZ1pnQTAvbVZYdmpQcVhw?=
 =?utf-8?B?SFl6dE5yTEN4SFBPRXpVeHFmaDRHdnZqNEJ5dmhXNjRySWhhcWZJb1VsTVVM?=
 =?utf-8?B?TXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e78cfb9-9664-48df-4824-08da697b72cc
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB6375.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 11:40:15.7004
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: O3uEmssJjrzuAe+uf9mwjYH30qK/pmugU/5m3out7/jZ+8+tfgqWsoL7IinCJRIZKVYTR7iQiHpn+GkUm4UqCONrOVhUJ5bX9H1fQLNqgyQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2548
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-07-12 4:24 PM, Andy Shevchenko wrote:
> On Tue, Jul 12, 2022 at 03:51:04PM +0200, Cezary Rojewski wrote:
>> On 2022-07-09 10:42 PM, Andy Shevchenko wrote:
> 
> ...
> 
>> I still believe that casting blindly is not the way to go. I did explicitly
>> ask about int vs u32, not int vs unsigned int. Please note that these values
>> are later passed to the IPC handlers, and this changes the context a bit. If
>> hw expects u32, then u32 it shall be.
> 
> What you can do is probably utilize _Generic() which will reduce the code base
> and allow to use the same template for different types.


Writing to let you know that the feedback is not ignored, just my TODO 
queue is large. Will come back once _Generic() idea is verified on my 
side or when I have more questions. Thanks once again for your input Andy!


Regards,
Czarek