Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp4450082imw; Tue, 19 Jul 2022 06:53:22 -0700 (PDT) X-Google-Smtp-Source: AGRyM1u5hivEzEFqgdiF9PHPQgjYJoHbWnpWU5T25hMp3ufqisZptNUBVWEVr4j7FNrNk6+VOhFl X-Received: by 2002:a05:6870:c0c8:b0:101:b3c3:abc3 with SMTP id e8-20020a056870c0c800b00101b3c3abc3mr17202852oad.144.1658238802286; Tue, 19 Jul 2022 06:53:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658238802; cv=none; d=google.com; s=arc-20160816; b=eJxclm8s03NpycpDuWJcgjj7UwsTlUtYGKDh9CZYjRmScO9sKg9eBxUGteXTat6aWj unoxjnYyaN43md8dBGJ7/Zm7U2W5p74JzwEAe3kp6Vze5lfu9fxw3qAUB1i/MK3cGmwH KIisT2DihyfTizY9GuTwAdPpr9YzD9EiSFX23o1Peo5XPsz1Z2kjPiPj+Smtzydh63ch yiwOxJD2vxwEA+jy2eEgRZlZnhFkXaem0iZVhs2kvFjbv6XkY/Q4sgO0KOTSjCh9+3sw KLbB/qpJ0k7fNH/gXljWox7Aja7usrAgHGtq1hMUFfbqcPxPyOi4/f/58fmbDyqMhkGe 86Vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=FOQIGXGdo+sr9DNQpN2xLlnA9n3UlS9tb37+gCxunfU=; b=CA2/x0oTK8FAL1AJMhU/vC2r/e2Oc+Wn3yxLKx3CfWxdGPDVzyoizgsq6rMFmSeVen 7aUZfIDG3kCGh+AfIthUmzeO3EjpeoGrlJFz/cbzB8fVF3iQonDpxCgHbQidStEKo9JC Uu/2IpF0TW2drdZdhLI3TyuNbNiI/RW9+wLCeFgz9+7AOkB7BOSh28TSg6JvI+Cf6je0 tvG1VqYzhZUisYEey2oWpEMKW7lKZaeaBSRu6ZOz/fM9RjGU+RAbtcbRNcDS417OkWNV uy0Iew2PS3j+qk6H3vyhlsLZEMkk/KujOJK9A/aO9/TGARNt6vDMooZkXNOluSD2uUqH IdXg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bl42-20020a05680830aa00b00339feaaca71si16479270oib.91.2022.07.19.06.53.08; Tue, 19 Jul 2022 06:53:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238136AbiGSMGw (ORCPT + 99 others); Tue, 19 Jul 2022 08:06:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238589AbiGSMEv (ORCPT ); Tue, 19 Jul 2022 08:04:51 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5893248EA5 for ; Tue, 19 Jul 2022 05:00:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D33A761697 for ; Tue, 19 Jul 2022 12:00:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2AD9BC341CA; Tue, 19 Jul 2022 12:00:48 +0000 (UTC) Date: Tue, 19 Jul 2022 13:00:44 +0100 From: Catalin Marinas To: Conor.Dooley@microchip.com Cc: paul.walmsley@sifive.com, palmer@dabbelt.com, palmer@rivosinc.com, aou@eecs.berkeley.edu, sudeep.holla@arm.com, will@kernel.org, gregkh@linuxfoundation.org, rafael@kernel.org, Daire.McNamara@microchip.com, niklas.cassel@wdc.com, damien.lemoal@opensource.wdc.com, geert@linux-m68k.org, zong.li@sifive.com, kernel@esmil.dk, hahnjo@hahnjo.de, guoren@kernel.org, anup@brainfault.org, atishp@atishpatra.org, heiko@sntech.de, philipp.tomsich@vrull.eu, robh@kernel.org, maz@kernel.org, viresh.kumar@linaro.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Brice.Goglin@inria.fr Subject: Re: [PATCH v4 1/2] arm64: topology: move store_cpu_topology() to shared code Message-ID: References: <20220715175155.3567243-1-mail@conchuod.ie> <20220715175155.3567243-2-mail@conchuod.ie> <198b0486-29e7-9729-d137-0470e93038fa@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <198b0486-29e7-9729-d137-0470e93038fa@microchip.com> X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 19, 2022 at 11:51:04AM +0000, Conor.Dooley@microchip.com wrote: > On 19/07/2022 12:41, Catalin Marinas wrote: > > On Fri, Jul 15, 2022 at 06:51:55PM +0100, Conor Dooley wrote: > >> From: Conor Dooley > >> > >> arm64's method of defining a default cpu topology requires only minimal > >> changes to apply to RISC-V also. The current arm64 implementation exits > >> early in a uniprocessor configuration by reading MPIDR & claiming that > >> uniprocessor can rely on the default values. > >> > >> This is appears to be a hangover from prior to '3102bc0e6ac7 ("arm64: > >> topology: Stop using MPIDR for topology information")', because the > >> current code just assigns default values for multiprocessor systems. > >> > >> With the MPIDR references removed, store_cpu_topolgy() can be moved to > >> the common arch_topology code. > >> > >> CC: stable@vger.kernel.org > > > > I'd quantify how far back you want this to go. IIUC based on the Fixes > > tag in the other patch, it should stop at 5.4. If you send a pull > > request instead and have a fixed commit id, you could add it as a > > prerequisite on the following patch without a cc stable here. > > I guess a PR might be the easiest way for it anyway, so that both > yourself and Palmer could merge it? I guess so, a stable branch would do. Note that Will is handling the upcoming merging window. -- Catalin