Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20220719071721.703986-1-yangyingliang@huawei.com>
References: <20220719071721.703986-1-yangyingliang@huawei.com>
Subject: Re: [PATCH -next] media: vimc: fix wrong pointer passed to PTR_ERR() in vimc_create_links()
From:   Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc:     mchehab@kernel.org, yunkec@google.com, skhan@linuxfoundation.org
To:     Yang Yingliang <yangyingliang@huawei.com>,
        linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>
Date:   Tue, 19 Jul 2022 14:00:48 +0100
Message-ID: <165823564899.2228597.7310111477254228194@Monstersaurus>
User-Agent: alot/0.10
Precedence: bulk

Hi Yang,

Quoting Yang Yingliang (2022-07-19 08:17:21)
> It should be 'ret_link' passed to PTR_ERR().
>=20
> Fixes: d534b9520a12 ("media: vimc: add ancillary lens")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>

I believe this patch is correct, and it even has a fixes tag, which is
perhaps one up on the previous one [0] from Hans, though I think he
perhaps sent that before d534b9520a12 was even pushed

But Hans' patch was sent first, so it might be ahead of the race.

[0] https://lore.kernel.org/linux-media/4fd23b1c-8a0a-1691-a4f9-526ec99bd19=
3@xs4all.nl/


But for which ever one gets chosen:

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>


> ---
>  drivers/media/test-drivers/vimc/vimc-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/media/test-drivers/vimc/vimc-core.c b/drivers/media/=
test-drivers/vimc/vimc-core.c
> index c73f91947f44..2ae7a0f11ebf 100644
> --- a/drivers/media/test-drivers/vimc/vimc-core.c
> +++ b/drivers/media/test-drivers/vimc/vimc-core.c
> @@ -211,7 +211,7 @@ static int vimc_create_links(struct vimc_device *vimc)
>                         media_create_ancillary_link(ved_primary->ent, ved=
_ancillary->ent);
> =20
>                 if (IS_ERR(ret_link)) {
> -                       ret =3D PTR_ERR(link);
> +                       ret =3D PTR_ERR(ret_link);
>                         goto err_rm_links;
>                 }
>         }
> --=20
> 2.25.1
>