Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <YtP1+MJ1tNdJA60l@zx2c4.com> <20220717200356.75060-1-Jason@zx2c4.com>
 <YtamvPvl04ByTrVp@FVFF77S0Q05N>
In-Reply-To: <YtamvPvl04ByTrVp@FVFF77S0Q05N>
From:   "Jason A. Donenfeld" <Jason@zx2c4.com>
Date:   Tue, 19 Jul 2022 14:46:31 +0200
Message-ID: <CAHmME9qTA90=GEr6h1GZh0CjS+6tpe5uuqkYoJVv79h0zd0w1w@mail.gmail.com>
Subject: Re: [PATCH v2] random: handle archrandom in plural words
To:     Mark Rutland <mark.rutland@arm.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        PowerPC <linuxppc-dev@lists.ozlabs.org>,
        linux-s390@vger.kernel.org, X86 ML <x86@kernel.org>,
        Will Deacon <will@kernel.org>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        "H . Peter Anvin" <hpa@zytor.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Borislav Petkov <bp@suse.de>,
        Heiko Carstens <hca@linux.ibm.com>,
        Johannes Berg <johannes@sipsolutions.net>,
        Harald Freudenberger <freude@linux.ibm.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Mark,

On Tue, Jul 19, 2022 at 2:42 PM Mark Rutland <mark.rutland@arm.com> wrote:
> > -static inline bool __must_check arch_get_random_long(unsigned long *v)
> > +static inline size_t __must_check arch_get_random_words(unsigned long *v, size_t words)
>
> As others have suggested, could we please s/words/longs/? That's a smaller
> change from the existing name, and avoids amibugity were "word" has an
> architecture-specific meaning. e.g. the ARM ARM (ARM DDI 0487G.b) defines:

At first I had thought, "erm, I like 'words'" but decided to wait it
out, and now it's two people with the same probably good objection to
'words', so I'll send a v+1 with 'longs' instead. Thanks for your
feedback. Patch incoming.

> FWIW, other than the naming nits, the arm64 bits look fine to me.

Oh good. Can you send an Acked-by for v+1? Coming up shortly.

Jason