Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8fc9d169-78ff-0fe4-67c0-784097861f12@collabora.com>
Date:   Tue, 19 Jul 2022 14:37:15 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH] Makefile: replace headers_install with headers for
 kselftest
Content-Language: en-US
To:     Shuah Khan <skhan@linuxfoundation.org>,
        Masahiro Yamada <masahiroy@kernel.org>,
        Michal Marek <michal.lkml@markovi.net>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Shuah Khan <shuah@kernel.org>,
        Kees Cook <keescook@chromium.org>
Cc:     Anders Roxell <anders.roxell@linaro.org>, Tim.Bird@sony.com,
        kernel@collabora.com, linux-kbuild@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
References: <a7af58feaa6ae6d3b0c8c55972a470cec62341e5.1657693952.git.guillaume.tucker@collabora.com>
 <f35a71d6-bd96-7aa9-c143-39ae88bc85d5@linuxfoundation.org>
From:   Guillaume Tucker <guillaume.tucker@collabora.com>
In-Reply-To: <f35a71d6-bd96-7aa9-c143-39ae88bc85d5@linuxfoundation.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 14/07/2022 22:45, Shuah Khan wrote:
> On 7/13/22 12:33 AM, Guillaume Tucker wrote:
>> Replace headers_install with headers as kselftest uses the header
>> files from within the kernel tree rather than from a system-wide
>> installation.
>>
>> We can still run this directly:
>>
>>    $ make O=build kselftest-all
>>
>> and when building from the selftests directory:
>>
>>    $ make O=build headers
>>    $ make O=build -C tools/testing/selftests all
>>
>> Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
>> Reported-by: Masahiro Yamada <masahiroy@kernel.org>
>> ---
>>   Makefile | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index fb2f3bb53a6b..5c934d16664c 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -1347,10 +1347,10 @@ tools/%: FORCE
>>   # Kernel selftest
>>     PHONY += kselftest
>> -kselftest: headers_install
>> +kselftest: headers
>>       $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests run_tests
>>   -kselftest-%: headers_install FORCE
>> +kselftest-%: headers FORCE
>>       $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests $*
>>     PHONY += kselftest-merge
>>
> 
> Thank you for taking care of this. This will go through kbuild?

You're welcome.

Masahiro-san,

A you OK with applying this in the kbuild tree ahead of the
upcoming merge window?

Best wishes,
Guillaume
 
> Acked-by: Shuah Khan <skhan@linuxfoundation.org>
> 
> thanks,
> -- Shuah
>