Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Pawnikar, Sumeet R" <sumeet.r.pawnikar@intel.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC:     "rafael@kernel.org" <rafael@kernel.org>,
        "srinivas.pandruvada@linux.intel.com" 
        <srinivas.pandruvada@linux.intel.com>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] powercap: RAPL: Add Power Limit4 support for Alder
 Lake-N and Raptor Lake-P
Thread-Topic: [PATCH v2] powercap: RAPL: Add Power Limit4 support for Alder
 Lake-N and Raptor Lake-P
Thread-Index: AQHYmGviOrIL5cGlF0SFn38VTAS9XK1/1uqAgAXvnpA=
Date:   Tue, 19 Jul 2022 14:33:04 +0000
Message-ID: <CY4PR1101MB2184DAE94E509EAA213001FCBB8F9@CY4PR1101MB2184.namprd11.prod.outlook.com>
References: <20220715165228.28044-1-sumeet.r.pawnikar@intel.com>
 <YtHEl73BL1BRyl9r@smile.fi.intel.com>
In-Reply-To: <YtHEl73BL1BRyl9r@smile.fi.intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.500.17
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?M4/31LKdmt+8xUMER8ZIrV+I51hsVxqHTcnbtukFrgbPPgpUU8B/uCiTZCMB?=
 =?us-ascii?Q?J35xeXIRdZLG6ggyW7jTF5gJm+iQUEY0sXWb0wPAiakc8Ecgd9l9nrZYhMcj?=
 =?us-ascii?Q?boIBVOnVTMpOwPUnZ2zdd6ZiVUcpEqZ3qXGwL7dMoaCRY9uDoh+c707lLOVc?=
 =?us-ascii?Q?/yHNCSU/57zcgYxdXrmJ+j0uRnckg5d2xxoiPqxsh0WyQmlfEsauGTTCkgrd?=
 =?us-ascii?Q?ImfUspHt99TP3mzUQc6yqqWBWTfISSnYcsT7LrjWeay2CTK+vxGUvdijgqXA?=
 =?us-ascii?Q?XFJR4Ek8LL30SCxWDlqtNdFQkMpMFvT/M6aFig1r7ZmiWWMaPNsYNvz2OOfs?=
 =?us-ascii?Q?hYTYI7Y9KIJRpADBFpFZBra673zF9RiyFaGOJnmvGz+wn9ZJ8ubzfm5pAi8P?=
 =?us-ascii?Q?j0yRTlUnfJLBkYwCAoom7EyV1QbLL1whvmgPODOrXOvGpqlR95hgjphP7DCV?=
 =?us-ascii?Q?idjBoRTvuwvXn1foHfbY86bo3v0F/VjSQYp9b4je2SM1plf2n3ubbzByNQiv?=
 =?us-ascii?Q?ROP0rkfY0nxX1RQ3JE16MvfqrTDsvioESAMDykiXrNYfve/B5Us++KmUlYXu?=
 =?us-ascii?Q?m8JnBpQRKQQQBKXZXaazkCXDjrpKAXV9j0zF8OEJ0Zm0u0keaGUv1QXB14Ne?=
 =?us-ascii?Q?4hdITCmd7BVzECbUfagM4XJuppeGv/s2HV0Rolbs+505ilM4pDOv1IkTfKgX?=
 =?us-ascii?Q?f+15uHE9vQ6b1x4LVdRvpBex8cRDUiAVHDPUhD0eZ+MNOhvu2z72hKuiGfR9?=
 =?us-ascii?Q?T1UL97M//VFya6k4366BrPP+H4eMfvW7w9/oWDJAIDWvjQ7kN6tMnjv9g7dP?=
 =?us-ascii?Q?SdzGH5uFTGNxWTbw18WHcJNKxViIiGRu22ZwHyJCw/mB0W7Jfw28Sl0Tx7U4?=
 =?us-ascii?Q?QB+/+ZP0kqh0Ov+MBckZTNH6XqgF9fF+jSO0F1HjyolKADqq2YGXRianQRWB?=
 =?us-ascii?Q?ebwtGGrWUaGI91iKLh5SrUzdyx9JrgRKPlr05VYe+gqE6SeuFP6A6EhgagEt?=
 =?us-ascii?Q?9+fxS6LMJBp+njX52b0vRkEQFBtMgFjTT4hyvpWPzQsnRDVUS/ij7SD5lN4N?=
 =?us-ascii?Q?n1MVFOlcGdC1O4/BztKNrpRNU5/RnXWWXTqYAagxVy6OG5r3aaB7XFexzj1I?=
 =?us-ascii?Q?GVfwKfOudP+M5btU6thUktOwl3czJA00574Vk6XYbBp76GK57cHL7lpTppRB?=
 =?us-ascii?Q?/jraawudMWLg1AwOjMtChpve7+/L+HsMT3YtTTth8seaqTrj6C+/T/U2Fj41?=
 =?us-ascii?Q?TTgFDx7/p+Fi84h8kBsjD1s6B6uBIWbxrrOAfbK1uQxdfBMHTnP5tbiiPLqv?=
 =?us-ascii?Q?8GduFIEIPATfVsV4N2todO1YP00gSQjv3NAWTse+aAd34IE9yzI0zNeQfqx5?=
 =?us-ascii?Q?JgHMeEUO7XUUHecB+zlXuf7d0p1tytSphRK50ARa/TRyrtcdUH9IC4uZpBcW?=
 =?us-ascii?Q?CkLFxJQdohu+pSATALE1lWMdXGepokfTiZVPjPuVb89jR66UOTUNuT1iC6ld?=
 =?us-ascii?Q?Mt8hA5+bE5fHa8vZZyqT5ZCC5BgtXrnc3gR+v53/PWlDNhZJubAZuaDgCNEl?=
 =?us-ascii?Q?GiSa6yJhftW69jSERAYuzYrPyV9tQK7MZ2/ZOVt5O9la536Yd6aZuGRPVYJg?=
 =?us-ascii?Q?mA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CY4PR1101MB2184.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 901098c4-88e3-48b1-a006-08da69939785
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2022 14:33:04.9103
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: z6pg68NTDiHhHQ28/2kI3G/FJgt03d4b4C2hEcYzVke3+7UX4I6+pAQkl2N0Goj3Lv/9zBo56hGX2nryfGgvLivQL86QfRlIb4xIwvqFKUc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2967
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Sent: Saturday, July 16, 2022 1:19 AM
> To: Pawnikar, Sumeet R <sumeet.r.pawnikar@intel.com>
> Cc: rafael@kernel.org; srinivas.pandruvada@linux.intel.com; linux-
> pm@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2] powercap: RAPL: Add Power Limit4 support for Alde=
r
> Lake-N and Raptor Lake-P
>=20
> On Fri, Jul 15, 2022 at 10:22:28PM +0530, Sumeet Pawnikar wrote:
> > Add Alder Lake-N and Raptor Lake-P to the list of processor models for
> > which Power Limit4 is supported by the Intel RAPL driver.
> >
> > Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar@intel.com>
> > Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
>=20
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>=20
> You may not convert people's review into a tag without their consent.
> But taking into account this is trivial patch, it's fine. Just follow the=
 rules next
> time.
>=20
Thanks for your time to review this.=20
Got your point. I'll follow this rule going forward.=20

> Also, where is v1? What are the differences to it?
>=20
Sorry for this confusion. Actually this is the v2 version in the internal r=
eview,
I forgot to remove the v2 prefix when submitting externally.=20
I'll resend this patch removing v2.=20

Thanks,
Sumeet.=20

> > ---
> >  drivers/powercap/intel_rapl_msr.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/powercap/intel_rapl_msr.c
> > b/drivers/powercap/intel_rapl_msr.c
> > index 9d23984d8931..bc6adda58883 100644
> > --- a/drivers/powercap/intel_rapl_msr.c
> > +++ b/drivers/powercap/intel_rapl_msr.c
> > @@ -140,7 +140,9 @@ static const struct x86_cpu_id pl4_support_ids[] =
=3D {
> >  	{ X86_VENDOR_INTEL, 6, INTEL_FAM6_TIGERLAKE_L,
> X86_FEATURE_ANY },
> >  	{ X86_VENDOR_INTEL, 6, INTEL_FAM6_ALDERLAKE,
> X86_FEATURE_ANY },
> >  	{ X86_VENDOR_INTEL, 6, INTEL_FAM6_ALDERLAKE_L,
> X86_FEATURE_ANY },
> > +	{ X86_VENDOR_INTEL, 6, INTEL_FAM6_ALDERLAKE_N,
> X86_FEATURE_ANY },
> >  	{ X86_VENDOR_INTEL, 6, INTEL_FAM6_RAPTORLAKE,
> X86_FEATURE_ANY },
> > +	{ X86_VENDOR_INTEL, 6, INTEL_FAM6_RAPTORLAKE_P,
> X86_FEATURE_ANY },
> >  	{}
> >  };
>=20
> --
> With Best Regards,
> Andy Shevchenko
>=20