Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <74bf1df3-a466-9d78-1a25-7425c89b9fa3@oracle.com>
Date:   Tue, 19 Jul 2022 10:56:07 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.0.2
Subject: Re: [PATCH v2 2/4] target: Implement TMR_ABORT_TASK_SET
Content-Language: en-US
To:     Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
        linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
        target-devel@vger.kernel.org,
        "Martin K. Petersen" <martin.petersen@oracle.com>
Cc:     John Youn <John.Youn@synopsys.com>, linux-usb@vger.kernel.org
References: <cover.1658195608.git.Thinh.Nguyen@synopsys.com>
 <7d31722a7e07bc24ea37b5841a17545003eeddb4.1658195608.git.Thinh.Nguyen@synopsys.com>
From:   Mike Christie <michael.christie@oracle.com>
In-Reply-To: <7d31722a7e07bc24ea37b5841a17545003eeddb4.1658195608.git.Thinh.Nguyen@synopsys.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RFJwQ3d3TmlXclhKL2M1UTNXL1MwZTdpWU5QQ0tFZDNkM3ZpZVU1UDk1ZWFZ?=
 =?utf-8?B?Wi9NWjQrQ0pmQW0rQnFoSm9pc0g3Vkxtbkd1YnkrN3dhZUFVWHpLc09ZS0Nq?=
 =?utf-8?B?SHl2QmZGR21Ed1J5cEpOeGRNb0dJNlY2UjhQMGtaSkE1NlRPaXdodlFndita?=
 =?utf-8?B?cXBSREZ1SSthN1ZDV2ZwVW1HRUV5dWxoSHpGTG5DOTZXRVdDb1pEM0xJcllk?=
 =?utf-8?B?Vk5HbmZZTDZSdUU2N3dnV3Zmb1d4M2VIdWJsVmRRQUNMQTUvaVFGOFhlRWJp?=
 =?utf-8?B?V25ZQ3JRckQwWHdaSHI3M2d4aWxhNFIyTnQ0SUc0dkxwRE9oYTVKam1ETU0w?=
 =?utf-8?B?K3lGc21vU2R6OFNOTUNVeEljSzhUSHBFYUhUK0dSOVBEQjU0TVBEMGpURWd3?=
 =?utf-8?B?QThpZm5KV0YyS2NZREZ3MUlCb1ZIMXFwaWF0d3hqaHVtYkZSWUl3WnV4V25j?=
 =?utf-8?B?SlQ4cm9LZVFQQVJnbHc0bW1CbnFxblQyanFsaEx1bVdsZThGYVZSVEhHQlVy?=
 =?utf-8?B?SXpMOU9pa2FQZUcxSWlCRTZGVDBsQWgwL0E4dXQ4WHlhbzc4Zy9hZklxUXcv?=
 =?utf-8?B?K201RTVoclh3WEVCMWpzTWozMzJDeFVhNjRmUjlKUzN1ekZmK1BvNUo3ek5X?=
 =?utf-8?B?Tm5uRUJnVjdWMjdEOVVRWnM0dFlpK3N0b09WR3l4OTNaU2F5bnNYRG9RZnhV?=
 =?utf-8?B?RFA5cldTd2EvN3BRYkQxRXNuU1hZTk9tY04yWW56Zkk5VlVRK3hOZ0krUWZk?=
 =?utf-8?B?MHdQWVZDWEdCUFB1ZFVMbW8rTkFHOWVIVVR3UTRQYWcvcDFLUG9tM3pQNEFp?=
 =?utf-8?B?L0xpVW5WZDV6bUpXSHM0eERsRU1UaDl4YzlITTQ0YzVsSzZMS1hORHl4bUxk?=
 =?utf-8?B?UDJUa3RiSVI3c2MyajRiOVRHMitFMmtXN3FjMzl4eGZTUnh6eEpoN1Yzd1lz?=
 =?utf-8?B?R0xwTXRpeG5NU28wZkFCSEFlam9zWHZlR2R5dVoxcXIvMWVyUHVvUW05Y2lI?=
 =?utf-8?B?N21RcG9TZWcwUGxHOUx4K3JhOHkzVklkWS8vY2hQR3RVU3lDbVBjSmY0VHMz?=
 =?utf-8?B?VHM0QU9USk1qSnNZRXlCV00vT0dRQ0hvQVhnZ2UrZUtYU1U1SEIwZHFuenJT?=
 =?utf-8?B?eG9LOERkY3JGYU9ZUmdBWisrRnROV09OaytIMmh0UHNkU0Zxd3BJeVBGa2FR?=
 =?utf-8?B?bXhQcGhvL2xFQmdTMTBQN21YY0hTSHJLcWozbGVHR2ZUWVFDTlBnNUNZN2dB?=
 =?utf-8?B?dTFGZ0puVFJKSzdpSU10MXFPOGJkMW42RzhQZzI4RG5nQU91WjJZQkxLcHdK?=
 =?utf-8?B?VXhrbStiRnFEWlYrQVk3MFJxVytjSmlHYnc1NTNRZGZIdmxmamdObXR5YWox?=
 =?utf-8?B?THZ3SHl3VWNUM2UrUUk5VXVJcHNlSnZhd2dCNFVDNHEzOTR0TnY1MVR4Ymdl?=
 =?utf-8?B?ZWU5bW91dE5SUG1SS3FiMXRqNFVIeTlFZFA3SGF6LzM4M0tHck9CVkc3dE9V?=
 =?utf-8?B?Z05jbDZMaWUwMldCNWFsYUF5MDFNZG1JOUx4eCtJRWVYZXdSVk5qNnhXaTA4?=
 =?utf-8?B?dGprdDdkTVVzaEcvT1ZmOEFrK3JoRUZVZHJUSXNlN3ZRZm52WGFtb1RyUEUy?=
 =?utf-8?B?QWIwVURNRFpkb00vVVpzQXRxQVdSdmcweU1JcTAvVmVsLzNOUHhPZWpGYVMv?=
 =?utf-8?B?QytOT3Y2WDZYSEtDOHQwUUdBcHVJRGpRUFRBa2tMbytXRkpwUERPUlo2cGwx?=
 =?utf-8?B?OGRMek1WbGlWMTlUZjUxVmpZVmpaVTVXSk5BMDFycDRoK254bUFFNUxkK2oy?=
 =?utf-8?B?cUFwenEvMzMrbkFXZVRsalkrYXNiVW9XOTY2ZU9DK05iSzJSOUo1Tjg4VmtH?=
 =?utf-8?B?UmgvZFN4QmxGbzBUaGp1V1ZOYVZZbzJWQUMrQXEzZGNxYWJKSldtbnhyQVJQ?=
 =?utf-8?B?QzNlZ1FrajRhSG5pK0U2cjJoVzFOMVNXQkJNa2Jhc3cwVDJoWW1uQWZhNlFY?=
 =?utf-8?B?bG5FN3RhSDJsNGpBZ0FQNlJHK080TktlRks3Sk1HMk8yUlhTZWp0YlB2UHpy?=
 =?utf-8?B?dXMzM0l1QkRwWkpRdjBpamRBTFlzNEtFZ3R4WVJFNjJ3dDR5c0dyc3FXNWlF?=
 =?utf-8?B?a1kvenIxYVE1SUlOVnlJbDN4Y3Bqa0p5NFhSMEVsYlVsakMyVW4vTHYzbzZO?=
 =?utf-8?B?VEE9PQ==?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9ca06823-bf6e-40b1-5ad3-08da699f329c
X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 15:56:09.7264
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1ZAGb5SqVjnJLfvUcT4QYPNtwc6Y0BxSTQyTcw2ZaJNpuQGUYXRtVjb6pUxJDBZJQQntxgSRaTfFYREBQsuElnSnPJnu9ETdMQFUVfMpgv4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5316
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-19_04,2022-07-19_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0
 mlxlogscore=999 malwarescore=0 adultscore=0 mlxscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2207190066
X-Proofpoint-GUID: hefh56ZjOhaHpjLG5N-iHKM6COdd9qv1
X-Proofpoint-ORIG-GUID: hefh56ZjOhaHpjLG5N-iHKM6COdd9qv1
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/18/22 9:07 PM, Thinh Nguyen wrote:
> Task ABORT TASK SET function is required by SCSI transport protocol

What OS is using this and how do they use it? For the latter, does the
OS try an abort for each cmd first, then try an abort task set if the
aborts fail (does fail mean get a response that indicates failure and
also does a timeout count)? Or does it start with the abort task set?

I'm asking because it looks like if it does an abort first, then the
abort task set will always return TMR_TASK_DOES_NOT_EXIST. For the abort
we will remove the cmds from the state_list so if the abort task set runs
after the initiator has tried to abort all the commands it will never
find any.

> standards (SAM-4 r14 section 7.3). It is similar to ABORT TASK
> function, but it applies to all commands received on a specified I_T
> nexus rather than a specific referenced command. Modify
> core_tmr_abort_task() to support TMR_ABORT_TASK_SET.
>