Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <abd2e9affdc3e4001f9fc6f036516ddfa6654bdd.camel@collabora.com>
Subject: Re: [PATCH] arm64: dts: Add device trees for MSC SM2S-IMX8PLUS SoM
 and carrier board
From:   Martyn Welch <martyn.welch@collabora.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>
Cc:     devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, kernel@collabora.com
Date:   Tue, 19 Jul 2022 17:37:48 +0100
In-Reply-To: <4473378f-1c14-3ec7-5380-12f49f3b1e3b@linaro.org>
References: <20220718152310.1937899-1-martyn.welch@collabora.com>
         <4473378f-1c14-3ec7-5380-12f49f3b1e3b@linaro.org>
Organization: Collabora Ltd.
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.2-1 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2022-07-19 at 12:01 +0200, Krzysztof Kozlowski wrote:
> On 18/07/2022 17:23, Martyn Welch wrote:
> > Add device trees for one of a number of MSCs variants of the SM2S-
> > IMX8PLUS
> > system on module along with the compatible SM2S-SK-AL-EP1 carrier
> > board.
> > As the name suggests, this family of SoMs use the NXP i.MX8MP SoC
> > and
> > provide the SMARC module interface.
> >=20
> > Signed-off-by: Martyn Welch <martyn.welch@collabora.com>
>=20
> Use subject prefix matching subsystem. I expect other folks in
> Collabora
> help you in that, so you do not need our advices for such trivial
> stuff. :)
>=20

Hi Krzysztof,

Thanks for the review.

I picked that based on the last 20-30 commits under
arch/arm64/boot/dts/. Would you prefer something starting "arm64: dts:
freescale: "? I see that "arm64: dts: imx8mp: " is typically being used
for changes to the more generic imx8mp device trees...

> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0extcon_usb0: extcon_usb0 {
>=20
> No underscores, extcon is Linux term, so use node name describing
> device.
>=20

I note that the device binding file lists an example using
"extcon_usb1". I also note that existing users seem to broadly use a
variation of "extcon-XXXX", would "extcon-usb0" be acceptable in this
case?

>=20
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0dsi_lvds_bridge: sn65dsi84@2=
d {
>=20
> Node names should be generic.
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-device=
tree-basics.html#generic-names-recommendation
>=20

My apologies - I thought I'd got all of these...


>=20
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0qspi_flash: qspi_flash@0 {
>=20
> You didn't test the bindings (dtbs_check), did you? There is no way
> this
> passess...
>=20

No, despite having written device tree bindings on and off for
something approaching 18 years (though admittedly more off than on), I
was unaware of this tool. I'll run this before resubmitting.

> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0reg =3D <0>;
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0#address-cells =3D <1>;
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0#size-cells =3D <1>;
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0compatible =3D "jedec,spi-nor";
>=20
> Eh? Now compatible in the middle? Sorry, this are trivial code
> quality
> comments. Please use internal review or base your work on some
> upstreamed existing board.
>=20

Sorry - I missed that one. I'd moved most of the compatible strings to
the top of nodes.

Martyn

> Best regards,
> Krzysztof