Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp4713979imw; Tue, 19 Jul 2022 11:45:48 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sRiopmXMwCQSviqxFLpFhXUD1WMlyxTqypfyMRIUdr+phEacDWbEMCeACOuwha05ZuYRO5 X-Received: by 2002:a05:6402:2391:b0:43a:7ecd:5a63 with SMTP id j17-20020a056402239100b0043a7ecd5a63mr45813170eda.235.1658256347783; Tue, 19 Jul 2022 11:45:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658256347; cv=none; d=google.com; s=arc-20160816; b=qmk5v71sbog/ytC3mDfHiqGHxAAWdLO4ROlcGmdwwSP8+BLIcR4UDgBgIlxX7JCVpI JwvJmLMbxH/4ejIf1Wi5sVfwTrni/cQXDbWaDki8d0a5JYqFxLH1Qbp/1iwq0Y2HrO6e pTZViz/bIiEl6n6iKlmctHp1CWUusP/n2bT3sgJUhyCQN7jy5gDZuD3+A0/oitwtEpjS MgdUbNA1Tp+gwHuWG06mGI/JdsH5MG0fwBYemJzWtyHzTozd5LhCZzW3haFpSMq5WE3S 9m64DKjGSxz7j4w6iAD2sgfuYTlCyfRk6jSIPGAMzsCJDX9Z4E/cn4IHVAyKpv0CFOOp rdTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=TCPtVFo6W7gsG255gByTzD9cmMYdkzVLisZ1jUolQL0=; b=TFe4qhePIUIXCvsOqt11jOeC0TRYVq4sy3l7yJ7nRqphW6g245TIgK4sU8yaKy9VHd Cz3Vv+CPbH8rY/spVze9imDbfbGyPn/dQ9DwhunNjfaCD3PHJ/XsZN9Wg10jkqH9jAbY mSCptA0z0eubTrbku1kXKjAc/JsnwPQO7+uOtxyzeqwb4MA4c45d+UPKhxeskDj4GmBS TZq9EVKybSLV6QMQvjOAaPraesLpOYNpvShgKLNdj7rnZgwKA7GPbQlyH7RhqBXr9nMV rnya2zuaU/hNduWB27bphoOjyYXaY6KbutfH11SlVxOGxAgfxh0szemxLwFAroRteKk6 Mqrg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dr9-20020a170907720900b0072a9d2d2d37si20775645ejc.116.2022.07.19.11.45.21; Tue, 19 Jul 2022 11:45:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234706AbiGSSjp (ORCPT + 99 others); Tue, 19 Jul 2022 14:39:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232193AbiGSSjo (ORCPT ); Tue, 19 Jul 2022 14:39:44 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF5745A143; Tue, 19 Jul 2022 11:39:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 14FEDCE1D86; Tue, 19 Jul 2022 18:39:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7EB55C341C6; Tue, 19 Jul 2022 18:39:39 +0000 (UTC) Date: Tue, 19 Jul 2022 14:39:37 -0400 From: Steven Rostedt To: Song Liu Cc: , , , , , Subject: Re: [PATCH v4 bpf-next 2/4] ftrace: allow IPMODIFY and DIRECT ops on the same function Message-ID: <20220719143937.4ff4b167@gandalf.local.home> In-Reply-To: <20220719142856.7d87ea6d@gandalf.local.home> References: <20220718055449.3960512-1-song@kernel.org> <20220718055449.3960512-3-song@kernel.org> <20220719142856.7d87ea6d@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 19 Jul 2022 14:28:56 -0400 Steven Rostedt wrote: > > + /* Cannot have two ipmodify on same rec */ > > + if (is_ipmodify) > > + goto rollback; > > + > > I might add a > > FTRACE_WARN_ON(rec->flags & > FTRACE_FL_DIRECT); Bah, my email client line wrapped this. It was suppose to be: FTRACE_WARN_ON(rec->flags & FTRACE_FL_DIRECT); Just so you don't think I wanted that initial formatting ;-) -- Steve > > Just to be safe. > > That is, if this is true, we are adding a new direct function to a record > that already has one.