Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <81241d70-7952-2f55-9181-d18679068998@collabora.com>
Date:   Tue, 19 Jul 2022 19:31:46 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH] Makefile: replace headers_install with headers for
 kselftest
Content-Language: en-US
To:     Masahiro Yamada <masahiroy@kernel.org>,
        Shuah Khan <skhan@linuxfoundation.org>
Cc:     Michal Marek <michal.lkml@markovi.net>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Shuah Khan <shuah@kernel.org>,
        Kees Cook <keescook@chromium.org>,
        Anders Roxell <anders.roxell@linaro.org>,
        Tim Bird <Tim.Bird@sony.com>, kernel@collabora.com,
        Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>
References: <a7af58feaa6ae6d3b0c8c55972a470cec62341e5.1657693952.git.guillaume.tucker@collabora.com>
 <f35a71d6-bd96-7aa9-c143-39ae88bc85d5@linuxfoundation.org>
 <8fc9d169-78ff-0fe4-67c0-784097861f12@collabora.com>
 <CAK7LNAQ4iMBwu4bOmmOrMudNH49ruz-7AK_H3-ceTixd=G+brQ@mail.gmail.com>
From:   Guillaume Tucker <guillaume.tucker@collabora.com>
In-Reply-To: <CAK7LNAQ4iMBwu4bOmmOrMudNH49ruz-7AK_H3-ceTixd=G+brQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 19/07/2022 17:06, Masahiro Yamada wrote:
> On Tue, Jul 19, 2022 at 9:37 PM Guillaume Tucker
> <guillaume.tucker@collabora.com> wrote:
>>
>> On 14/07/2022 22:45, Shuah Khan wrote:
>>> On 7/13/22 12:33 AM, Guillaume Tucker wrote:
>>>> Replace headers_install with headers as kselftest uses the header
>>>> files from within the kernel tree rather than from a system-wide
>>>> installation.
>>>>
>>>> We can still run this directly:
>>>>
>>>>    $ make O=build kselftest-all
>>>>
>>>> and when building from the selftests directory:
>>>>
>>>>    $ make O=build headers
>>>>    $ make O=build -C tools/testing/selftests all
>>>>
>>>> Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
>>>> Reported-by: Masahiro Yamada <masahiroy@kernel.org>
>>>> ---
>>>>   Makefile | 4 ++--
>>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/Makefile b/Makefile
>>>> index fb2f3bb53a6b..5c934d16664c 100644
>>>> --- a/Makefile
>>>> +++ b/Makefile
>>>> @@ -1347,10 +1347,10 @@ tools/%: FORCE
>>>>   # Kernel selftest
>>>>     PHONY += kselftest
>>>> -kselftest: headers_install
>>>> +kselftest: headers
>>>>       $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests run_tests
>>>>   -kselftest-%: headers_install FORCE
>>>> +kselftest-%: headers FORCE
>>>>       $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests $*
>>>>     PHONY += kselftest-merge
>>>>
>>>
>>> Thank you for taking care of this. This will go through kbuild?
>>
>> You're welcome.
>>
>> Masahiro-san,
>>
>> A you OK with applying this in the kbuild tree ahead of the
>> upcoming merge window?
> 
> 
> No.
> 
> This is a fix-up patch on top of the previous one [1],
> which  was applied to the kselftest tree.
> 
> This cannot apply to the kbuild tree.

OK thank you for confirming.

Shuah, I guess you're happy to apply it to the kselftest tree
instead then?

Guillaume

> [1]: https://lore.kernel.org/linux-kbuild/168ede35-12e0-c535-9d94-23b65a1beb28@collabora.com/T/#mb8ec7004f7c9b89fbb50c19022760e19701af7f6
> 
> 
> 
> 
> 
> 
>> Best wishes,
>> Guillaume
>>
>>> Acked-by: Shuah Khan <skhan@linuxfoundation.org>
>>>
>>> thanks,
>>> -- Shuah
>>>
> 
> 
>