Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 19 Jul 2022 12:50:56 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Jonathan Cameron <Jonathan.Cameron@huawei.com>
CC:     Dan Williams <dan.j.williams@intel.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "Li, Ming" <ming4.li@intel.com>,
        Bjorn Helgaas <helgaas@kernel.org>,
        Matthew Wilcox <willy@infradead.org>,
        Lukas Wunner <lukas@wunner.de>,
        Alison Schofield <alison.schofield@intel.com>,
        "Vishal Verma" <vishal.l.verma@intel.com>,
        Dave Jiang <dave.jiang@intel.com>,
        "Ben Widawsky" <bwidawsk@kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
        <linux-pci@vger.kernel.org>
Subject: Re: [PATCH V14 3/7] PCI/DOE: Add DOE mailbox support functions
Message-ID: <YtcLIAIlSKQpzysl@iweiny-desk3>
References: <20220715030424.462963-1-ira.weiny@intel.com>
 <20220715030424.462963-4-ira.weiny@intel.com>
 <20220719173553.000067c6@Huawei.com>
 <YtcC9qYo1lOGZ/83@iweiny-desk3>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <YtcC9qYo1lOGZ/83@iweiny-desk3>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0ZGCaXGdjk6k/PcvvSRK1nkSUIZCNkM/ZeVKYE2R4yfwVy2gMTuen/26axCA?=
 =?us-ascii?Q?f+B6/0IYXkAu81Mm4qFgsapGKevVOvtU/ajcGCwd8wE2ej6hVvJqIz9FN97f?=
 =?us-ascii?Q?YD5Svo8Sh2oa/CbrHUoY9UM4AikQMFvSSx/D2qXsLGVz8kOtmzRJVCbUTDq9?=
 =?us-ascii?Q?JsuADgbQuKU4vCHmgsaIxgzzykrY1Ktyza3y0ptN2MYNGvVkfpSXkN/IM2Wh?=
 =?us-ascii?Q?XpRhbMx++slA4amIfRB/3WM6uF7n+0IdRzQ6Dni5/3SLiqdPHjm8Jp/vLUoL?=
 =?us-ascii?Q?IbJ/U+w5VO/IVvC4RndDuGnOGK1WpMJ56gk99Hdt8OFaxHyBUdvPQsbyRb2p?=
 =?us-ascii?Q?kSfFGfz3wBDzI6nQD5U/vb2Mj31TD70lRz9Ja8krxeslVOSKDvP+eBZNVF3z?=
 =?us-ascii?Q?coNMAH41gwYvE7w1+DWcC4d4SVnAKe7bOHSQVdviqznq+WU3485F8Tlj3qXO?=
 =?us-ascii?Q?6b2CBfhZ0eNcR078Vj5J+t2rFWF7/typdMQr+kHOPpLI5qwVmdeujTHgsTLD?=
 =?us-ascii?Q?N0ulyGmcvlgCyBhrE0mAwy6Yq9SZF+dMe2S71r42CnEn0YxJQE25WD6j6P9+?=
 =?us-ascii?Q?MyTXGP6TGa0fi4V6MHuReCQvJ+RHngRfQQiQ2XCOz78pVOfHZbAOaB6dcLS3?=
 =?us-ascii?Q?RvcG2Glge8hqrnkIsiW62pg5n7jTmaQvdlqHO1ajqf2gbY8P2Cb0Za5+o03O?=
 =?us-ascii?Q?gkBEpw4CEaQDZWcXwl2PHwFECrFTCsuAwvd2JKJZwNFyDfBdTr/CCPPqhLYI?=
 =?us-ascii?Q?yqNeRPCcAR3W20p4fmpUcXSvm7AYnU2GTQCIb6N/NcT2VhxJX/DN2Chrfiww?=
 =?us-ascii?Q?njPLrZZRGfDwR0o6DEeuJn0mScMkaNK2owhr2TCTKSvzKFYG0tB4NgB3wchp?=
 =?us-ascii?Q?pO6OTaarQxzCtR+I6N13mDFiIFs+m4yemzOF9PPtf3cXhyJtSW4cbpA1y46D?=
 =?us-ascii?Q?7c9ugXT5vIPtAoI6cEo81WEhgpLdlDwDwWbBl10kUmU5WqSBBzE2A5PRd9Gm?=
 =?us-ascii?Q?2SpmXrrQjgOziMLSxufmiqhAB8TdUBDCZL2EbfJu/fuClcpZ098sVTqUvgtn?=
 =?us-ascii?Q?DCK8cJPZvcHQUmmelt2W3ch+i6onqS0EF6E0ZKPuYM/GmtnUAo/0DDR7BwwT?=
 =?us-ascii?Q?3E79WR4TELbR8M19EVEfRdzjbx6hFrR6hGUNQvd6L+PtEvRhiHkjJnK/g4iP?=
 =?us-ascii?Q?/oerpwKuixwncfQqYTAF1Qmpnyqx1w+YeBUe9iLi9HYWyGwZIedZR6zNZcpW?=
 =?us-ascii?Q?5sxx21/mX5sq05eTGH1DT7JKMjygG/bs68xUzwy9p6baZe8nU6VVtjEx/egi?=
 =?us-ascii?Q?fQbuqbOfjgcVkFvu/S93xRuFFhUleRuW6LLxwwEy6RLs+jHkcm6xIDIjodd/?=
 =?us-ascii?Q?zYTVXT3Pu16Gq3FCCiXrM4c0zoa6VAwGJPKtMh4ckY4yN01tZVagXGZumF05?=
 =?us-ascii?Q?PqEUH+oRG927khsR5HdgzH/NQVqsUft3gW9/Hs/B/0qgIaSR0qy2oNiKBCr4?=
 =?us-ascii?Q?/ITpz+5RBaZAdOTilsn6Z6t+NIh3Bp5Ca77vjKL1yxptCm9RqK0b480dvlAH?=
 =?us-ascii?Q?3AQWyAx2brnGn4CqbzngP9niHliamJ7A8lw3Uo9C?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c4f69d8-bfd1-4781-df04-08da69c00278
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6311.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 19:51:02.3709
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Tn+MLdVSDyc8Bv3h6XPaRZiBmN6Yr/mY+bUqyCHu/6Fura7yhqykvnTchqABGM60jEfGda5CqksqpC3etPv7BQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4648
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jul 19, 2022 at 12:16:06PM -0700, Ira wrote:
> On Tue, Jul 19, 2022 at 05:35:53PM +0100, Jonathan Cameron wrote:
[snip]

> > Hi Ira,
> > 
> > Thanks for persisting with this!
> > 
> > So, I think this works, but there is at least one 'sleep' I can't
> > see a purpose for.  I think it's just a left over from refactoring.
> > 
> > A few other more trivial things inline.

[snip]

> > > +
> > > +#define PCI_DOE_BUSY_MAX_RETRIES 16
> > Left over from removed code.
> 
> I think Dan may have taken these.  If so I'll send a clean up.  If not I can
> spin.  Let me check.

I'm spinning a v15 of this patch.

[snip]

> 
> > 
> > > +	if (rc) {
> > > +		/*
> > > +		 * The specification does not provide any guidance on how to
> > > +		 * resolve conflicting requests from other entities.
> > > +		 * Furthermore, it is likely that busy will not be detected
> > > +		 * most of the time.  Flag any detection of status busy with an
> > > +		 * error.
> > > +		 */
> > > +		if (rc == -EBUSY)
> > > +			dev_err_ratelimited(&pdev->dev, "[%x] busy detected; another entity is sending conflicting requests\n",
> > > +					    offset);
> > > +		signal_task_abort(task, rc);
> > > +		return;
> > > +	}
> > > +
> > > +	timeout_jiffies = jiffies + PCI_DOE_TIMEOUT;
> > > +	rc = pci_doe_wait(doe_mb, PCI_DOE_POLL_INTERVAL);
> > 
> > What's this particular wait for?  I think you can just move directly to checking
> > if the response is ready.
> 
> We could but I assume it will take at least some time to process the request.
> So it seemed best to wait and then check.
> 
> But of course we all know that also used to wait for an IRQ as an option.  :-/
> 
> I'm really on the fence here because I don't think it really matters.  We are
> sleeping so it does not really affect the system much and this is not a
> performance path.  If we were spinning I would agree with you.

I've deferred to your expertise here and removed the extra wait.

Ira