Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 19 Jul 2022 22:03:17 +0200
From:   Horatiu Vultur - M31836 <Horatiu.Vultur@microchip.com>
To:     Claudiu Beznea - M18063 <Claudiu.Beznea@microchip.com>
CC:     "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        Nicolas Ferre - M43238 <Nicolas.Ferre@microchip.com>,
        UNGLinuxDriver <UNGLinuxDriver@microchip.com>,
        "maxime.chevallier@bootlin.com" <maxime.chevallier@bootlin.com>
Subject: Re: [PATCH 2/3] ARM: dts: lan966x: Disable can0 on pcb8291
Message-ID: <20220719200317.m6cynb3l7wneuxoy@soft-dev3-1.localhost>
References: <20220718212921.1506984-1-horatiu.vultur@microchip.com>
 <20220718212921.1506984-3-horatiu.vultur@microchip.com>
 <530ef4f3-26ce-5a90-f2f7-d6163124bfec@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <530ef4f3-26ce-5a90-f2f7-d6163124bfec@microchip.com>
Precedence: bulk

The 07/19/2022 07:55, Claudiu Beznea - M18063 wrote:
> On 19.07.2022 00:29, Horatiu Vultur wrote:
> > On pcb8291, can0 and the network driver share some of the GPIOs so only
> > 1 device can be active. Therefore disable can0 as we want to enable the
> > network driver.
> > 
> > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> > ---
> >  arch/arm/boot/dts/lan966x-pcb8291.dts | 12 ------------
> >  1 file changed, 12 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts b/arch/arm/boot/dts/lan966x-pcb8291.dts
> > index 02fbf7371a8d..2cb532aa33f0 100644
> > --- a/arch/arm/boot/dts/lan966x-pcb8291.dts
> > +++ b/arch/arm/boot/dts/lan966x-pcb8291.dts
> > @@ -30,18 +30,6 @@ fc3_b_pins: fc3-b-pins {
> >  		pins = "GPIO_52", "GPIO_53";
> >  		function = "fc3_b";
> >  	};
> > -
> > -	can0_b_pins:  can0-b-pins {
> > -		/* RX, TX */
> > -		pins = "GPIO_35", "GPIO_36";
> > -		function = "can0_b";
> > -	};
> > -};
> > -
> > -&can0 {
> > -	pinctrl-0 = <&can0_b_pins>;
> > -	pinctrl-names = "default";
> > -	status = "okay";
> 
> You can just delete the status line here or change it to "disabled" and
> leave the rest for reference. For evaluation one could just enable it here
> afterwards. On the other AT91 specific boards we are using status =
> "disabled"; and a short comment after like this:
> 
> 	status = "disabled"; /* Conflict with gmac0. */

That is a great idea. Yes I will do that.

> 
> >  };
> >  
> >  &flx3 {
> 

-- 
/Horatiu