Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp4810983imw; Tue, 19 Jul 2022 13:48:17 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uSlDWh1obFUnkni0uOaflvikdWPt257wKAXQTPVE5WXmmAMg84onw6pcg2cTQdf6N+MHw0 X-Received: by 2002:a17:902:d501:b0:16c:679e:51a1 with SMTP id b1-20020a170902d50100b0016c679e51a1mr34417940plg.140.1658263697078; Tue, 19 Jul 2022 13:48:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658263697; cv=none; d=google.com; s=arc-20160816; b=xsmNVrMZvMI/GIZUpMOjGtOglPElzGDamRjh4Jscn5QkrbzXcBFo/KU0t81YUrWnxb QGy1DHgQHx8TlVTUNafjblKlu/xdLeRQBMPVUvTyycchiX+1UdgOUzm8VMzIztJQ/Pzc 4CZAvVS6e2eG/zA5j2frUs+2gj0o3E0i0RVH4VPT+FtIh66fiRisnee1cQlbLGGyLLWu 5Gspb8PFibjkUlLr+CriMF93rW+dxGQ0nlzinhNtnIPXQMQaUBgec8v6dQIlFinPeioV I19MAJpWyZeu9iL4BJPqvJg0pZ+L1mfoQoqPGFHHYBx2mLKpMRzp8OM5G6TNRebDVtAp Gwjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=H27rbR89ivxhoPN9SHt8mlMUbNk6qDGpdpqFGM7asNA=; b=mzz3YPhW3zYU8eHcIYjG3ApEl5bOAGIqyWLA9an/55DQwqDNy4ew+vJBbZCNOXMXja 31jKi/W/ceTTp1mr2GvNJ96PVc183+A7i8o4jPQRNPua+N+HC9L9YJI4jStUoXBQTvz0 BAPT/WVMU2KMccvwOrfUfjvTS2uPAZT+CBPCPwpgpITEoFlo8namK3ndNyxGVCt8oWyo /Drp94E69i03MtBbBxukENqde2wJkC+JMExNW0eK59FtDMiVo42IaMtB90M+uJQaxk+g WQ+1JlL7umgxE9PGpIJ2e44Hm/HYcVAuaqG3cxFgw7RhLvneRMrUXZEIWwiMS8Jbzc39 T9+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Q3RWjWSI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d19-20020a056a0024d300b0052ae8304b77si23694712pfv.320.2022.07.19.13.48.02; Tue, 19 Jul 2022 13:48:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Q3RWjWSI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236749AbiGSUmB (ORCPT + 99 others); Tue, 19 Jul 2022 16:42:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237335AbiGSUl7 (ORCPT ); Tue, 19 Jul 2022 16:41:59 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A78A453D0E; Tue, 19 Jul 2022 13:41:58 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6BE7AB81D3D; Tue, 19 Jul 2022 20:41:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8A39C341C6; Tue, 19 Jul 2022 20:41:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658263316; bh=ASqW0sMhLeHSDmcyye21xbAuTqb+hfjpCgPOwiNXB7M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Q3RWjWSIvQbq52mnSYBCzUjNm+UQR7+937YNxLoLppxnXVn4mSYz3ZIkvS4r0TYDe HmzRFWrdHIkacoMwhS0mRnj11GEy8ZPObzXoDatX7iODVBuYOIfLrO3mSTXL++dX3m hZT6b0ANga6qIhjNNEoYWbDzFyApUp0MoRzJyJr7Gp89kVweM3Fg1NPkEtpVR7Qf0N n5dz7X+bG7US2uBnFz6g7vL/Fw9TOFLIXzsxJX6eQEY1f4rV6EW1QFNBq9n0R6X1U3 euieXm5LP5EVtRmmFSPYQ8TJCGumzetJGRqvvm8iJqxEfLCnoEobuquTelqqoguZvA WsFdhKFYm9KZA== Date: Tue, 19 Jul 2022 13:41:55 -0700 From: Jakub Kicinski To: justinpopo6@gmail.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, jannh@google.com, jackychou@asix.com.tw, jesionowskigreg@gmail.com, joalonsof@gmail.com, pabeni@redhat.com, edumazet@google.com, davem@davemloft.net, f.fainelli@gmail.com, justin.chen@broadcom.com Subject: Re: [PATCH 1/5] net: usb: ax88179_178a: remove redundant init code Message-ID: <20220719134155.409fe0e6@kernel.org> In-Reply-To: <1658188689-30846-2-git-send-email-justinpopo6@gmail.com> References: <1658188689-30846-1-git-send-email-justinpopo6@gmail.com> <1658188689-30846-2-git-send-email-justinpopo6@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 18 Jul 2022 16:58:05 -0700 justinpopo6@gmail.com wrote: > From: Justin Chen > > Bind and reset are basically doing the same thing. Remove the duplicate > code and have bind call into reset. > > Signed-off-by: Justin Chen drivers/net/usb/ax88179_178a.c:1329:6: warning: variable 'tmp' set but not used [-Wunused-but-set-variable] u8 *tmp; ^ drivers/net/usb/ax88179_178a.c:1328:7: warning: variable 'tmp16' set but not used [-Wunused-but-set-variable] u16 *tmp16; ^