Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp4868060imw; Tue, 19 Jul 2022 15:05:53 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tBcG03nWIYNZ4ikUU6rQnPKC7a9KRHYNqAIL+hlbbgqBjk7fOLpYFSZ+9CkmHZqEKT7lhH X-Received: by 2002:a17:90a:ff17:b0:1ef:8b4b:8cc0 with SMTP id ce23-20020a17090aff1700b001ef8b4b8cc0mr1710324pjb.155.1658268353174; Tue, 19 Jul 2022 15:05:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658268353; cv=none; d=google.com; s=arc-20160816; b=O/Pl0N2t2udRPb8d+VBsnNN3V9vtQYid03pUyKjpnFwFLGEdJJ75lJC1bxQTe219Wv naKJ17Z5TVwSCqd4TnMmX478L9EIkr6TzlEwWGyttG/LQYS1HWsjD9K4K+0Oo5qkqEHh Tb8CWJatjyMfhsd6oR2JG4k5MF1GW+RKoMFMsgpkDse+LV8cr1GBVUHv+NKowOH5KoOF +vET+t1HaH7edQEBsKMLlQq+pOv5eboLqT2E1RDdlmeCba+NTWlXOcXyMv+6FwHst3sE UW6hmbjy2eJ9hEfOAQkXSTJDOJ75bgdJtPxcq2fw4yMjTIaQvQ39pupeHUFTsIRS62ck PAGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=HGECUZ+gwgXLJgCEPVND4t2Y0/BsOtMsWBLG9CvKJ2U=; b=h81xc+HUgO/8aKo0Sp4qmHwdLL6QGVIFqNeAO3odUYjAoVdBFDO9snzcNvHpYhrfip iwLqnGGJ3AthPRoJHSQsuSUz9FdgVqnEXvhT+lO7QgzMzb3+pZUEl9CrVXoXxhaElyaX DjVbdZGaFd1BVkCK5Yw1Z6pOhceK+Lga+HZ/ppNgxiKtefNeOMPXZTFXSihQf/MAmSRt R/e1OrePEQtrCjAgaakCferH3CRICpluIqLcO6X2fTFdOxLdXKhfCVEn57YMhIH8bGPI Ra1YqDQFc6QJBZLmsZNlfMDbdHmlvtV81TN47FTogbOlfsh9U1QuCZSYAJixRoIJjfH4 bBJw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id rm12-20020a17090b3ecc00b001e0b16a6bb9si287088pjb.159.2022.07.19.15.05.37; Tue, 19 Jul 2022 15:05:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234336AbiGSVzV (ORCPT + 99 others); Tue, 19 Jul 2022 17:55:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231312AbiGSVzT (ORCPT ); Tue, 19 Jul 2022 17:55:19 -0400 Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2768AE0A4; Tue, 19 Jul 2022 14:55:15 -0700 (PDT) Received: by mail-io1-f53.google.com with SMTP id n7so12945996ioo.7; Tue, 19 Jul 2022 14:55:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HGECUZ+gwgXLJgCEPVND4t2Y0/BsOtMsWBLG9CvKJ2U=; b=Tzju7NXXZIJCrDQZsTNKw1qbDr+WZdkf7QOvd9dRrzusd76EMuXbXXzI0j1h7Ew/GS Yug9BBM0xfQ8Uw1EXzmR2xbaku1Q/VxCj8YOFS6Q0Dy25KTtEoIU9Wtlgx9APbDbK2vo BZpkDcdUNrZefP0HAu6sIM7vNRlKYKGEjodTHWt0Gsv5K9ZLIyKV9OXBRsoxQYyqg/uM 8HXsHvHl2+xEpdVt+C2bdGWitjg+/lHV6U2IW6m5had3nCTR3V/1NWMRsBGqVbDE8utb dvd9rdP2Cqi37ko9yLWeQEwmZSOJ1GGuycbQpG/En/iEx6X4SJaVbOFWm6e7f0PZz0qb On/g== X-Gm-Message-State: AJIora/IIzgH11oSMx1A5Ar3+j13/H1+btAhNmAnGhJjXZzQUepgEwqm lLHK7IWF9sPVlUrNyunSiQ== X-Received: by 2002:a05:6638:118c:b0:33f:3425:a798 with SMTP id f12-20020a056638118c00b0033f3425a798mr18251080jas.311.1658267714391; Tue, 19 Jul 2022 14:55:14 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id e25-20020a056602045900b0067bcc80ac23sm7896269iov.1.2022.07.19.14.55.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 14:55:14 -0700 (PDT) Received: (nullmailer pid 1882877 invoked by uid 1000); Tue, 19 Jul 2022 21:55:12 -0000 Date: Tue, 19 Jul 2022 15:55:12 -0600 From: Rob Herring To: Geert Uytterhoeven Cc: Rob Herring , devicetree@vger.kernel.org, Frank Rowand , Pantelis Antoniou , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] of: overlay: Move devicetree_corrupt() check up Message-ID: <20220719215512.GA1882804-robh@kernel.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 15 Jul 2022 16:03:14 +0200, Geert Uytterhoeven wrote: > There is no point in doing several preparatory steps in > of_overlay_fdt_apply(), only to see of_overlay_apply() return early > because of a corrupt device tree. > > Move the check for a corrupt device tree from of_overlay_apply() to > of_overlay_fdt_apply(), to check for this as early as possible. > > Signed-off-by: Geert Uytterhoeven > --- > drivers/of/overlay.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > Applied, thanks!