Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 19 Jul 2022 18:10:59 -0500
From:   Bjorn Helgaas <helgaas@kernel.org>
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     Richard Zhu <hongxing.zhu@nxp.com>, l.stach@pengutronix.de,
        bhelgaas@google.com, robh+dt@kernel.org, broonie@kernel.org,
        lorenzo.pieralisi@arm.com, festevam@gmail.com,
        francesco.dolcini@toradex.com, linux-pci@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        kernel@pengutronix.de, linux-imx@nxp.com
Subject: Re: [PATCH v15 17/17] PCI: imx6: Reformat suspend callback to keep
 symmetric with resume
Message-ID: <20220719231059.GA1590187@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220718131900.GA4002775@roeck-us.net>
Precedence: bulk

On Mon, Jul 18, 2022 at 06:19:00AM -0700, Guenter Roeck wrote:
> On Thu, Jul 14, 2022 at 03:31:09PM +0800, Richard Zhu wrote:
> > Create imx6_pcie_stop_link() and imx6_pcie_host_exit() functions.
> > Encapsulate clocks, regulators disables and PHY uninitialization into
> > imx6_pcie_host_exit().
> > 
> > To keep suspend/resume symmetric as much as possible, invoke these two
> > new created functions in suspend callback.
> > 
> > To be symmetric with imx6_pcie_host_exit(), move imx6_pcie_clk_enable()
> > to imx6_pcie_host_init() from imx6_pcie_deassert_core_reset().
> > 
> > Link: https://lore.kernel.org/r/1656645935-1370-18-git-send-email-hongxing.zhu@nxp.com
> > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> > Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> 
> If CONFIG_PM_SLEEP=n:
> 
> Error log:
> drivers/pci/controller/dwc/pci-imx6.c:973:13: error: 'imx6_pcie_host_exit' defined but not used [-Werror=unused-function]
>   973 | static void imx6_pcie_host_exit(struct dw_pcie_rp *pp)
>       |             ^~~~~~~~~~~~~~~~~~~
> drivers/pci/controller/dwc/pci-imx6.c:904:13: error: 'imx6_pcie_stop_link' defined but not used [-Werror=unused-function]
>   904 | static void imx6_pcie_stop_link(struct dw_pcie *pci)

Thanks, Guenter, I added a patch that should fix this:
https://lore.kernel.org/r/20220719210427.GA1568454@bhelgaas