Date: Sun, 3 Jun 2007 07:45:52 -0700
From: Randy Dunlap <rdunlap@xenotime.net>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: LKML <linux-kernel@vger.kernel.org>, rdunlap@xenotime.net,
       akpm@linux-foundation.org, Chen Li-jun <cljun@xiyou.edu.cn>,
       Wang Ya-gang <lazy_linux@126.com>
Subject: Re: [RFC] Documentation/CodingStyle: Add rules for goto labels
Message-Id: <20070603074552.430c3d02.rdunlap@xenotime.net>
In-Reply-To: <20070603142939.GW4095@ftp.linux.org.uk>
References: <20070603142450.GA4230@localhost.localdomain>
	<20070603142939.GW4095@ftp.linux.org.uk>
Organization: YPO4
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1051
Lines: 25

On Sun, 3 Jun 2007 15:29:39 +0100 Al Viro wrote:

> On Sun, Jun 03, 2007 at 10:24:50PM +0800, WANG Cong wrote:
>   
> > +Do care when you use Lindent to indent your code, since it may use spaces
> > +instead of tabs before a goto label and it may also align the label in a
> > +wrong position. A goto label should be aligned in the column that is 8
> > +characters ahead of the statement just below this label. Please fix it manually
> > +if you find Lindent is wrong.
> 
> Lindent is wrong, but the style you are advocating is, at the very
> least, not universal.  Equally (if not more) common is putting label
> in column 1, period.  Regardless of indentation level of the statement
> following it.

ack Al's style.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/