Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp4963286imw; Tue, 19 Jul 2022 17:24:05 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sD53CwTX6hQiXNZ00GXyTSm3yMCCVs/TyTarDhx77512REXajpib0IP/611C8qghnoEJ4u X-Received: by 2002:a17:907:6ea0:b0:72b:8574:b7c4 with SMTP id sh32-20020a1709076ea000b0072b8574b7c4mr32252354ejc.418.1658276644906; Tue, 19 Jul 2022 17:24:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658276644; cv=none; d=google.com; s=arc-20160816; b=MN3ryrIu/8O8In5n8lFWiBiwzDRKWbKCIwybwrZ2vrESzbZEJRgoW8kIv8dKPFYdty Hpy7CtN6dYw2UVttkwYROXkA4gx+hGTEFPummVdtXAE1zxcr+VCTa4avgLpsuwwd6KUf 2XIzFiPljFwb/VBGJz/JLd/CgmQ1Wq/nFWc+Q2gluUF04Ko3fLJInWI2uI6z7TJJDJ+V zJCjBbVINk9zZETo6/KuJ91T8fe4Ty237c1kJPyDGEsKiw+JWqkPop+ehk9dW6SvvWs6 9A7tbxucMq2j4eSR3n5Lohd6IRuykhRI/oCHsuf2Ke0wVm1J3zfNnrwCehZsVHpDsQ+i xQGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :message-id:date:subject:cc:to:from; bh=8x2tgpnJUMeLLtvcrSj7+fENUSbdQLWBblqAdjxmqHU=; b=Wcd348gHFF/TnapYCjg2kd1L/p8ViTQoEZRItefno3l1UUQmqwCYv86UHDOm5qKBsk zBzWGaDG8JLRg1M+rD0AOsNcNS2AmrJT546OTIPLFUmRo0PYb2EOALX1qChrS98u9yjN yqAqWEuRDB0R7kPTlERwomrZXqA3LMxL4X74QV6M+UeOsZFM2bZzFj+V0ruR07pSRKGc LtW7WdgewwbzaImhUF2qkjflUr4I/Gr44gW/6dZSYj2X3YVM7FvUylkTE3FGkGAY91kW xpyJrmf0QD+89ebWl8KLs9CFTlke9mO8fBSKU3NtJXdtHbpQC8KfZtTAYEPElzH1LWEf g34w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y4-20020a056402440400b0043b52adbf6esi15579079eda.557.2022.07.19.17.23.40; Tue, 19 Jul 2022 17:24:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229869AbiGTAVx convert rfc822-to-8bit (ORCPT + 99 others); Tue, 19 Jul 2022 20:21:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235812AbiGTAVv (ORCPT ); Tue, 19 Jul 2022 20:21:51 -0400 Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com [67.231.145.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C28B155082 for ; Tue, 19 Jul 2022 17:21:50 -0700 (PDT) Received: from pps.filterd (m0044012.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26JI5DRD031376 for ; Tue, 19 Jul 2022 17:21:50 -0700 Received: from maileast.thefacebook.com ([163.114.130.16]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 3hdyj6b7s6-7 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 19 Jul 2022 17:21:50 -0700 Received: from twshared34609.14.frc2.facebook.com (2620:10d:c0a8:1b::d) by mail.thefacebook.com (2620:10d:c0a8:82::f) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 19 Jul 2022 17:21:45 -0700 Received: by devbig932.frc1.facebook.com (Postfix, from userid 4523) id 53FF5A6298E1; Tue, 19 Jul 2022 17:21:39 -0700 (PDT) From: Song Liu To: , , CC: , , , , Song Liu Subject: [PATCH v5 bpf-next 0/4] ftrace: host klp and bpf trampoline together Date: Tue, 19 Jul 2022 17:21:22 -0700 Message-ID: <20220720002126.803253-1-song@kernel.org> X-Mailer: git-send-email 2.30.2 X-FB-Internal: Safe Content-Type: text/plain X-Proofpoint-GUID: VUxLFHca05Nt_q768b51xJnLdn-nNvza X-Proofpoint-ORIG-GUID: VUxLFHca05Nt_q768b51xJnLdn-nNvza Content-Transfer-Encoding: 8BIT X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-19_10,2022-07-19_01,2022-06-22_01 X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Changes v4 => v5: 1. Cleanup direct_mutex handling in register_ftrace_function. (Steven Rostedt, Petr Mladek). 2. Various smallish fixes. (Steven Rostedt, Petr Mladek). Changes v3 => v4: 1. Fix build errors for different config. (kernel test robot) Changes v2 => v3: 1. Major rewrite after discussions with Steven Rostedt. [1] 2. Remove SHARE_IPMODIFY flag from ftrace code. Instead use the callback function to communicate this information. (Steven) 3. Add cleanup_direct_functions_after_ipmodify() to clear SHARE_IPMODIFY on the DIRECT ops when the IPMODIFY ops is removed. Changes v1 => v2: 1. Fix build errors for different config. (kernel test robot) Kernel Live Patch (livepatch, or klp) and bpf trampoline are important features for modern systems. This set allows the two to work on the same kernel function as the same time. live patch uses ftrace with IPMODIFY, while bpf trampoline use direct ftrace. Existing policy does not allow the two to attach to the same kernel function. This is changed by fine tuning ftrace IPMODIFY policy, and allows one IPMODIFY ftrace_ops and one DIRECT ftrace_ops on the same kernel function at the same time. Please see patch 2 and 4 for more details. Note that, one of the constraint here is to let bpf trampoline use direct call when it is not working on the same function as live patch. This is achieved by allowing ftrace code to ask bpf trampoline to make changes. [1] https://lore.kernel.org/all/20220602193706.2607681-2-song@kernel.org/ Jiri Olsa (1): bpf, x64: Allow to use caller address from stack Song Liu (3): ftrace: Add modify_ftrace_direct_multi_nolock ftrace: Allow IPMODIFY and DIRECT ops on the same function bpf: Support bpf_trampoline on functions with IPMODIFY (e.g. livepatch) arch/x86/net/bpf_jit_comp.c | 13 +- include/linux/bpf.h | 13 ++ include/linux/ftrace.h | 43 +++++ kernel/bpf/trampoline.c | 158 +++++++++++++++-- kernel/trace/ftrace.c | 328 ++++++++++++++++++++++++++++++------ 5 files changed, 484 insertions(+), 71 deletions(-) -- 2.30.2