Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 20 Jul 2022 03:00:23 +0100
From:   Al Viro <viro@zeniv.linux.org.uk>
To:     Helge Deller <deller@gmx.de>
Cc:     John David Anglin <dave.anglin@bell.net>,
        Hillf Danton <hdanton@sina.com>, linux-kernel@vger.kernel.org,
        linux-parisc@vger.kernel.org
Subject: Re: WARNING: CPU: 1 PID: 14735 at fs/dcache.c:365
 dentry_free+0x100/0x128
Message-ID: <YtdhtyiEOGFhYdfP@ZenIV>
References: <20220709090756.2384-1-hdanton@sina.com>
 <20220715133300.1297-1-hdanton@sina.com>
 <cff76e00-3561-4069-f5c7-26d3de4da3c4@gmx.de>
 <20220717113634.1552-1-hdanton@sina.com>
 <0aa365ca-a9f0-8d15-b515-adb8823f5d28@gmx.de>
 <7d53692b-6ac8-e1bd-4d0d-7e97aa01b18d@bell.net>
 <76e47f90-bcc2-caab-50c5-6bff7fdc5c1d@gmx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <76e47f90-bcc2-caab-50c5-6bff7fdc5c1d@gmx.de>
Sender: Al Viro <viro@ftp.linux.org.uk>
Precedence: bulk

On Tue, Jul 19, 2022 at 11:25:07PM +0200, Helge Deller wrote:
> On 7/19/22 22:59, John David Anglin wrote:
> > Hi Helge,
> >
> > I hit this warning with the patch below building ghc on mx3210:
> 
> As I wrote, I didn't faced it yet on my buildd server, but that could
> just have been luck...
> Hillf, should we try if this second hunk triggers?
> 
> --- a/fs/dcache.c
> +++ b/fs/dcache.c
> @@ -616,6 +618,7 @@ static void __dentry_kill(struct dentry
>  		dentry->d_flags |= DCACHE_MAY_FREE;
>  		can_free = false;
>  	}
> +	BUG_ON(!hlist_unhashed(&dentry->d_u.d_alias));
>  	spin_unlock(&dentry->d_lock);
>  	if (likely(can_free))
>  		dentry_free(dentry);

Would you gentlemen mind Cc'ing the entire thing to fsdevel?  Or at
least forwarding it my way...