Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Hugh Dickins <hughd@google.com>
CC:     Yu Zhao <yuzhao@google.com>
Subject: [PATCH v12 19/69] xen: use vma_lookup() in privcmd_ioctl_mmap()
Thread-Topic: [PATCH v12 19/69] xen: use vma_lookup() in privcmd_ioctl_mmap()
Thread-Index: AQHYm97oMSPMUJ3Nw0mCLfaBmQrohg==
Date:   Wed, 20 Jul 2022 02:17:49 +0000
Message-ID: <20220720021727.17018-20-Liam.Howlett@oracle.com>
References: <20220720021727.17018-1-Liam.Howlett@oracle.com>
In-Reply-To: <20220720021727.17018-1-Liam.Howlett@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?AX0VTNexlGdAfCpvqlo2ksMNrBaQto2eYOn1uv9mWozZXzoQC6obMm9bph?=
 =?iso-8859-1?Q?rVM2JtRf3QFuL9WVhizDl83UpyMnIv6gQcOrSI38r3ezqvvwhH+VcXCKJy?=
 =?iso-8859-1?Q?LKRUN0gymOcKOFVQFpIsOOIlIezz8qw7P8dBBCeLJ6LJB0c2nvquWcBv9a?=
 =?iso-8859-1?Q?yBbQjKgMyEmtsNCEqmA+AIaEQGt04asEIxkKRsk/H1YMOaS4wrI2cj33On?=
 =?iso-8859-1?Q?D7uTypThTYECzMvkFwzmRK0M36uHZwsJGwlNvGhG1B9cLwLYmQrt8sEu6T?=
 =?iso-8859-1?Q?DzJ66QW33YELNKY4JQPzCueTvjJcaZZXucXu8siviA6Xucj/6rNf8WGnHb?=
 =?iso-8859-1?Q?zqjbEGvzOrI6eJOpIooR/GxSm7XlZDYjnUPSqwgahLRIOasMuGqQRzJ1AJ?=
 =?iso-8859-1?Q?qmq6ShoeydDFFHyPJtfk9TP4IhhRtdbxTGathkX+GdrLiDQgrKaiyYdd4+?=
 =?iso-8859-1?Q?eiZsg3eDFLtgIuUotZsrhcvO5xVtExGIgIJ16q8pfAgPssOSYn5vHQAC1D?=
 =?iso-8859-1?Q?BJ46GdaKHP2/QH5+scK16x6U2uuveEthxN/ma0JAwaTtJEfxhJCBPKeLBa?=
 =?iso-8859-1?Q?a9hDiuf54nXUfE/l5FY2yleMQ3qp1cGqPf2Eun7gmxQx7QS7vqPurfF/hZ?=
 =?iso-8859-1?Q?OvRos9mcYbLeqFbabGHv2iWIcu7XT50gVsJUeF0BxnOt7jG5n4bzE1x/Uy?=
 =?iso-8859-1?Q?nsCRxFzQLHwVNYETopK9+LudKKEUAqyQXiqnP6BfP+nTRSA2RS8uvPogZo?=
 =?iso-8859-1?Q?uPudWX+10Ge14RMqNZlSaILQDYmtunhBHelhNnGqabOaURKf3YGYsotnQs?=
 =?iso-8859-1?Q?diBrIkmP3UjlpfCB5M7nbKcvZxqvGf9ogb1YKTergXDyemYcHsAcykD3Z0?=
 =?iso-8859-1?Q?woLa6iRbJdgoSgnIh4j0SAdN7V7KybGnOutrMFUOkMgRdxR1m/w0+1+hTn?=
 =?iso-8859-1?Q?e+ztM8WyLWekWICVshzB/t0n0ZU56Nm72fd+4yJh3JkH+jeuI6uSop/Ebp?=
 =?iso-8859-1?Q?A6ox7LwYG4YLUj0Q2igLVIynWwa2YN3v00NlAesRIi3McR1Mm7sgjQuS0m?=
 =?iso-8859-1?Q?EP57ngBXi0p0PZ0oBedPtcUfd190R3RJplHABet9Y2/Ay46HwncnlOtaQT?=
 =?iso-8859-1?Q?WuLGqjYHHzLcZsEJnN4+igAbQ2h/21k92SsKTMs09IUrfiMMJpPeJlGs20?=
 =?iso-8859-1?Q?Mjni8A3ay0TtAcqcEG6EuBV4tV5FS/V3lCqvSSJHZvX9c0gn7I8AgQqiqr?=
 =?iso-8859-1?Q?3ku8y678I7wZuj6sM+9wzaNoS+OQWmT/tINSFCZd98iq62CigNKExAMSbP?=
 =?iso-8859-1?Q?Ni9xtqfk4AeCtMpcllLWjwZ8725HqDTCWiPUI3mxAaV54IZD8VlA3FJmSL?=
 =?iso-8859-1?Q?mPeZd/6TFjwL6IjUqUCRUBkxDAWTV7kNWHuxLsCtihociKt1cP3GbGxUs/?=
 =?iso-8859-1?Q?b6yhJLYnHL+6elSOHyE4oWqAiok4C/5aAugq9gMaGlQkgIS5NrBN1g2+yg?=
 =?iso-8859-1?Q?HfYKaHEMh2A72jLU7jV+lbf+QnLaOsjDWUGrErKVZLtCrOxoTSdC1GcOJS?=
 =?iso-8859-1?Q?L4CpE9VstQdPxifLOvSytPAqn9uoadGKSLnYrr3l/AJmnm1VIz3Z56AGIp?=
 =?iso-8859-1?Q?kcAkons8xcp9fDce1moVKa3zQy9+uhJa4+AsVBQJn3qfI6cFxxKbzSvQ?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ec218055-d659-4bb2-4cfc-08da69f60d5c
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2022 02:17:49.8842
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pKeBB5g9aqpHQTmKFrJddW186fC1sO9VswdDvy0O4kehmrpfr9OkMVaF0+C1/43QF+mSndKDZxdkoiM5F/tZtg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB6243
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-19_10,2022-07-19_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 malwarescore=0
 mlxscore=0 phishscore=0 mlxlogscore=999 suspectscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207200008
X-Proofpoint-ORIG-GUID: YF5GyMKrRgQsBW6TgvTFlwO29HWsbdEN
X-Proofpoint-GUID: YF5GyMKrRgQsBW6TgvTFlwO29HWsbdEN
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>

vma_lookup() walks the VMA tree for a specific value, find_vma() will
search the tree after walking to a specific value.  It is more efficient
to only walk to the requested value since privcmd_ioctl_mmap() will exit
the loop if vm_start !=3D msg->va.

Link: https://lkml.kernel.org/r/20220504011345.662299-4-Liam.Howlett@oracle=
.com
Link: https://lkml.kernel.org/r/20220621204632.3370049-20-Liam.Howlett@orac=
le.com
Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: David Howells <dhowells@redhat.com>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: SeongJae Park <sj@kernel.org>
Cc: Will Deacon <will@kernel.org>
Cc: Davidlohr Bueso <dave@stgolabs.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
 drivers/xen/privcmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c
index 3369734108af..ad17166b0ef6 100644
--- a/drivers/xen/privcmd.c
+++ b/drivers/xen/privcmd.c
@@ -282,7 +282,7 @@ static long privcmd_ioctl_mmap(struct file *file, void =
__user *udata)
 						     struct page, lru);
 		struct privcmd_mmap_entry *msg =3D page_address(page);
=20
-		vma =3D find_vma(mm, msg->va);
+		vma =3D vma_lookup(mm, msg->va);
 		rc =3D -EINVAL;
=20
 		if (!vma || (msg->va !=3D vma->vm_start) || vma->vm_private_data)
--=20
2.35.1